diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-03-27 12:08:15 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-03-27 15:49:23 +0200 |
| commit | 19ca4e8a5eb40f3c776a8089a4a043e7fe4a9247 (patch) | |
| tree | 55cec71f8035471f350f4b439b7f4202f224e1af /svtools | |
| parent | 41282255d94bfea01c7f1f5feded9c9e2dc4b178 (diff) | |
Resolves: tdf#116540 Revert "ofz infinite loop"
This reverts commit e4551b905e12aa92b7509d9b994bfae5dec3d8e0.
Change-Id: I95634dd166c51586b5da47b996993a098823ca32
Reviewed-on: https://gerrit.libreoffice.org/51941
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'svtools')
| -rw-r--r-- | svtools/source/svrtf/parrtf.cxx | 8 | ||||
| -rw-r--r-- | svtools/source/svrtf/svparser.cxx | 5 |
2 files changed, 1 insertions, 12 deletions
diff --git a/svtools/source/svrtf/parrtf.cxx b/svtools/source/svrtf/parrtf.cxx index 1ac63c32c342..b6b4ffca6ddf 100644 --- a/svtools/source/svrtf/parrtf.cxx +++ b/svtools/source/svrtf/parrtf.cxx @@ -602,12 +602,8 @@ void SvRTFParser::Continue( int nToken ) if( !nToken ) nToken = GetNextToken(); - bool bLooping = false; - - while (IsParserWorking() && !bLooping) + while( IsParserWorking() ) { - auto nCurrentTokenIndex = m_nTokenIndex; - SaveState( nToken ); switch( nToken ) { @@ -664,8 +660,6 @@ NEXTTOKEN: SaveState( 0 ); // processed till here, // continue with new token! nToken = GetNextToken(); - - bLooping = nCurrentTokenIndex == m_nTokenIndex; } if( SvParserState::Accepted == eState && 0 < nOpenBrakets ) eState = SvParserState::Error; diff --git a/svtools/source/svrtf/svparser.cxx b/svtools/source/svrtf/svparser.cxx index 4ba540ce96d9..27e6c1eede3d 100644 --- a/svtools/source/svrtf/svparser.cxx +++ b/svtools/source/svrtf/svparser.cxx @@ -76,7 +76,6 @@ SvParser<T>::SvParser( SvStream& rIn, sal_uInt8 nStackSize ) , nlLineNr( 1 ) , nlLinePos( 1 ) , pImplData( nullptr ) - , m_nTokenIndex(0) , nTokenValue( 0 ) , bTokenHasValue( false ) , eState( SvParserState::NotStarted ) @@ -476,7 +475,6 @@ T SvParser<T>::GetNextToken() bTokenHasValue = pTokenStackPos->bTokenHasValue; aToken = pTokenStackPos->sToken; nRet = pTokenStackPos->nTokenId; - ++m_nTokenIndex; } // no, now push actual value on stack else if( SvParserState::Working == eState ) @@ -485,7 +483,6 @@ T SvParser<T>::GetNextToken() pTokenStackPos->nTokenValue = nTokenValue; pTokenStackPos->bTokenHasValue = bTokenHasValue; pTokenStackPos->nTokenId = nRet; - ++m_nTokenIndex; } else if( SvParserState::Accepted != eState && SvParserState::Pending != eState ) eState = SvParserState::Error; // an error occurred @@ -504,8 +501,6 @@ T SvParser<T>::SkipToken( short nCnt ) // "skip" n Tokens backward nTmp = nTokenStackSize; nTokenStackPos = sal_uInt8(nTmp); - m_nTokenIndex -= nTmp; - // restore values aToken = pTokenStackPos->sToken; nTokenValue = pTokenStackPos->nTokenValue; |