diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-25 19:21:12 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-26 07:16:07 +0100 |
| commit | c54d34f70819c5928fe30585e86d744eda4a254a (patch) | |
| tree | 81672bb2fd4c95cb09a6ed14197c8a0a8655dcb5 /svtools | |
| parent | 09895ae4963850c05d7a315599195dd177f13b06 (diff) | |
loplugin:passstuffbyref improved return in canvas and svtools
and for now, ignore methods with params so we don't fall into the trap
of thinking that calls to methods like:
Bar& foo(Bar &p) { return p; }
can be converted from
Bar f() { return foo(Bar()); }
to
Bar const & f() { return foo(Bar()); }
Change-Id: Ia3795eb2baf353cb6bec4ebf40451f2789d66ad7
Reviewed-on: https://gerrit.libreoffice.org/47034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svtools')
| -rw-r--r-- | svtools/inc/roadmap.hxx | 2 | ||||
| -rw-r--r-- | svtools/source/config/helpopt.cxx | 2 | ||||
| -rw-r--r-- | svtools/source/contnr/treelistbox.cxx | 4 | ||||
| -rw-r--r-- | svtools/source/control/hyperlabel.cxx | 2 | ||||
| -rw-r--r-- | svtools/source/control/roadmap.cxx | 2 |
5 files changed, 6 insertions, 6 deletions
diff --git a/svtools/inc/roadmap.hxx b/svtools/inc/roadmap.hxx index bfaf39befc25..3056dfb0bff6 100644 --- a/svtools/inc/roadmap.hxx +++ b/svtools/inc/roadmap.hxx @@ -72,7 +72,7 @@ public: bool SelectRoadmapItemByID( ItemId _nItemID ); void SetItemSelectHdl( const Link<LinkParamNone*,void>& _rHdl ); - Link<LinkParamNone*,void> GetItemSelectHdl( ) const; + Link<LinkParamNone*,void> const & GetItemSelectHdl( ) const; virtual void DataChanged( const DataChangedEvent& rDCEvt ) override; virtual void GetFocus() override; virtual void ApplySettings( vcl::RenderContext& rRenderContext ) override; diff --git a/svtools/source/config/helpopt.cxx b/svtools/source/config/helpopt.cxx index 3a2ec50d60da..87029df284eb 100644 --- a/svtools/source/config/helpopt.cxx +++ b/svtools/source/config/helpopt.cxx @@ -279,7 +279,7 @@ bool SvtHelpOptions::IsHelpTips() const return pImpl->IsHelpTips(); } -OUString SvtHelpOptions::GetSystem() const +OUString const & SvtHelpOptions::GetSystem() const { return pImpl->GetSystem(); } diff --git a/svtools/source/contnr/treelistbox.cxx b/svtools/source/contnr/treelistbox.cxx index daa06402ebdc..563679879cbb 100644 --- a/svtools/source/contnr/treelistbox.cxx +++ b/svtools/source/contnr/treelistbox.cxx @@ -140,7 +140,7 @@ SvInplaceEdit2::~SvInplaceEdit2() pEdit.disposeAndClear(); } -OUString SvInplaceEdit2::GetSavedValue() const +OUString const & SvInplaceEdit2::GetSavedValue() const { return pEdit->GetSavedValue(); } @@ -2420,7 +2420,7 @@ void SvTreeListBox::SetCurEntry( SvTreeListEntry* pEntry ) pImpl->SetCurEntry( pEntry ); } -Image SvTreeListBox::GetExpandedNodeBmp( ) const +Image const & SvTreeListBox::GetExpandedNodeBmp( ) const { return pImpl->GetExpandedNodeBmp( ); } diff --git a/svtools/source/control/hyperlabel.cxx b/svtools/source/control/hyperlabel.cxx index ecf89817a862..036088385102 100644 --- a/svtools/source/control/hyperlabel.cxx +++ b/svtools/source/control/hyperlabel.cxx @@ -54,7 +54,7 @@ namespace svt implInit(); } - Size HyperLabel::CalcMinimumSize( long nMaxWidth ) const + Size const & HyperLabel::CalcMinimumSize( long nMaxWidth ) const { m_pImpl->m_aMinSize = FixedText::CalcMinimumSize( nMaxWidth ); // the MinimumSize is used to size the FocusRectangle diff --git a/svtools/source/control/roadmap.cxx b/svtools/source/control/roadmap.cxx index 8f8c40be3050..539f4ec2e46e 100644 --- a/svtools/source/control/roadmap.cxx +++ b/svtools/source/control/roadmap.cxx @@ -507,7 +507,7 @@ void ORoadmap::SetItemSelectHdl(const Link<LinkParamNone*,void>& _rHdl) m_pImpl->setSelectHdl(_rHdl); } -Link<LinkParamNone*,void> ORoadmap::GetItemSelectHdl() const +Link<LinkParamNone*,void> const & ORoadmap::GetItemSelectHdl() const { return m_pImpl->getSelectHdl(); } |