diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-05 08:34:22 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-05 09:22:51 +0200 |
| commit | 17a2c9e8e2361de27013a25e51f3a3ca729f1b31 (patch) | |
| tree | 1c89bc104e5630fb71ff0a5b12c464ca2aceebc3 /svtools | |
| parent | 8fa4b0429b514c0d696ebfc2e47418292d7ec367 (diff) | |
clang-tidy performance-unnecessary-value-param
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svtools')
| -rw-r--r-- | svtools/inc/uitest/uiobject.hxx | 6 | ||||
| -rw-r--r-- | svtools/source/contnr/svlbitm.cxx | 2 | ||||
| -rw-r--r-- | svtools/source/uitest/uiobject.cxx | 8 |
3 files changed, 8 insertions, 8 deletions
diff --git a/svtools/inc/uitest/uiobject.hxx b/svtools/inc/uitest/uiobject.hxx index e8ed0af640af..d8a525c206ee 100644 --- a/svtools/inc/uitest/uiobject.hxx +++ b/svtools/inc/uitest/uiobject.hxx @@ -17,7 +17,7 @@ class SvSimpleTable; class TreeListUIObject : public WindowUIObject { public: - TreeListUIObject(VclPtr<SvTreeListBox> xTreeList); + TreeListUIObject(const VclPtr<SvTreeListBox>& xTreeList); virtual StringMap get_state() override; @@ -43,7 +43,7 @@ class TreeListEntryUIObject : public UIObject { public: - TreeListEntryUIObject(VclPtr<SvTreeListBox> xTreeList, SvTreeListEntry* pEntry); + TreeListEntryUIObject(const VclPtr<SvTreeListBox>& xTreeList, SvTreeListEntry* pEntry); virtual StringMap get_state() override; @@ -66,7 +66,7 @@ private: class SimpleTableUIObject : public TreeListUIObject { public: - SimpleTableUIObject(VclPtr<SvSimpleTable> xTable); + SimpleTableUIObject(const VclPtr<SvSimpleTable>& xTable); virtual StringMap get_state() override; diff --git a/svtools/source/contnr/svlbitm.cxx b/svtools/source/contnr/svlbitm.cxx index f520b747a8c1..ae3e14481534 100644 --- a/svtools/source/contnr/svlbitm.cxx +++ b/svtools/source/contnr/svlbitm.cxx @@ -401,7 +401,7 @@ struct SvLBoxContextBmp_Impl // *************************************************************** -SvLBoxContextBmp::SvLBoxContextBmp(Image aBmp1, Image aBmp2, +SvLBoxContextBmp::SvLBoxContextBmp(const Image& aBmp1, const Image& aBmp2, bool bExpanded) :m_pImpl( new SvLBoxContextBmp_Impl ) { diff --git a/svtools/source/uitest/uiobject.cxx b/svtools/source/uitest/uiobject.cxx index f36d57e153c4..19ab911876af 100644 --- a/svtools/source/uitest/uiobject.cxx +++ b/svtools/source/uitest/uiobject.cxx @@ -13,7 +13,7 @@ #include <svtools/treelistbox.hxx> #include <svtools/simptabl.hxx> -TreeListUIObject::TreeListUIObject(VclPtr<SvTreeListBox> xTreeList): +TreeListUIObject::TreeListUIObject(const VclPtr<SvTreeListBox>& xTreeList): WindowUIObject(xTreeList), mxTreeList(xTreeList) { @@ -21,7 +21,7 @@ TreeListUIObject::TreeListUIObject(VclPtr<SvTreeListBox> xTreeList): namespace { -bool isCheckBoxList(VclPtr<SvTreeListBox> xTreeList) +bool isCheckBoxList(const VclPtr<SvTreeListBox>& xTreeList) { return (xTreeList->GetTreeFlags() & SvTreeFlags::CHKBTN) == SvTreeFlags::CHKBTN; } @@ -90,7 +90,7 @@ std::unique_ptr<UIObject> TreeListUIObject::create(vcl::Window* pWindow) return std::unique_ptr<UIObject>(new TreeListUIObject(pTreeList)); } -TreeListEntryUIObject::TreeListEntryUIObject(VclPtr<SvTreeListBox> xTreeList, SvTreeListEntry* pEntry): +TreeListEntryUIObject::TreeListEntryUIObject(const VclPtr<SvTreeListBox>& xTreeList, SvTreeListEntry* pEntry): mxTreeList(xTreeList), mpEntry(pEntry) { @@ -161,7 +161,7 @@ OUString TreeListEntryUIObject::get_type() const return OUString("TreeListEntry"); } -SimpleTableUIObject::SimpleTableUIObject(VclPtr<SvSimpleTable> xTable): +SimpleTableUIObject::SimpleTableUIObject(const VclPtr<SvSimpleTable>& xTable): TreeListUIObject(xTable), mxTable(xTable) { |