diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2015-09-08 18:26:13 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2015-09-09 07:54:04 +0200 |
commit | 2beeeea4ea3a5799921674310712aa3ead9acd7a (patch) | |
tree | 215ff0f339992cc88c75346fa687f6023becbbf8 /svtools | |
parent | 8083f6b7ed7ec3e72c896e3707c21457dbe173e3 (diff) |
Get rid of OSL_UNUSED
In many cases it was originally used to silence warnings about variables used
only in OSL_ENSURE etc., but that's no longer necessary since OSL_ENSURE is
based on SAL_WARN etc. In some other cases it was apparently used as a
speculative debugging aid, to have a value assigned to a variable to be easily
able to view the value in a debugger. And in some cases it was used with
(otherwise ignored) return values of (typically SQL-related) function calls, but
it is probably better to eventually find and fix all the problematic ones among
such calls via function declarations annotated SAL_WARN_UNUSED_RESULT.
Change-Id: Ib925b38da70073b546fdcd00fa8524dc302accbf
Diffstat (limited to 'svtools')
-rw-r--r-- | svtools/source/uno/svtxgridcontrol.cxx | 6 | ||||
-rw-r--r-- | svtools/source/uno/unogridcolumnfacade.cxx | 3 |
2 files changed, 3 insertions, 6 deletions
diff --git a/svtools/source/uno/svtxgridcontrol.cxx b/svtools/source/uno/svtxgridcontrol.cxx index de5ac2750d3c..aa8908b1e493 100644 --- a/svtools/source/uno/svtxgridcontrol.cxx +++ b/svtools/source/uno/svtxgridcontrol.cxx @@ -631,10 +631,9 @@ void SAL_CALL SVTXGridControl::dataChanged( const GridDataEvent& i_event ) throw } -void SAL_CALL SVTXGridControl::rowHeadingChanged( const GridDataEvent& i_event ) throw (RuntimeException, std::exception) +void SAL_CALL SVTXGridControl::rowHeadingChanged( const GridDataEvent& ) throw (RuntimeException, std::exception) { SolarMutexGuard aGuard; - OSL_UNUSED( i_event ); VclPtr< TableControl > pTable = GetAsDynamic< TableControl >(); ENSURE_OR_RETURN_VOID( pTable, "SVTXGridControl::rowHeadingChanged: no control (anymore)!" ); @@ -666,11 +665,10 @@ void SAL_CALL SVTXGridControl::elementRemoved( const ContainerEvent& i_event ) t } -void SAL_CALL SVTXGridControl::elementReplaced( const ContainerEvent& i_event ) throw (RuntimeException, std::exception) +void SAL_CALL SVTXGridControl::elementReplaced( const ContainerEvent& ) throw (RuntimeException, std::exception) { OSL_ENSURE( false, "SVTXGridControl::elementReplaced: not implemented!" ); // at the moment, the XGridColumnModel API does not allow replacing columns - OSL_UNUSED( i_event ); // TODO: replace the respective column in our table model } diff --git a/svtools/source/uno/unogridcolumnfacade.cxx b/svtools/source/uno/unogridcolumnfacade.cxx index 7e19c7baa6d7..d3b56d8e7152 100644 --- a/svtools/source/uno/unogridcolumnfacade.cxx +++ b/svtools/source/uno/unogridcolumnfacade.cxx @@ -166,9 +166,8 @@ namespace svt { namespace table } - void SAL_CALL ColumnChangeMultiplexer::disposing( const EventObject& i_event ) throw (RuntimeException, std::exception) + void SAL_CALL ColumnChangeMultiplexer::disposing( const EventObject& ) throw (RuntimeException, std::exception) { - OSL_UNUSED( i_event ); } |