diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-01-31 21:11:57 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-02-01 22:10:40 +0000 |
| commit | 9f1ecd3ac35f06746fe2a12ca52899f664679de5 (patch) | |
| tree | b09ac150c72ac69d8e709d8833a05cb65f026344 /svtools | |
| parent | baa5fca0fe50334d0820941763b5e18a244e9921 (diff) | |
coverity#1267678 this is surely backwards (gold)
surely we clone from the source and return the newly created
entry. Presumably this doesn't break all the time because
aCloneLink is generally set ?
coverity#1267678 Resource leak
Change-Id: I3e02dfaef371e006f1510b186cdd881c991ef2cf
Diffstat (limited to 'svtools')
| -rw-r--r-- | svtools/source/contnr/treelist.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx index 60a8d27855c8..1da2c9856d52 100644 --- a/svtools/source/contnr/treelist.cxx +++ b/svtools/source/contnr/treelist.cxx @@ -355,8 +355,8 @@ SvTreeListEntry* SvTreeList::CloneEntry( SvTreeListEntry* pSource ) const if( aCloneLink.IsSet() ) return reinterpret_cast<SvTreeListEntry*>(aCloneLink.Call( pSource )); SvTreeListEntry* pEntry = CreateEntry(); - pSource->Clone( pEntry ); - return pSource; + pEntry->Clone(pSource); + return pEntry; } SvTreeListEntry* SvTreeList::CreateEntry() const |