create ErrorHandlerFlags scoped enum for error handling flags

Change-Id: I30c80979c87bad7bc98f36a158c31c88d80d1caf
Reviewed-on: https://gerrit.libreoffice.org/33991
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 33 insertions, 32 deletions

diff --git a/svtools/source/misc/ehdl.cxx b/svtools/source/misc/ehdl.cxx
index 577953b62ebc..6a3481f002a4 100644
--- a/svtools/source/misc/ehdl.cxx
+++ b/svtools/source/misc/ehdl.cxx
@@ -31,9 +31,9 @@
 #include <memory>
 
 
-static sal_uInt16 aWndFunc(
+static ErrorHandlerFlags aWndFunc(
     vcl::Window *pWin,            // Parent of the dialog
-    sal_uInt16 nFlags,
+    ErrorHandlerFlags nFlags,
     const OUString &rErr,      // error text
     const OUString &rAction)   // action text
 
@@ -52,34 +52,35 @@ static sal_uInt16 aWndFunc(
 
     // determine necessary WinBits from the flags
     WinBits eBits=0;
-    if ( (ERRCODE_BUTTON_CANCEL|ERRCODE_BUTTON_RETRY) == (nFlags & (ERRCODE_BUTTON_CANCEL|ERRCODE_BUTTON_RETRY)) )
+    if ( nFlags & (ErrorHandlerFlags::ButtonsCancel | ErrorHandlerFlags::ButtonsRetry) )
         eBits = WB_RETRY_CANCEL;
-    else if ( ERRCODE_BUTTON_OK_CANCEL == (nFlags & ERRCODE_BUTTON_OK_CANCEL) )
+    else if ( nFlags & ErrorHandlerFlags::ButtonsOkCancel )
         eBits = WB_OK_CANCEL;
-    else if ( ERRCODE_BUTTON_OK == (nFlags & ERRCODE_BUTTON_OK) )
+    else if ( nFlags & ErrorHandlerFlags::ButtonsOk )
         eBits = WB_OK;
-    else if ( ERRCODE_BUTTON_YES_NO_CANCEL == (nFlags & ERRCODE_BUTTON_YES_NO_CANCEL) )
+    else if ( nFlags & ErrorHandlerFlags::ButtonsYesNoCancel )
         eBits = WB_YES_NO_CANCEL;
-    else if ( ERRCODE_BUTTON_YES_NO == (nFlags & ERRCODE_BUTTON_YES_NO) )
+    else if ( nFlags & ErrorHandlerFlags::ButtonsYesNo )
         eBits = WB_YES_NO;
 
-    switch(nFlags & 0x0f00)
+    switch(nFlags & ErrorHandlerFlags(0x0f00))
     {
-      case ERRCODE_BUTTON_DEF_OK:
+      case ErrorHandlerFlags::ButtonDefaultsOk:
             eBits |= WB_DEF_OK;
             break;
 
-      case ERRCODE_BUTTON_DEF_CANCEL:
+      case ErrorHandlerFlags::ButtonDefaultsCancel:
             eBits |= WB_DEF_CANCEL;
             break;
 
-      case ERRCODE_BUTTON_DEF_YES:
+      case ErrorHandlerFlags::ButtonDefaultsYes:
             eBits |= WB_DEF_YES;
             break;
 
-      case ERRCODE_BUTTON_DEF_NO:
+      case ErrorHandlerFlags::ButtonDefaultsNo:
             eBits |= WB_DEF_NO;
             break;
+      default: break;
     }
 
     OUString aErr(SvtResId(STR_ERR_HDLMESS).toString());
@@ -90,48 +91,48 @@ static sal_uInt16 aWndFunc(
     aErr = aErr.replaceAll("$(ERROR)", rErr);
 
     VclPtr<MessBox> pBox;
-    switch ( nFlags & 0xf000 )
+    switch ( nFlags & ErrorHandlerFlags(0xf000) )
     {
-        case ERRCODE_MSG_ERROR:
+        case ErrorHandlerFlags::MessageError:
             pBox.reset(VclPtr<ErrorBox>::Create(pWin, eBits, aErr));
             break;
 
-        case ERRCODE_MSG_WARNING:
+        case ErrorHandlerFlags::MessageWarning:
             pBox.reset(VclPtr<WarningBox>::Create(pWin, eBits, aErr));
             break;
 
-        case ERRCODE_MSG_INFO:
+        case ErrorHandlerFlags::MessageInfo:
             pBox.reset(VclPtr<InfoBox>::Create(pWin, aErr));
             break;
 
-        case ERRCODE_MSG_QUERY:
+        case ErrorHandlerFlags::MessageQuery:
             pBox.reset(VclPtr<QueryBox>::Create(pWin, eBits, aErr));
             break;
 
         default:
         {
             SAL_WARN( "svtools.misc", "no MessBox type");
-            return ERRCODE_BUTTON_OK;
+            return ErrorHandlerFlags::ButtonsOk;
         }
     }
 
-    sal_uInt16 nRet = RET_CANCEL;
+    ErrorHandlerFlags nRet = ErrorHandlerFlags::NONE;
     switch ( pBox->Execute() )
     {
         case RET_OK:
-            nRet = ERRCODE_BUTTON_OK;
+            nRet = ErrorHandlerFlags::ButtonsOk;
             break;
         case RET_CANCEL:
-            nRet = ERRCODE_BUTTON_CANCEL;
+            nRet = ErrorHandlerFlags::ButtonsCancel;
             break;
         case RET_RETRY:
-            nRet = ERRCODE_BUTTON_RETRY;
+            nRet = ErrorHandlerFlags::ButtonsRetry;
             break;
         case RET_YES:
-            nRet = ERRCODE_BUTTON_YES;
+            nRet = ErrorHandlerFlags::ButtonsYes;
             break;
         case RET_NO:
-            nRet = ERRCODE_BUTTON_NO;
+            nRet = ErrorHandlerFlags::ButtonsNo;
             break;
         default:
             SAL_WARN( "svtools.misc", "Unknown MessBox return value" );
@@ -162,7 +163,7 @@ SfxErrorHandler::~SfxErrorHandler()
 
 
 bool SfxErrorHandler::CreateString(
-    const ErrorInfo *pErr, OUString &rStr, sal_uInt16& nFlags) const
+    const ErrorInfo *pErr, OUString &rStr, ErrorHandlerFlags& nFlags) const
 
 /*  [Description]
 
@@ -206,9 +207,9 @@ class ResString: public OUString
     */
 
 {
-    sal_uInt16 nFlags;
+    ErrorHandlerFlags nFlags;
   public:
-    sal_uInt16 GetFlags() const {return nFlags;}
+    ErrorHandlerFlags GetFlags() const {return nFlags;}
     const OUString & GetString() const {return *this;}
     explicit ResString( ResId &rId);
 };
@@ -216,12 +217,12 @@ class ResString: public OUString
 
 ResString::ResString(ResId & rId):
     OUString(rId.SetAutoRelease(false).toString()),
-    nFlags(0)
+    nFlags(ErrorHandlerFlags::NONE)
 {
     ResMgr * pResMgr = rId.GetResMgr();
      // String ctor temporarily sets global ResManager
     if (pResMgr->GetRemainSize())
-        nFlags = sal_uInt16(pResMgr->ReadShort());
+        nFlags = ErrorHandlerFlags(pResMgr->ReadShort());
     rId.SetAutoRelease(true);
     pResMgr->PopContext();
 }
@@ -273,7 +274,7 @@ void SfxErrorHandler::GetClassString(sal_uLong lClassId, OUString &rStr)
 
 
 bool SfxErrorHandler::GetErrorString(
-    sal_uLong lErrId, OUString &rStr, sal_uInt16 &nFlags) const
+    sal_uLong lErrId, OUString &rStr, ErrorHandlerFlags &nFlags) const
 
 /*  [Description]
 
@@ -295,8 +296,8 @@ bool SfxErrorHandler::GetErrorString(
         {
             ResString aErrorString(aEr.GetResString());
 
-            sal_uInt16 nResFlags = aErrorString.GetFlags();
-            if ( nResFlags )
+            ErrorHandlerFlags nResFlags = aErrorString.GetFlags();
+            if ( nResFlags != ErrorHandlerFlags::NONE )
                 nFlags = nResFlags;
             rStr = rStr.replaceAll("$(ERROR)", aErrorString.GetString());
             bRet = true;