loplugin:stringadd in svtools

Change-Id: Ic085990173051f421d1ffc7914574cb63a7ae21d
Reviewed-on: https://gerrit.libreoffice.org/79982
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 14 insertions, 26 deletions

diff --git a/svtools/source/brwbox/datwin.cxx b/svtools/source/brwbox/datwin.cxx
index 33ba6eaf1d5c..c40b9142892c 100644
--- a/svtools/source/brwbox/datwin.cxx
+++ b/svtools/source/brwbox/datwin.cxx
@@ -667,8 +667,7 @@ void BrowserScrollBar::Tracking( const TrackingEvent& rTEvt )
     sal_uLong nPos = GetThumbPos();
     if ( nPos != _nLastPos )
     {
-        OUString aTip( OUString::number(nPos) );
-        aTip += "/";
+        OUString aTip = OUString::number(nPos) + "/";
         if ( !_pDataWin->GetRealRowCount().isEmpty() )
             aTip += _pDataWin->GetRealRowCount();
         else
diff --git a/svtools/source/config/printoptions.cxx b/svtools/source/config/printoptions.cxx
index c866a0af8d17..c7d3353911dc 100644
--- a/svtools/source/config/printoptions.cxx
+++ b/svtools/source/config/printoptions.cxx
@@ -696,8 +696,7 @@ SvtPrinterOptions::SvtPrinterOptions()
     // ... and initialize our data container only if it not already!
     if( m_pStaticDataContainer == nullptr )
     {
-        OUString aRootPath( ROOTNODE_START );
-        aRootPath += "/Printer";
+        OUString aRootPath = ROOTNODE_START "/Printer";
         m_pStaticDataContainer = new SvtPrintOptions_Impl( aRootPath );
         pPrinterOptionsDataContainer = m_pStaticDataContainer;
         svtools::ItemHolder2::holdConfigItem(EItem::PrintOptions);
@@ -731,8 +730,7 @@ SvtPrintFileOptions::SvtPrintFileOptions()
     // ... and initialize our data container only if it not already!
     if( m_pStaticDataContainer == nullptr )
     {
-        OUString aRootPath( ROOTNODE_START );
-        aRootPath += "/File";
+        OUString aRootPath = ROOTNODE_START "/File";
         m_pStaticDataContainer = new SvtPrintOptions_Impl( aRootPath );
         pPrintFileOptionsDataContainer = m_pStaticDataContainer;
 
diff --git a/svtools/source/contnr/fileview.cxx b/svtools/source/contnr/fileview.cxx
index 96303b749b35..40df91d555ff 100644
--- a/svtools/source/contnr/fileview.cxx
+++ b/svtools/source/contnr/fileview.cxx
@@ -1863,9 +1863,9 @@ OUString SvtFileView_Impl::FolderInserted( const OUString& rURL, const OUString&
     // title, type, size, date
     aValue = pData->GetTitle();
     ReplaceTabWithString( aValue );
-    aValue += aTab + pData->maType + aTab;
-    // folders don't have a size
-    aValue += aTab;
+    aValue += aTab + pData->maType + aTab +
+        // folders don't have a size
+        aTab;
     // set the date
     SvtSysLocale aSysLocale;
     const LocaleDataWrapper& rLocaleData = aSysLocale.GetLocaleData();
diff --git a/svtools/source/control/inettbc.cxx b/svtools/source/control/inettbc.cxx
index b64d9ba12ff4..7f1a940f1981 100644
--- a/svtools/source/control/inettbc.cxx
+++ b/svtools/source/control/inettbc.cxx
@@ -338,8 +338,7 @@ void SvtMatchContext_Impl::ReadFolder( const OUString& rURL,
     {
         // a home that refers to /
 
-        OUString aNewText( aText );
-        aNewText += "/";
+        OUString aNewText = aText + "/";
         Insert( aNewText, rURL, true );
 
         return;
@@ -642,8 +641,7 @@ void MatchContext_Impl::ReadFolder( const OUString& rURL,
     {
         // a home that refers to /
 
-        OUString aNewText( aText );
-        aNewText += "/";
+        OUString aNewText = aText + "/";
         Insert( aNewText, rURL, true );
 
         return;
diff --git a/svtools/source/control/toolbarmenuacc.cxx b/svtools/source/control/toolbarmenuacc.cxx
index 32a9169dedc6..b3d97a9ecbb4 100644
--- a/svtools/source/control/toolbarmenuacc.cxx
+++ b/svtools/source/control/toolbarmenuacc.cxx
@@ -651,8 +651,8 @@ OUString SAL_CALL ToolbarMenuEntryAcc::getAccessibleName()
 
         if( aRet.isEmpty() )
         {
-            aRet = "Item ";
-            aRet += OUString::number( mpParent->mnEntryId );
+            aRet = "Item " +
+                OUString::number( mpParent->mnEntryId );
         }
     }
 
diff --git a/svtools/source/dialogs/addresstemplate.cxx b/svtools/source/dialogs/addresstemplate.cxx
index b2c730ff47f0..ef6401ba6ebf 100644
--- a/svtools/source/dialogs/addresstemplate.cxx
+++ b/svtools/source/dialogs/addresstemplate.cxx
@@ -297,9 +297,7 @@ void AssignmentPersistentData::ImplCommit()
         OUString sAssignment;
         if (hasFieldAssignment(_rLogicalName))
         {
-            OUString sFieldPath("Fields/");
-            sFieldPath += _rLogicalName;
-            sFieldPath += "/AssignedFieldName";
+            OUString sFieldPath = "Fields/" + _rLogicalName + "/AssignedFieldName";
             sAssignment = getStringProperty(sFieldPath);
         }
         return sAssignment;
@@ -356,9 +354,7 @@ void AssignmentPersistentData::ImplCommit()
         OUString sDescriptionNodePath("Fields");
 
         // Fields/<field>
-        OUString sFieldElementNodePath(sDescriptionNodePath);
-        sFieldElementNodePath += "/";
-        sFieldElementNodePath += _rLogicalName;
+        OUString sFieldElementNodePath = sDescriptionNodePath + "/" + _rLogicalName;
 
         Sequence< PropertyValue > aNewFieldDescription(2);
         // Fields/<field>/ProgrammaticFieldName
diff --git a/svtools/source/misc/imagemgr.cxx b/svtools/source/misc/imagemgr.cxx
index 03132e258926..bd16300c5ced 100644
--- a/svtools/source/misc/imagemgr.cxx
+++ b/svtools/source/misc/imagemgr.cxx
@@ -734,8 +734,7 @@ OUString SvFileInformationManager::GetDescription_Impl( const INetURLObject& rOb
         {
             bShowExt = false;
             sExtension = sExtension.toAsciiUpperCase();
-            sDescription = sExtension;
-            sDescription += "-";
+            sDescription = sExtension + "-";
         }
         sDescription += SvtResId(pResId);
     }
@@ -744,9 +743,7 @@ OUString SvFileInformationManager::GetDescription_Impl( const INetURLObject& rOb
 
     if ( bShowExt )
     {
-        sDescription += " (";
-        sDescription += sExtension;
-        sDescription += ")";
+        sDescription += " (" + sExtension + ")";
     }
 
     return sDescription;