Change all Idle* LINKs to be Timer*

Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles
Link in the Timer class. Now there are two possible solution:

1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or
2. split the inheritance of Idle from Timer again to maintain
different Link<>s and move all common code into a TimerBase.

While the 1st is more correct, the 2nd has a better indicator for
Idles. This implements the first solution.

And while at it, this also converts all call sites of SetTimeoutHdl
and SetIdleHdl to SetInvokeHandler and gets rid of some local Link
objects, which are just passed to the SetInvokeHandler call.

It also introduces ClearInvokeHandler() and replaces the respective
call sites of SetInvokeHandler( Link<Timer *, void>() ).

Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69

16 files changed, 41 insertions, 41 deletions

diff --git a/svtools/source/brwbox/datwin.cxx b/svtools/source/brwbox/datwin.cxx
index 51f0c0e45d57..3ba541a524a6 100644
--- a/svtools/source/brwbox/datwin.cxx
+++ b/svtools/source/brwbox/datwin.cxx
@@ -203,7 +203,7 @@ BrowserDataWin::BrowserDataWin( BrowseBox* pParent )
     ,m_nDragRowDividerLimit( 0 )
     ,m_nDragRowDividerOffset( 0 )
 {
-    aMouseTimer.SetTimeoutHdl( LINK( this, BrowserDataWin, RepeatedMouseMove ) );
+    aMouseTimer.SetInvokeHandler( LINK( this, BrowserDataWin, RepeatedMouseMove ) );
     aMouseTimer.SetTimeout( 100 );
 }
 
diff --git a/svtools/source/contnr/fileview.cxx b/svtools/source/contnr/fileview.cxx
index d8c00d9bc91a..104317b50141 100644
--- a/svtools/source/contnr/fileview.cxx
+++ b/svtools/source/contnr/fileview.cxx
@@ -522,7 +522,7 @@ ViewTabListBox_Impl::ViewTabListBox_Impl( vcl::Window* pParentWin,
         mpHeaderBar->Show();
 
     maResetQuickSearch.SetTimeout( QUICK_SEARCH_TIMEOUT );
-    maResetQuickSearch.SetTimeoutHdl( LINK( this, ViewTabListBox_Impl, ResetQuickSearch_Impl ) );
+    maResetQuickSearch.SetInvokeHandler( LINK( this, ViewTabListBox_Impl, ResetQuickSearch_Impl ) );
 
     Reference< XComponentContext > xContext = ::comphelper::getProcessComponentContext();
     Reference< XInteractionHandler > xInteractionHandler(
diff --git a/svtools/source/contnr/imivctl.hxx b/svtools/source/contnr/imivctl.hxx
index b6ee38a5a93a..6a108e369785 100644
--- a/svtools/source/contnr/imivctl.hxx
+++ b/svtools/source/contnr/imivctl.hxx
@@ -219,12 +219,12 @@ class SvxIconChoiceCtrl_Impl
 
                         DECL_LINK( ScrollUpDownHdl, ScrollBar*, void );
                         DECL_LINK( ScrollLeftRightHdl, ScrollBar*, void );
-                        DECL_LINK( EditTimeoutHdl, Idle *, void);
+                        DECL_LINK( EditTimeoutHdl, Timer *, void);
                         DECL_LINK( UserEventHdl, void*, void );
-                        DECL_LINK( AutoArrangeHdl, Idle*, void );
-                        DECL_LINK( DocRectChangedHdl, Idle*, void );
-                        DECL_LINK( VisRectChangedHdl, Idle*, void );
-                        DECL_LINK( CallSelectHdlHdl, Idle*, void );
+                        DECL_LINK( AutoArrangeHdl, Timer*, void );
+                        DECL_LINK( DocRectChangedHdl, Timer*, void );
+                        DECL_LINK( VisRectChangedHdl, Timer*, void );
+                        DECL_LINK( CallSelectHdlHdl, Timer*, void );
 
     void                AdjustScrollBars();
     void                PositionScrollBars( long nRealWidth, long nRealHeight );
diff --git a/svtools/source/contnr/imivctl1.cxx b/svtools/source/contnr/imivctl1.cxx
index 58cc3a6852e2..a08a2627cd1e 100644
--- a/svtools/source/contnr/imivctl1.cxx
+++ b/svtools/source/contnr/imivctl1.cxx
@@ -64,7 +64,7 @@ class IcnViewEdit_Impl : public MultiLineEdit
     bool            bGrabFocus;
 
     void            CallCallBackHdl_Impl();
-                    DECL_LINK(Timeout_Impl, Idle *, void);
+                    DECL_LINK(Timeout_Impl, Timer *, void);
                     DECL_LINK( ReturnHdl_Impl, Accelerator&, void );
                     DECL_LINK( EscapeHdl_Impl, Accelerator&, void );
 
@@ -140,23 +140,23 @@ SvxIconChoiceCtrl_Impl::SvxIconChoiceCtrl_Impl(
     nVerSBarWidth = aVerSBar->GetSizePixel().Width();
 
     aEditIdle.SetPriority( TaskPriority::LOWEST );
-    aEditIdle.SetIdleHdl(LINK(this,SvxIconChoiceCtrl_Impl,EditTimeoutHdl));
+    aEditIdle.SetInvokeHandler(LINK(this,SvxIconChoiceCtrl_Impl,EditTimeoutHdl));
     aEditIdle.SetDebugName( "svtools::SvxIconChoiceCtrl_Impl aEditIdle" );
 
     aAutoArrangeIdle.SetPriority( TaskPriority::LOW );
-    aAutoArrangeIdle.SetIdleHdl(LINK(this,SvxIconChoiceCtrl_Impl,AutoArrangeHdl));
+    aAutoArrangeIdle.SetInvokeHandler(LINK(this,SvxIconChoiceCtrl_Impl,AutoArrangeHdl));
     aAutoArrangeIdle.SetDebugName( "svtools::SvxIconChoiceCtrl_Impl aAutoArrangeIdle" );
 
     aCallSelectHdlIdle.SetPriority( TaskPriority::LOWEST );
-    aCallSelectHdlIdle.SetIdleHdl( LINK(this,SvxIconChoiceCtrl_Impl,CallSelectHdlHdl));
+    aCallSelectHdlIdle.SetInvokeHandler( LINK(this,SvxIconChoiceCtrl_Impl,CallSelectHdlHdl));
     aCallSelectHdlIdle.SetDebugName( "svtools::SvxIconChoiceCtrl_Impl aCallSelectHdlIdle" );
 
     aDocRectChangedIdle.SetPriority( TaskPriority::MEDIUM );
-    aDocRectChangedIdle.SetIdleHdl(LINK(this,SvxIconChoiceCtrl_Impl,DocRectChangedHdl));
+    aDocRectChangedIdle.SetInvokeHandler(LINK(this,SvxIconChoiceCtrl_Impl,DocRectChangedHdl));
     aDocRectChangedIdle.SetDebugName( "svtools::SvxIconChoiceCtrl_Impl aDocRectChangedIdle" );
 
     aVisRectChangedIdle.SetPriority( TaskPriority::MEDIUM );
-    aVisRectChangedIdle.SetIdleHdl(LINK(this,SvxIconChoiceCtrl_Impl,VisRectChangedHdl));
+    aVisRectChangedIdle.SetInvokeHandler(LINK(this,SvxIconChoiceCtrl_Impl,VisRectChangedHdl));
     aVisRectChangedIdle.SetDebugName( "svtools::SvxIconChoiceCtrl_Impl aVisRectChangedIdle" );
 
     Clear( true );
@@ -2657,18 +2657,18 @@ void SvxIconChoiceCtrl_Impl::ClearSelectedRectList()
     aSelectedRectList.clear();
 }
 
-IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, AutoArrangeHdl, Idle *, void)
+IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, AutoArrangeHdl, Timer *, void)
 {
     aAutoArrangeIdle.Stop();
     Arrange( IsAutoArrange(), 0, 0 );
 }
 
-IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, VisRectChangedHdl, Idle *, void)
+IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, VisRectChangedHdl, Timer *, void)
 {
     aVisRectChangedIdle.Stop();
 }
 
-IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, DocRectChangedHdl, Idle *, void)
+IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, DocRectChangedHdl, Timer *, void)
 {
     aDocRectChangedIdle.Stop();
 }
@@ -2681,7 +2681,7 @@ bool SvxIconChoiceCtrl_Impl::IsTextHit( SvxIconChoiceCtrlEntry* pEntry, const Po
     return false;
 }
 
-IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, EditTimeoutHdl, Idle *, void)
+IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, EditTimeoutHdl, Timer *, void)
 {
     SvxIconChoiceCtrlEntry* pEntry = GetCurEntry();
     if( bEntryEditingEnabled && pEntry &&
@@ -3033,7 +3033,7 @@ IcnViewEdit_Impl::IcnViewEdit_Impl( SvtIconChoiceCtrl* pParent, const Point& rPo
     bGrabFocus( false )
 {
     maLoseFocusIdle.SetPriority(TaskPriority::REPAINT);
-    maLoseFocusIdle.SetIdleHdl(LINK(this,IcnViewEdit_Impl,Timeout_Impl));
+    maLoseFocusIdle.SetInvokeHandler(LINK(this,IcnViewEdit_Impl,Timeout_Impl));
     maLoseFocusIdle.SetDebugName( "svx::IcnViewEdit_Impl maLoseFocusIdle" );
 
     // FIXME: Outside of Paint Hierarchy
@@ -3086,7 +3086,7 @@ void IcnViewEdit_Impl::CallCallBackHdl_Impl()
     }
 }
 
-IMPL_LINK_NOARG(IcnViewEdit_Impl, Timeout_Impl, Idle *, void)
+IMPL_LINK_NOARG(IcnViewEdit_Impl, Timeout_Impl, Timer *, void)
 {
     CallCallBackHdl_Impl();
 }
@@ -3504,7 +3504,7 @@ void SvxIconChoiceCtrl_Impl::CallSelectHandler( SvxIconChoiceCtrlEntry* )
         aCallSelectHdlIdle.Start();
 }
 
-IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, CallSelectHdlHdl, Idle *, void)
+IMPL_LINK_NOARG(SvxIconChoiceCtrl_Impl, CallSelectHdlHdl, Timer *, void)
 {
     pHdlEntry = nullptr;
     pView->ClickIcon();
diff --git a/svtools/source/contnr/svimpbox.cxx b/svtools/source/contnr/svimpbox.cxx
index 9cbe0fa421a1..b25a5a068851 100644
--- a/svtools/source/contnr/svimpbox.cxx
+++ b/svtools/source/contnr/svimpbox.cxx
@@ -90,7 +90,7 @@ SvImpLBox::SvImpLBox( SvTreeListBox* pLBView, SvTreeList* pLBTree, WinBits nWinS
 
     bAsyncBeginDrag     = false;
     aAsyncBeginDragIdle.SetPriority( TaskPriority::HIGHEST );
-    aAsyncBeginDragIdle.SetIdleHdl( LINK(this,SvImpLBox,BeginDragHdl));
+    aAsyncBeginDragIdle.SetInvokeHandler( LINK(this,SvImpLBox,BeginDragHdl));
     // button animation in listbox
     pActiveButton = nullptr;
     pActiveEntry = nullptr;
@@ -100,7 +100,7 @@ SvImpLBox::SvImpLBox( SvTreeListBox* pLBView, SvTreeList* pLBTree, WinBits nWinS
     nCurTabPos = FIRST_ENTRY_TAB;
 
     aEditIdle.SetPriority( TaskPriority::LOWEST );
-    aEditIdle.SetIdleHdl( LINK(this,SvImpLBox,EditTimerCall) );
+    aEditIdle.SetInvokeHandler( LINK(this,SvImpLBox,EditTimerCall) );
 
     nMostRight = -1;
     pMostRightEntry = nullptr;
@@ -2888,7 +2888,7 @@ void SvImpLBox::BeginDrag()
     }
 }
 
-IMPL_LINK_NOARG(SvImpLBox, BeginDragHdl, Idle *, void)
+IMPL_LINK_NOARG(SvImpLBox, BeginDragHdl, Timer *, void)
 {
     pView->StartDrag( 0, aAsyncBeginDragPos );
 }
@@ -3085,7 +3085,7 @@ void SvImpLBox::SetCurEntry( SvTreeListEntry* pEntry )
         pView->Select( pEntry );
 }
 
-IMPL_LINK_NOARG(SvImpLBox, EditTimerCall, Idle *, void)
+IMPL_LINK_NOARG(SvImpLBox, EditTimerCall, Timer *, void)
 {
     if( pView->IsInplaceEditingEnabled() )
     {
diff --git a/svtools/source/contnr/treelistbox.cxx b/svtools/source/contnr/treelistbox.cxx
index 649a7fb8cfa2..bd87930beb8d 100644
--- a/svtools/source/contnr/treelistbox.cxx
+++ b/svtools/source/contnr/treelistbox.cxx
@@ -200,13 +200,13 @@ void SvInplaceEdit2::LoseFocus()
     {
         bCanceled = false;
         aIdle.SetPriority(TaskPriority::REPAINT);
-        aIdle.SetIdleHdl(LINK(this,SvInplaceEdit2,Timeout_Impl));
+        aIdle.SetInvokeHandler(LINK(this,SvInplaceEdit2,Timeout_Impl));
         aIdle.SetDebugName( "svtools::SvInplaceEdit2 aIdle" );
         aIdle.Start();
     }
 }
 
-IMPL_LINK_NOARG(SvInplaceEdit2, Timeout_Impl, Idle *, void)
+IMPL_LINK_NOARG(SvInplaceEdit2, Timeout_Impl, Timer *, void)
 {
     CallCallBackHdl_Impl();
 }
diff --git a/svtools/source/control/asynclink.cxx b/svtools/source/control/asynclink.cxx
index 20cd96d9f79d..e9995af5473b 100644
--- a/svtools/source/control/asynclink.cxx
+++ b/svtools/source/control/asynclink.cxx
@@ -60,7 +60,7 @@ AsynchronLink::~AsynchronLink()
     delete _pMutex;
 }
 
-IMPL_LINK_NOARG( AsynchronLink, HandleCall_Idle, Idle*, void )
+IMPL_LINK_NOARG( AsynchronLink, HandleCall_Idle, Timer*, void )
 {
     if( _pMutex ) _pMutex->acquire();
     _nEventId = nullptr;
diff --git a/svtools/source/control/calendar.cxx b/svtools/source/control/calendar.cxx
index 80b9b507bd55..a6d1fe0e8e5c 100644
--- a/svtools/source/control/calendar.cxx
+++ b/svtools/source/control/calendar.cxx
@@ -204,7 +204,7 @@ void Calendar::ImplInit( WinBits nWinStyle )
     for (sal_Int32 i = 0; i < 31; ++i)
         maDayTexts[i] = OUString::number(i+1);
 
-    maDragScrollTimer.SetTimeoutHdl( LINK( this, Calendar, ScrollHdl ) );
+    maDragScrollTimer.SetInvokeHandler( LINK( this, Calendar, ScrollHdl ) );
     maDragScrollTimer.SetTimeout( GetSettings().GetMouseSettings().GetScrollRepeat() );
     mnDragScrollHitTest = 0;
 
diff --git a/svtools/source/control/tabbar.cxx b/svtools/source/control/tabbar.cxx
index c88fdf0958e2..7ff5d2b0d3ba 100644
--- a/svtools/source/control/tabbar.cxx
+++ b/svtools/source/control/tabbar.cxx
@@ -381,7 +381,7 @@ private:
     bool            mbPostEvt;
 
                     DECL_LINK( ImplEndEditHdl, void*, void );
-                    DECL_LINK( ImplEndTimerHdl, Idle*, void );
+                    DECL_LINK( ImplEndTimerHdl, Timer*, void );
 
 public:
                     TabBarEdit( TabBar* pParent, WinBits nWinStyle );
@@ -400,7 +400,7 @@ TabBarEdit::TabBarEdit( TabBar* pParent, WinBits nWinStyle ) :
 {
     mbPostEvt = false;
     maLoseFocusIdle.SetPriority( TaskPriority::REPAINT );
-    maLoseFocusIdle.SetIdleHdl( LINK( this, TabBarEdit, ImplEndTimerHdl ) );
+    maLoseFocusIdle.SetInvokeHandler( LINK( this, TabBarEdit, ImplEndTimerHdl ) );
     maLoseFocusIdle.SetDebugName( "svtools::TabBarEdit maLoseFocusIdle" );
 }
 
@@ -461,7 +461,7 @@ IMPL_LINK( TabBarEdit, ImplEndEditHdl, void*, pCancel, void )
         GetParent()->EndEditMode( pCancel != nullptr );
 }
 
-IMPL_LINK_NOARG(TabBarEdit, ImplEndTimerHdl, Idle *, void)
+IMPL_LINK_NOARG(TabBarEdit, ImplEndTimerHdl, Timer *, void)
 {
     if ( HasFocus() )
         return;
diff --git a/svtools/source/control/valueset.cxx b/svtools/source/control/valueset.cxx
index a5e76491a3a1..7db07e38d959 100644
--- a/svtools/source/control/valueset.cxx
+++ b/svtools/source/control/valueset.cxx
@@ -1132,7 +1132,7 @@ void ValueSet::ImplTracking( const Point& rPos, bool bRepeat )
         {
             if ( mbSelection )
             {
-                maTimer.SetTimeoutHdl( LINK( this, ValueSet, ImplTimerHdl ) );
+                maTimer.SetInvokeHandler( LINK( this, ValueSet, ImplTimerHdl ) );
                 maTimer.SetTimeout( GetSettings().GetMouseSettings().GetScrollRepeat() );
                 maTimer.Start();
             }
diff --git a/svtools/source/dialogs/prnsetup.cxx b/svtools/source/dialogs/prnsetup.cxx
index d5cba5f396f6..84d3283dc520 100644
--- a/svtools/source/dialogs/prnsetup.cxx
+++ b/svtools/source/dialogs/prnsetup.cxx
@@ -228,7 +228,7 @@ PrinterSetupDialog::PrinterSetupDialog(vcl::Window* pParent)
     mpTempPrinter   = nullptr;
 
     maStatusTimer.SetTimeout( IMPL_PRINTDLG_STATUS_UPDATE );
-    maStatusTimer.SetTimeoutHdl( LINK( this, PrinterSetupDialog, ImplStatusHdl ) );
+    maStatusTimer.SetInvokeHandler( LINK( this, PrinterSetupDialog, ImplStatusHdl ) );
     m_pBtnProperties->SetClickHdl( LINK( this, PrinterSetupDialog, ImplPropertiesHdl ) );
     m_pLbName->SetSelectHdl( LINK( this, PrinterSetupDialog, ImplChangePrinterHdl ) );
 }
diff --git a/svtools/source/dialogs/wizdlg.cxx b/svtools/source/dialogs/wizdlg.cxx
index 1f2835834e71..386ee9ac1836 100644
--- a/svtools/source/dialogs/wizdlg.cxx
+++ b/svtools/source/dialogs/wizdlg.cxx
@@ -58,7 +58,7 @@ void WizardDialog::ImplInitData()
     mnLeftAlignCount = 0;
 
     maWizardLayoutIdle.SetPriority(TaskPriority::RESIZE);
-    maWizardLayoutIdle.SetIdleHdl( LINK( this, WizardDialog, ImplHandleWizardLayoutTimerHdl ) );
+    maWizardLayoutIdle.SetInvokeHandler( LINK( this, WizardDialog, ImplHandleWizardLayoutTimerHdl ) );
 }
 
 
@@ -114,7 +114,7 @@ void WizardDialog::queue_resize(StateChangedType /*eReason*/)
     maWizardLayoutIdle.Start();
 }
 
-IMPL_LINK_NOARG( WizardDialog, ImplHandleWizardLayoutTimerHdl, Idle*, void )
+IMPL_LINK_NOARG( WizardDialog, ImplHandleWizardLayoutTimerHdl, Timer*, void )
 {
     ImplPosCtrls();
     ImplPosTabPage();
diff --git a/svtools/source/graphic/grfcache.cxx b/svtools/source/graphic/grfcache.cxx
index dc67cae5170d..1d2cf43a8e6f 100644
--- a/svtools/source/graphic/grfcache.cxx
+++ b/svtools/source/graphic/grfcache.cxx
@@ -832,7 +832,7 @@ GraphicCache::GraphicCache( sal_uLong nDisplayCacheSize, sal_uLong nMaxObjDispla
     mnMaxObjDisplaySize     ( nMaxObjDisplayCacheSize ),
     mnUsedDisplaySize       ( 0UL )
 {
-    maReleaseTimer.SetTimeoutHdl( LINK( this, GraphicCache, ReleaseTimeoutHdl ) );
+    maReleaseTimer.SetInvokeHandler( LINK( this, GraphicCache, ReleaseTimeoutHdl ) );
     maReleaseTimer.SetTimeout( 10000 );
     maReleaseTimer.Start();
 }
diff --git a/svtools/source/graphic/grfmgr.cxx b/svtools/source/graphic/grfmgr.cxx
index c452101e8929..f315955f53b3 100644
--- a/svtools/source/graphic/grfmgr.cxx
+++ b/svtools/source/graphic/grfmgr.cxx
@@ -401,7 +401,7 @@ void GraphicObject::SetSwapStreamHdl(const Link<const GraphicObject*, SvStream*>
         if (!mxSwapOutTimer)
         {
             mxSwapOutTimer.reset(new Timer("svtools::GraphicObject mpSwapOutTimer"));
-            mxSwapOutTimer->SetTimeoutHdl( LINK( this, GraphicObject, ImplAutoSwapOutHdl ) );
+            mxSwapOutTimer->SetInvokeHandler( LINK( this, GraphicObject, ImplAutoSwapOutHdl ) );
         }
 
         mxSwapOutTimer->SetTimeout( nSwapOutTimeout );
diff --git a/svtools/source/inc/svimpbox.hxx b/svtools/source/inc/svimpbox.hxx
index f2ed5bb4880b..28b2615e593c 100644
--- a/svtools/source/inc/svimpbox.hxx
+++ b/svtools/source/inc/svimpbox.hxx
@@ -148,9 +148,9 @@ private:
 
     std::vector< short > aContextBmpWidthVector;
 
-    DECL_LINK(EditTimerCall, Idle *, void);
+    DECL_LINK(EditTimerCall, Timer *, void);
 
-    DECL_LINK( BeginDragHdl, Idle*, void );
+    DECL_LINK( BeginDragHdl, Timer*, void );
 
     void                InvalidateEntriesFrom( long nY ) const;
     bool                IsLineVisible( long nY ) const;
diff --git a/svtools/source/misc/filechangedchecker.cxx b/svtools/source/misc/filechangedchecker.cxx
index f696b8621f3b..daca97fb1d30 100644
--- a/svtools/source/misc/filechangedchecker.cxx
+++ b/svtools/source/misc/filechangedchecker.cxx
@@ -22,7 +22,7 @@ FileChangedChecker::FileChangedChecker(const OUString& rFilename,
     getCurrentModTime(mLastModTime);
 
     // associate the callback function for the Idle
-    mIdle.SetIdleHdl(LINK(this, FileChangedChecker, TimerHandler));
+    mIdle.SetInvokeHandler(LINK(this, FileChangedChecker, TimerHandler));
 
     //start the timer
     resetTimer();
@@ -76,7 +76,7 @@ bool FileChangedChecker::hasFileChanged()
         return false;
 }
 
-IMPL_LINK_NOARG(FileChangedChecker, TimerHandler, Idle *, void)
+IMPL_LINK_NOARG(FileChangedChecker, TimerHandler, Timer *, void)
 {
     // If the file has changed, then update the graphic in the doc
     SAL_INFO("svtools", "Timeout Called");