diff options
author | Noel <noel.grandin@collabora.co.uk> | 2021-03-26 16:15:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-03-28 10:26:06 +0200 |
commit | c7483d48df1b9ae70335346846d02a4fc53b4558 (patch) | |
tree | 6cca794ebcdd0b9a81733836fa154658d083f173 /svtools | |
parent | 2ac95bccba859b7dd117e135d7c4f7a35017d9f9 (diff) |
drop operator bool and operator! from Bitmap and BitmapEx
IRC chat:
<quikee[m]> noelgrandin: doesn't adding operator bool to Bitmap
has the same problem as Graphic and the reason why you dropped that
commit 7334034ae93b49fc93b5859a3c047a319d138282
"drop Graphic::operator bool"
<noelgrandin> quikee[m], hmmm, good point
<noelgrandin> maybe I should just drop both operator bool and
operator! in favor of IsEmpty
<quikee[m]> noelgrandin: I don't remember what the problem is I just
remembered we dropped it Graphic :) sure, dropping everything for
IsEmpty is probably the best
Change-Id: Ieae289cda64f0b8d8fdecd5ea9e6f2bb874ff4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113163
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svtools')
-rw-r--r-- | svtools/source/table/gridtablerenderer.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svtools/source/table/gridtablerenderer.cxx b/svtools/source/table/gridtablerenderer.cxx index 08de04b177e9..8a68ccdbba2a 100644 --- a/svtools/source/table/gridtablerenderer.cxx +++ b/svtools/source/table/gridtablerenderer.cxx @@ -78,7 +78,7 @@ namespace svt::table StyleSettings const & i_style, bool const i_sortAscending ) { BitmapEx& rBitmap(i_sortAscending ? m_sortAscending : m_sortDescending); - if (!rBitmap || (i_headerHeight != m_lastHeaderHeight) || (i_style.GetActiveColor() != m_lastArrowColor)) + if (rBitmap.IsEmpty() || (i_headerHeight != m_lastHeaderHeight) || (i_style.GetActiveColor() != m_lastArrowColor)) { tools::Long const nSortIndicatorWidth = 2 * i_headerHeight / 3; tools::Long const nSortIndicatorHeight = 2 * nSortIndicatorWidth / 3; |