clarify that set_visible(true/false) is just show/hide

ditch duplicate method

Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b
Reviewed-on: https://gerrit.libreoffice.org/69302
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

4 files changed, 46 insertions, 46 deletions

diff --git a/svtools/source/dialogs/PlaceEditDialog.cxx b/svtools/source/dialogs/PlaceEditDialog.cxx
index 34f93b949ecc..089a7f525dc4 100644
--- a/svtools/source/dialogs/PlaceEditDialog.cxx
+++ b/svtools/source/dialogs/PlaceEditDialog.cxx
@@ -354,19 +354,19 @@ void PlaceEditDialog::SelectType(bool bSkipSeparator)
     }
 
     if (m_xCurrentDetails.get())
-        m_xCurrentDetails->show(false);
+        m_xCurrentDetails->set_visible(false);
 
     const int nPos = m_xLBServerType->get_active( );
     m_xCurrentDetails = m_aDetailsContainers[nPos];
     m_nCurrentType = nPos;
 
-    m_xCurrentDetails->show();
+    m_xCurrentDetails->set_visible(true);
 
-    m_xCBPassword->show( m_bShowPassword && m_xCurrentDetails->enableUserCredentials() );
-    m_xEDPassword->show( m_bShowPassword && m_xCurrentDetails->enableUserCredentials() );
-    m_xFTPasswordLabel->show( m_bShowPassword && m_xCurrentDetails->enableUserCredentials() );
-    m_xEDUsername->show( m_xCurrentDetails->enableUserCredentials() );
-    m_xFTUsernameLabel->show( m_xCurrentDetails->enableUserCredentials() );
+    m_xCBPassword->set_visible( m_bShowPassword && m_xCurrentDetails->enableUserCredentials() );
+    m_xEDPassword->set_visible( m_bShowPassword && m_xCurrentDetails->enableUserCredentials() );
+    m_xFTPasswordLabel->set_visible( m_bShowPassword && m_xCurrentDetails->enableUserCredentials() );
+    m_xEDUsername->set_visible( m_xCurrentDetails->enableUserCredentials() );
+    m_xFTUsernameLabel->set_visible( m_xCurrentDetails->enableUserCredentials() );
 
     m_xDialog->resize_to_request();
 
diff --git a/svtools/source/dialogs/ServerDetailsControls.cxx b/svtools/source/dialogs/ServerDetailsControls.cxx
index 3e87457d533c..e65150b7cff5 100644
--- a/svtools/source/dialogs/ServerDetailsControls.cxx
+++ b/svtools/source/dialogs/ServerDetailsControls.cxx
@@ -51,7 +51,7 @@ DetailsContainer::~DetailsContainer( )
 {
 }
 
-void DetailsContainer::show( bool )
+void DetailsContainer::set_visible( bool )
 {
     m_pDialog->m_xDetailsGrid->set_sensitive(true);
 
@@ -88,17 +88,17 @@ HostDetailsContainer::HostDetailsContainer(PlaceEditDialog* pDialog, sal_uInt16
     m_nDefaultPort( nPort ),
     m_sScheme( sScheme )
 {
-    show( false );
+    set_visible( false );
 }
 
-void HostDetailsContainer::show( bool bShow )
+void HostDetailsContainer::set_visible( bool bShow )
 {
-    m_pDialog->m_xFTHost->show( bShow );
-    m_pDialog->m_xHostBox->show( bShow );
-    m_pDialog->m_xEDRoot->show( bShow );
-    m_pDialog->m_xFTRoot->show( bShow );
+    m_pDialog->m_xFTHost->set_visible( bShow );
+    m_pDialog->m_xHostBox->set_visible( bShow );
+    m_pDialog->m_xEDRoot->set_visible( bShow );
+    m_pDialog->m_xFTRoot->set_visible( bShow );
 
-    DetailsContainer::show( bShow );
+    DetailsContainer::set_visible( bShow );
 
     if ( bShow )
     {
@@ -156,17 +156,17 @@ DavDetailsContainer::DavDetailsContainer(PlaceEditDialog* pBuilder)
 {
     m_pDialog->m_xCBDavs->connect_toggled(LINK(this, DavDetailsContainer, ToggledDavsHdl));
 
-    show( false );
+    set_visible( false );
 }
 
-void DavDetailsContainer::show( bool bShow )
+void DavDetailsContainer::set_visible( bool bShow )
 {
-    HostDetailsContainer::show( bShow );
+    HostDetailsContainer::set_visible( bShow );
 
     if ( !bShow )
         m_pDialog->m_xCBDavs->set_active(false);
 
-    m_pDialog->m_xCBDavs->show(bShow);
+    m_pDialog->m_xCBDavs->set_visible(bShow);
 }
 
 bool DavDetailsContainer::verifyScheme( const OUString& rScheme )
@@ -207,7 +207,7 @@ SmbDetailsContainer::SmbDetailsContainer(PlaceEditDialog* pDialog)
 {
     m_pDialog->m_xEDShare->connect_changed( LINK( this, DetailsContainer, ValueChangeHdl ) );
 
-    show( false );
+    set_visible( false );
 }
 
 INetURLObject SmbDetailsContainer::getUrl( )
@@ -257,15 +257,15 @@ bool SmbDetailsContainer::setUrl( const INetURLObject& rUrl )
     return bSuccess;
 }
 
-void SmbDetailsContainer::show( bool bShow )
+void SmbDetailsContainer::set_visible( bool bShow )
 {
-    m_pDialog->m_xEDShare->show( bShow );
-    m_pDialog->m_xFTShare->show( bShow );
-    m_pDialog->m_xEDRoot->show( bShow );
-    m_pDialog->m_xFTRoot->show( bShow );
+    m_pDialog->m_xEDShare->set_visible( bShow );
+    m_pDialog->m_xFTShare->set_visible( bShow );
+    m_pDialog->m_xEDRoot->set_visible( bShow );
+    m_pDialog->m_xFTRoot->set_visible( bShow );
 
-    m_pDialog->m_xFTHost->show( bShow );
-    m_pDialog->m_xHostBox->show( bShow );
+    m_pDialog->m_xFTHost->set_visible( bShow );
+    m_pDialog->m_xHostBox->set_visible( bShow );
     m_pDialog->m_xEDPort->set_sensitive( !bShow );
     m_pDialog->m_xFTPort->set_sensitive( !bShow );
 
@@ -287,10 +287,10 @@ CmisDetailsContainer::CmisDetailsContainer(PlaceEditDialog* pParentDialog, OUStr
         InteractionHandler::createWithParent(xContext, m_xParentDialog), UNO_QUERY);
     m_xCmdEnv = new ucbhelper::CommandEnvironment( xGlobalInteractionHandler, Reference< XProgressHandler >() );
 
-    show( false );
+    set_visible( false );
 }
 
-void CmisDetailsContainer::show( bool bShow )
+void CmisDetailsContainer::set_visible( bool bShow )
 {
     m_pDialog->m_xLBRepository->connect_changed( LINK( this, CmisDetailsContainer, SelectRepoHdl ) );
     m_pDialog->m_xBTRepoRefresh->connect_clicked( LINK( this, CmisDetailsContainer, RefreshReposHdl ) );
@@ -301,24 +301,24 @@ void CmisDetailsContainer::show( bool bShow )
             || m_sBinding.startsWith( ALFRESCO_CLOUD_BASE_URL )
             || ( m_sBinding == ONEDRIVE_BASE_URL ) )
     {
-        m_pDialog->m_xFTHost->show( false );
-        m_pDialog->m_xHostBox->show( false );
-        m_pDialog->m_xFTRepository->show( false );
-        m_pDialog->m_xRepositoryBox->show( false );
-        m_pDialog->m_xEDRoot->show( false );
-        m_pDialog->m_xFTRoot->show( false );
+        m_pDialog->m_xFTHost->hide();
+        m_pDialog->m_xHostBox->hide();
+        m_pDialog->m_xFTRepository->hide();
+        m_pDialog->m_xRepositoryBox->hide();
+        m_pDialog->m_xEDRoot->hide();
+        m_pDialog->m_xFTRoot->hide();
     }
     else
     {
-        m_pDialog->m_xFTHost->show( bShow );
-        m_pDialog->m_xHostBox->show( bShow );
-        m_pDialog->m_xFTRepository->show( bShow );
-        m_pDialog->m_xRepositoryBox->show( bShow );
-        m_pDialog->m_xEDRoot->show( bShow );
-        m_pDialog->m_xFTRoot->show( bShow );
+        m_pDialog->m_xFTHost->set_visible( bShow );
+        m_pDialog->m_xHostBox->set_visible( bShow );
+        m_pDialog->m_xFTRepository->set_visible( bShow );
+        m_pDialog->m_xRepositoryBox->set_visible( bShow );
+        m_pDialog->m_xEDRoot->set_visible( bShow );
+        m_pDialog->m_xFTRoot->set_visible( bShow );
     }
 
-    DetailsContainer::show( bShow );
+    DetailsContainer::set_visible( bShow );
     m_pDialog->m_xEDPort->set_sensitive( !bShow );
     m_pDialog->m_xFTPort->set_sensitive( !bShow );
 }
diff --git a/svtools/source/dialogs/addresstemplate.cxx b/svtools/source/dialogs/addresstemplate.cxx
index d297231d65df..c2abda3193d8 100644
--- a/svtools/source/dialogs/addresstemplate.cxx
+++ b/svtools/source/dialogs/addresstemplate.cxx
@@ -975,8 +975,8 @@ void AssignmentPersistentData::ImplCommit()
             // an invisible left hand side column, too. But right now, the left hand side controls are always
             // visible)
             bool bHideRightColumn = pRightColumnLabel->isEmpty();
-            (*pRightLabelControl)->show(!bHideRightColumn);
-            (*pRightListControl)->show(!bHideRightColumn);
+            (*pRightLabelControl)->set_visible(!bHideRightColumn);
+            (*pRightListControl)->set_visible(!bHideRightColumn);
             // the new selections of the listboxes
             implSelectField(pLeftListControl->get(), *pLeftAssignment);
             implSelectField(pRightListControl->get(), *pRightAssignment);
diff --git a/svtools/source/dialogs/prnsetup.cxx b/svtools/source/dialogs/prnsetup.cxx
index aed17b36ff4e..03afe9eef0ad 100644
--- a/svtools/source/dialogs/prnsetup.cxx
+++ b/svtools/source/dialogs/prnsetup.cxx
@@ -40,7 +40,7 @@ void ImplFillPrnDlgListBox( const Printer* pPrinter,
     }
 
     pBox->set_sensitive(nCount != 0);
-    pPropBtn->show( pPrinter->HasSupport( PrinterSupport::SetupDialog ) );
+    pPropBtn->set_visible( pPrinter->HasSupport( PrinterSupport::SetupDialog ) );
 }
 
 
@@ -244,7 +244,7 @@ PrinterSetupDialog::~PrinterSetupDialog()
 void PrinterSetupDialog::SetOptionsHdl(const Link<weld::Button&, void>& rLink)
 {
     m_xBtnOptions->connect_clicked(rLink);
-    m_xBtnOptions->show(rLink.IsSet());
+    m_xBtnOptions->set_visible(rLink.IsSet());
 }
 
 void PrinterSetupDialog::ImplSetInfo()