diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-02-11 15:56:21 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-02-12 10:31:25 +0100 |
| commit | f147b160aef1735d34c488353a7d4b875788a7e1 (patch) | |
| tree | ab3bd613cf016cde906b3fdcbaab4246ca699e1e /svtools | |
| parent | 718f540fb63af27c1336f89213444e9af753b8a9 (diff) | |
clang-analyzer-deadcode.DeadStores
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svtools')
| -rw-r--r-- | svtools/source/svrtf/parrtf.cxx | 4 | ||||
| -rw-r--r-- | svtools/source/table/tablecontrol_impl.cxx | 12 |
2 files changed, 8 insertions, 8 deletions
diff --git a/svtools/source/svrtf/parrtf.cxx b/svtools/source/svrtf/parrtf.cxx index 16d3eb7146f4..a52b8ee4f3af 100644 --- a/svtools/source/svrtf/parrtf.cxx +++ b/svtools/source/svrtf/parrtf.cxx @@ -204,7 +204,7 @@ int SvRTFParser::GetNextToken_() cAnsi = GetNextChar(); if( '\\' == cAnsi && - '\'' == ( cAnsi = GetNextChar() )) + '\'' == GetNextChar() ) // skip HexValue GetHexValue(); nNextCh = GetNextChar(); @@ -441,7 +441,7 @@ void SvRTFParser::ScanText() cAnsi = GetNextChar(); if( '\\' == cAnsi && - '\'' == ( cAnsi = GetNextChar() )) + '\'' == GetNextChar() ) // skip HexValue GetHexValue(); nNextCh = GetNextChar(); diff --git a/svtools/source/table/tablecontrol_impl.cxx b/svtools/source/table/tablecontrol_impl.cxx index a0cc092a8c04..dbdaa91ce536 100644 --- a/svtools/source/table/tablecontrol_impl.cxx +++ b/svtools/source/table/tablecontrol_impl.cxx @@ -1402,7 +1402,7 @@ namespace svt::table case cursorSelectRow: { if(m_pSelEngine->GetSelectionMode() == SelectionMode::NONE) - return bSuccess = false; + return false; //pos is the position of the current row in the vector of selected rows, if current row is selected int pos = getRowSelectedNumber(m_aSelectedRows, m_nCurRow); //if current row is selected, it should be deselected, when ALT+SPACE are pressed @@ -1423,7 +1423,7 @@ namespace svt::table case cursorSelectRowUp: { if(m_pSelEngine->GetSelectionMode() == SelectionMode::NONE) - return bSuccess = false; + return false; else if(m_pSelEngine->GetSelectionMode() == SelectionMode::Single) { //if there are other selected rows, deselect them @@ -1454,7 +1454,7 @@ namespace svt::table if(m_nCurRow>0) m_nCurRow--; else - return bSuccess = true; + return true; //if nextRow already selected, deselect it, otherwise select it if(nextRow>-1 && m_aSelectedRows[nextRow] == m_nCurRow) { @@ -1537,7 +1537,7 @@ namespace svt::table if(m_nCurRow<m_nRowCount-1) m_nCurRow++; else - return bSuccess = true; + return true; //if next row already selected, deselect it, otherwise select it if(nextRow>-1 && m_aSelectedRows[nextRow] == m_nCurRow) { @@ -1618,9 +1618,9 @@ namespace svt::table case cursorSelectRowAreaBottom: { if(m_pSelEngine->GetSelectionMode() == SelectionMode::NONE) - return bSuccess = false; + return false; else if(m_pSelEngine->GetSelectionMode() == SelectionMode::Single) - return bSuccess = false; + return false; //select the region between the current and the last row RowPos iter = m_nCurRow; invalidateSelectedRegion( m_nCurRow, m_nRowCount-1 ); |