diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-11 18:09:21 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-11 19:38:11 +0100 |
| commit | b7f022234589c84ddb8566ddf7d91701eba55d3d (patch) | |
| tree | de7be277e5244eed8f034912a338a420f6989b3f /svtools | |
| parent | 2301cb300acc1ad534a21ad93e8ed34ed71ba937 (diff) | |
tdf#120703 PVS: V560 A part of conditional expression is always true
This changes the condition to only select row if it's not selected yet;
previously, because of the always-true condition or'ed, SelectRow was
always executed.
Change-Id: Id12b640518f3d72810e997735216db336d79f7f6
Reviewed-on: https://gerrit.libreoffice.org/63267
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'svtools')
| -rw-r--r-- | svtools/source/brwbox/brwbox2.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svtools/source/brwbox/brwbox2.cxx b/svtools/source/brwbox/brwbox2.cxx index c9ba487b91e0..4280c0818332 100644 --- a/svtools/source/brwbox/brwbox2.cxx +++ b/svtools/source/brwbox/brwbox2.cxx @@ -453,7 +453,7 @@ void BrowseBox::ExpandRowSelection( const BrowserMouseEvent& rEvt ) } } else - if ( !bMultiSelection || !IsRowSelected( rEvt.GetRow() ) ) + if (!IsRowSelected(rEvt.GetRow())) SelectRow( rEvt.GetRow() ); GoToRow( rEvt.GetRow(), false ); |