svtools,svx: prefer passing OUString and OString by reference

Change-Id: Iceb2cbcda9d8ddb4ee00db9365c751e0e5d8b3a6

7 files changed, 9 insertions, 7 deletions

diff --git a/svtools/source/config/helpopt.cxx b/svtools/source/config/helpopt.cxx
index a646c17a4a0f..7284b524b9e6 100644
--- a/svtools/source/config/helpopt.cxx
+++ b/svtools/source/config/helpopt.cxx
@@ -135,7 +135,7 @@ SvtHelpOptions_Impl::SvtHelpOptions_Impl()
 }
 
 
-static int lcl_MapPropertyName( const OUString rCompare,
+static int lcl_MapPropertyName( const OUString& rCompare,
                 const uno::Sequence< OUString>& aInternalPropertyNames)
 {
     for(int nProp = 0; nProp < aInternalPropertyNames.getLength(); ++nProp)
diff --git a/svtools/source/config/miscopt.cxx b/svtools/source/config/miscopt.cxx
index c94a4d020465..c5a2ffa1996f 100644
--- a/svtools/source/config/miscopt.cxx
+++ b/svtools/source/config/miscopt.cxx
@@ -436,7 +436,7 @@ SvtMiscOptions_Impl::~SvtMiscOptions_Impl()
     }
 }
 
-static int lcl_MapPropertyName( const OUString rCompare,
+static int lcl_MapPropertyName( const OUString& rCompare,
                 const uno::Sequence< OUString>& aInternalPropertyNames)
 {
     for(int nProp = 0; nProp < aInternalPropertyNames.getLength(); ++nProp)
diff --git a/svtools/source/config/slidesorterbaropt.cxx b/svtools/source/config/slidesorterbaropt.cxx
index 4ae14c40633d..d9a31d8cce09 100644
--- a/svtools/source/config/slidesorterbaropt.cxx
+++ b/svtools/source/config/slidesorterbaropt.cxx
@@ -182,7 +182,7 @@ SvtSlideSorterBarOptions_Impl::~SvtSlideSorterBarOptions_Impl()
     Commit();
 }
 
-static int lcl_MapPropertyName( const OUString rCompare,
+static int lcl_MapPropertyName( const OUString& rCompare,
                 const uno::Sequence< OUString>& aInternalPropertyNames)
 {
     for(int nProp = 0; nProp < aInternalPropertyNames.getLength(); ++nProp)
diff --git a/svtools/source/config/toolpanelopt.cxx b/svtools/source/config/toolpanelopt.cxx
index ccc975543886..1e89f3fdcf7e 100644
--- a/svtools/source/config/toolpanelopt.cxx
+++ b/svtools/source/config/toolpanelopt.cxx
@@ -180,7 +180,7 @@ SvtToolPanelOptions_Impl::~SvtToolPanelOptions_Impl()
     Commit();
 }
 
-static int lcl_MapPropertyName( const OUString rCompare,
+static int lcl_MapPropertyName( const OUString& rCompare,
                 const uno::Sequence< OUString>& aInternalPropertyNames)
 {
     for(int nProp = 0; nProp < aInternalPropertyNames.getLength(); ++nProp)
diff --git a/svtools/source/control/inettbc.cxx b/svtools/source/control/inettbc.cxx
index 33bcf894b1b7..5a2e8b822b73 100644
--- a/svtools/source/control/inettbc.cxx
+++ b/svtools/source/control/inettbc.cxx
@@ -469,9 +469,11 @@ void SvtMatchContext_Impl::ReadFolder( const OUString& rURL,
 }
 
 
-OUString SvtURLBox::ParseSmart( OUString aText, OUString aBaseURL, const OUString& aWorkDir )
+OUString SvtURLBox::ParseSmart( const OUString& _aText, const OUString& _aBaseURL, const OUString& aWorkDir )
 {
     OUString aMatch;
+    OUString aText = _aText;
+    OUString aBaseURL = _aBaseURL;
 
     // parse ~ for Unix systems
     // does nothing for Windows
diff --git a/svtools/source/dialogs/ServerDetailsControls.cxx b/svtools/source/dialogs/ServerDetailsControls.cxx
index a270a5dfe7b3..7300d4fc92d5 100644
--- a/svtools/source/dialogs/ServerDetailsControls.cxx
+++ b/svtools/source/dialogs/ServerDetailsControls.cxx
@@ -69,7 +69,7 @@ IMPL_LINK( DetailsContainer, ValueChangeHdl, void *, EMPTYARG )
     return 0;
 }
 
-HostDetailsContainer::HostDetailsContainer( VclBuilderContainer* pBuilder, sal_uInt16 nPort, OUString sScheme ) :
+HostDetailsContainer::HostDetailsContainer( VclBuilderContainer* pBuilder, sal_uInt16 nPort, const OUString& sScheme ) :
     DetailsContainer( pBuilder, "HostDetails" ),
     m_nDefaultPort( nPort ),
     m_sScheme( sScheme )
diff --git a/svtools/source/uno/toolboxcontroller.cxx b/svtools/source/uno/toolboxcontroller.cxx
index 8568d0b78577..95addd72ff6c 100644
--- a/svtools/source/uno/toolboxcontroller.cxx
+++ b/svtools/source/uno/toolboxcontroller.cxx
@@ -633,7 +633,7 @@ void ToolboxController::updateStatus()
     bindListener();
 }
 
-void ToolboxController::updateStatus( const OUString aCommandURL )
+void ToolboxController::updateStatus( const OUString& aCommandURL )
 {
     Reference< XDispatch > xDispatch;
     Reference< XStatusListener > xStatusListener;