summaryrefslogtreecommitdiff
path: root/svx/inc/strings.hxx
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2020-03-06 09:42:04 +0100
committerMiklos Vajna <vmiklos@collabora.com>2020-03-06 10:19:20 +0100
commit191b43536a2bee034ef9902b49ca5fbcdbddec53 (patch)
tree6cd291cb9a82877b06a00cdfffe4b2fbd37e68d9 /svx/inc/strings.hxx
parent30a6e9e991fd1b62ead2d393331a0364372c52fb (diff)
SwModelTestBase: speed up export tests
Export tests used to do the following steps: 1) Import 2) Verify 3) Discard state 4) Import 5) Export 6) Import 7) Verify Assuming that the cost of 2), 3) and 7) is almost zero, that leaves us with 4 filter() invocations for every such "export" test. But it seems to me, we can save one filter() call if we do it this way: 1) Import 2) Verify 3) Export 4) Import 5) Verify The only trick is that verify should perform its verification by only reading the document model. So adapt tests which mutated the doc model: paste tests should be import tests, the rest only did mutation by accident. A 'make check' is 88 seconds faster for me with this, using -j8. (~12 minutes of CPU time saved.) Change-Id: I40db8a9b9adaa99020acd718ba4ec3fd9bee3fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90077 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
Diffstat (limited to 'svx/inc/strings.hxx')
0 files changed, 0 insertions, 0 deletions