diff options
| author | Xisco Fauli <xiscofauli@libreoffice.org> | 2021-04-19 21:37:53 +0200 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2021-04-20 09:31:38 +0200 |
| commit | eec03e848cb6874ce6d64dc0b8f45dbaf52e6c2b (patch) | |
| tree | 76049007161f5a1a66f2a3a242bc4e126791004f /svx/inc | |
| parent | 4cb71fefc61d9015a0142f3a4fdafc5250913f2c (diff) | |
tdf#86321: Revert "Resolves: #i123539# some optimizations for 3D chart..."
This reverts commit db1d2af02861b49e4f53d726d59cd71c20cee9b1
The commit was already partically reverted in
bca8d8985666d3fd22b91eb280f9baaeb933c2d0 < Resolves: tdf#90583
3D pie-chart missing guide handles >.
This partial revert broke the optimization introduced in
db1d2af02861b49e4f53d726d59cd71c20cee9b1 <Resolves: #i123539#
some optimizations for 3D chart...> for 3D charts like
https://bz.apache.org/ooo/attachment.cgi?id=81810
Later, 3D charts were optimized again in
55a7e836a2db662a53adc4f8b98d08b06790c758 < chart2: When
creating objects prevent setting object rects dirty > so
the remaining code originally introduced can go.
Import time of https://bz.apache.org/ooo/attachment.cgi?id=81810
is the same with and without this patch
Change-Id: I25338d0dfb4b41651dfe05e7bfbd74c86091dacb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114313
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'svx/inc')
| -rw-r--r-- | svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx b/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx index ac7a861e924f..f034f02a6da5 100644 --- a/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx +++ b/svx/inc/sdr/contact/viewcontactofsdrole2obj.hxx @@ -31,9 +31,6 @@ namespace sdr::contact class ViewContactOfSdrOle2Obj final : public ViewContactOfSdrRectObj { private: - // #i123539# allow local buffering of chart data (if chart) - drawinglayer::primitive2d::Primitive2DReference mxChartContent; - // Create an Object-Specific ViewObjectContact, set ViewContact and // ObjectContact. Always needs to return something. virtual ViewObjectContact& @@ -56,9 +53,6 @@ public: // from the VOC which knows that drawinglayer::primitive2d::Primitive2DContainer createPrimitive2DSequenceWithParameters() const; - // #i123539# get rid of buffered chart content (if there) on change - virtual void ActionChanged() override; - virtual basegfx::B2DRange getRange(const drawinglayer::geometry::ViewInformation2D& rViewInfo2D) const override; |