convert ReadByteString/WriteByteString from ByteString to OString

Nobody ever used the return values anyway, so for reading just
return the string and for writing the number of bytes written

Doesn't need to be members, make standalone functions

Rename  to
read_lenPrefixed_uInt8s_ToO[U]String and
write_lenPrefixed_uInt8s_FromO[U]String, lengthy,
but much less unambiguous, seeing as a lot of users of it don't
seem to be aware that they read/write pascal-style length
prefixed strings, which isn't surprising given the
apparent simplicity of their original name.

added a unit test

3 files changed, 40 insertions, 40 deletions

diff --git a/svx/inc/svx/gallery1.hxx b/svx/inc/svx/gallery1.hxx
index aa5cc4aa0f8e..de6ebc684a32 100644
--- a/svx/inc/svx/gallery1.hxx
+++ b/svx/inc/svx/gallery1.hxx
@@ -47,16 +47,16 @@ class GalleryThemeEntry
 {
 private:
 
-    String                  aName;
+    rtl::OUString           aName;
     INetURLObject           aThmURL;
     INetURLObject           aSdgURL;
     INetURLObject           aSdvURL;
-    sal_uInt32                  nFileNumber;
-    sal_uInt32                  nId;
-    sal_Bool                    bReadOnly;
-    sal_Bool                    bImported;
-    sal_Bool                    bModified;
-    sal_Bool                    bThemeNameFromResource;
+    sal_uInt32              nFileNumber;
+    sal_uInt32              nId;
+    sal_Bool                bReadOnly;
+    sal_Bool                bImported;
+    sal_Bool                bModified;
+    sal_Bool                bThemeNameFromResource;
 
                             GalleryThemeEntry();
     INetURLObject           ImplGetURLIgnoreCase( const INetURLObject& rURL ) const;
@@ -68,26 +68,26 @@ public:
                                                sal_Bool bNewFile, sal_uInt32 nId, sal_Bool bThemeNameFromResource );
                             ~GalleryThemeEntry() {};
 
-    const String&           GetThemeName() const { return aName; }
-    sal_uInt32                  GetFileNumber() const { return nFileNumber; }
+    const rtl::OUString&    GetThemeName() const { return aName; }
+    sal_uInt32              GetFileNumber() const { return nFileNumber; }
 
     const INetURLObject&    GetThmURL() const { return aThmURL; }
     const INetURLObject&    GetSdgURL() const { return aSdgURL; }
     const INetURLObject&    GetSdvURL() const { return aSdvURL; }
 
-    sal_Bool                    IsImported() const { return bImported; }
-    sal_Bool                    IsReadOnly() const { return bReadOnly; }
-    sal_Bool                    IsDefault() const;
+    sal_Bool                IsImported() const { return bImported; }
+    sal_Bool                IsReadOnly() const { return bReadOnly; }
+    sal_Bool                IsDefault() const;
 
-    sal_Bool                    IsHidden() const { return aName.SearchAscii( "private://gallery/hidden/" ) == 0; }
+    sal_Bool                IsHidden() const { return aName.matchAsciiL(RTL_CONSTASCII_STRINGPARAM("private://gallery/hidden/")); }
 
-    sal_Bool                    IsModified() const { return bModified; }
+    sal_Bool                IsModified() const { return bModified; }
     void                    SetModified( sal_Bool bSet ) { bModified = ( bSet && !IsImported() && !IsReadOnly() ); }
 
-    void                    SetName( const String& rNewName );
-    sal_Bool                    IsNameFromResource() const { return bThemeNameFromResource; }
+    void                    SetName( const rtl::OUString& rNewName );
+    sal_Bool                IsNameFromResource() const { return bThemeNameFromResource; }
 
-    sal_uInt32                  GetId() const { return nId; }
+    sal_uInt32              GetId() const { return nId; }
     void                    SetId( sal_uInt32 nNewId, sal_Bool bResetThemeName );
 };
 
@@ -99,10 +99,10 @@ typedef ::std::vector< GalleryThemeEntry* > GalleryThemeList;
 
 struct GalleryImportThemeEntry
 {
-    String          aThemeName;
-    String          aUIName;
-    INetURLObject   aURL;
-    String          aImportName;
+    rtl::OUString aThemeName;
+    rtl::OUString aUIName;
+    INetURLObject aURL;
+    rtl::OUString aImportName;
 };
 
 typedef ::std::vector< GalleryImportThemeEntry* > GalleryImportThemeList;
@@ -144,9 +144,9 @@ private:
     void                        ImplLoadImports();
     void                        ImplWriteImportList();
 
-    SVX_DLLPUBLIC GalleryThemeEntry*            ImplGetThemeEntry( const String& rThemeName );
+    SVX_DLLPUBLIC GalleryThemeEntry*            ImplGetThemeEntry( const rtl::OUString& rThemeName );
     GalleryThemeEntry*          ImplGetThemeEntry( sal_uIntPtr nThemeId );
-    GalleryImportThemeEntry*    ImplGetImportThemeEntry( const String& rImportName );
+    GalleryImportThemeEntry*    ImplGetImportThemeEntry( const rtl::OUString& rImportName );
 
     GalleryTheme*               ImplGetCachedTheme( const GalleryThemeEntry* pThemeEntry );
     void                        ImplDeleteCachedTheme( GalleryTheme* pTheme );
@@ -164,7 +164,7 @@ public:
     const GalleryThemeEntry*    GetThemeInfo( const String& rThemeName ) { return ImplGetThemeEntry( rThemeName ); }
 
     SVX_DLLPUBLIC sal_Bool          HasTheme( const String& rThemeName );
-    String                      GetThemeName( sal_uIntPtr nThemeId ) const;
+    rtl::OUString                   GetThemeName( sal_uIntPtr nThemeId ) const;
 
     SVX_DLLPUBLIC sal_Bool          CreateTheme( const String& rThemeName, sal_uInt32 nNumFrom = 0 );
     sal_Bool                        RenameTheme( const String& rOldName, const String& rNewName );
diff --git a/svx/inc/svx/galmisc.hxx b/svx/inc/svx/galmisc.hxx
index c7ed89c2f953..7f4563e89f7e 100644
--- a/svx/inc/svx/galmisc.hxx
+++ b/svx/inc/svx/galmisc.hxx
@@ -245,8 +245,8 @@ class GalleryHint : public SfxHint
 private:
 
     sal_uIntPtr         mnType;
-    String          maThemeName;
-    String          maStringData;
+    rtl::OUString       maThemeName;
+    rtl::OUString       maStringData;
     sal_uIntPtr         mnData1;
     sal_uIntPtr         mnData2;
 
@@ -258,11 +258,11 @@ public:
                     GalleryHint( sal_uIntPtr nType, const String& rThemeName, const String& rStringData, sal_uIntPtr nData1 = 0UL, sal_uIntPtr nData2 = 0UL ) :
                         mnType( nType ), maThemeName( rThemeName ), maStringData( rStringData ), mnData1( nData1 ), mnData2( nData2 ) {}
 
-    sal_uIntPtr         GetType() const { return mnType; }
-    const String&   GetThemeName() const { return maThemeName; }
-    const String&   GetStringData() const { return maStringData; }
-    sal_uIntPtr         GetData1() const { return mnData1; }
-    sal_uIntPtr         GetData2() const { return mnData2; }
+    sal_uIntPtr          GetType() const { return mnType; }
+    const rtl::OUString& GetThemeName() const { return maThemeName; }
+    const rtl::OUString& GetStringData() const { return maStringData; }
+    sal_uIntPtr          GetData1() const { return mnData1; }
+    sal_uIntPtr          GetData2() const { return mnData2; }
 };
 
     #endif
diff --git a/svx/inc/svx/galtheme.hxx b/svx/inc/svx/galtheme.hxx
index 2bfdddf8ab4f..766bb449a78f 100644
--- a/svx/inc/svx/galtheme.hxx
+++ b/svx/inc/svx/galtheme.hxx
@@ -70,10 +70,10 @@ class ListBox;
 
 struct GalDragParams
 {
-    Region      aDragRegion;
-    sal_uIntPtr     nDragObjPos;
-    String      aThemeName;
-    String      aFileName;
+    Region  aDragRegion;
+    sal_uIntPtr nDragObjPos;
+    rtl::OUString aThemeName;
+    rtl::OUString aFileName;
     SgaObjKind  eObjKind;
 };
 
@@ -99,7 +99,7 @@ class GalleryTheme : public SfxBroadcaster
 private:
 
     GalleryObjectList           aObjectList;
-    String                      aImportName;
+    rtl::OUString               aImportName;
     String                      m_aDestDir;
     SotStorageRef               aSvDrawStorageRef;
     Gallery*                    pParent;
@@ -147,10 +147,10 @@ public:
     SVX_DLLPUBLIC bool          RemoveObject( size_t nPos );
     bool                        ChangeObjectPos( size_t nOldPos, size_t nNewPos );
 
-    SVX_DLLPUBLIC const String& GetName() const;
-    const String&               GetRealName() const;
-    const String&               GetImportName() const { return aImportName; }
-    void                        SetImportName(const String& rImportName) { aImportName = rImportName; }
+    SVX_DLLPUBLIC const rtl::OUString& GetName() const;
+    const rtl::OUString&        GetRealName() const;
+    const rtl::OUString&        GetImportName() const { return aImportName; }
+    void                        SetImportName(const rtl::OUString& rImportName) { aImportName = rImportName; }
 
     const String&               GetDestDir() const { return m_aDestDir; }
     void                        SetDestDir(const String& rDestDir) { m_aDestDir = rDestDir; }