diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-09-11 15:53:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-09-11 17:24:16 +0200 |
commit | 77fca82aab16619a693d53e970ac717f54105e95 (patch) | |
tree | 785d92d2faba195d0723b1343184636a71afd278 /svx/inc | |
parent | d114a341bc9e891b2e10ff60ddadb0b5f58e6381 (diff) |
clang:optin.performance.Padding in svx,editeng
Excessive padding in 'struct svx::SpellPortion' (18 padding bytes, where
2 is optimal).
Excessive padding in 'class SvxNumRule' (11 padding bytes, where 3 is
optimal).
Excessive padding in 'struct SpellInfo' (10 padding bytes, where 2 is
optimal).
Excessive padding in 'struct ImpEditEngine::LineAreaInfo' (14 padding
bytes, where 6 is optimal).
Excessive padding in 'class ImpChainLinkProperties' (5 padding bytes,
where 1 is optimal).
Excessive padding in 'class TextChainFlow' (20 padding bytes, where 4 is
optimal).
Excessive padding in 'class SdrObjList' (13 padding bytes, where 5 is
optimal).
Excessive padding in 'class SdrLayer' (12 padding bytes, where 4 is
optimal).
Change-Id: I17b1c40bfe553c7635dc6177845dc92956cd0fae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx/inc')
-rw-r--r-- | svx/inc/textchain.hxx | 6 | ||||
-rw-r--r-- | svx/inc/textchaincursor.hxx | 2 | ||||
-rw-r--r-- | svx/inc/textchainflow.hxx | 22 |
3 files changed, 14 insertions, 16 deletions
diff --git a/svx/inc/textchain.hxx b/svx/inc/textchain.hxx index a74b6c9f6768..0607052b188e 100644 --- a/svx/inc/textchain.hxx +++ b/svx/inc/textchain.hxx @@ -33,7 +33,7 @@ class OUString; typedef OUString ChainLinkId; -enum class CursorChainingEvent +enum class CursorChainingEvent : sal_uInt8 { TO_NEXT_LINK, TO_PREV_LINK, @@ -58,10 +58,10 @@ protected: private: // NOTE: Remember to set default value in constructor when adding field - bool aNilChainingEvent; - CursorChainingEvent aCursorEvent; ESelection aPreChainingSel; ESelection aPostChainingSel; + CursorChainingEvent aCursorEvent; + bool aNilChainingEvent; bool aIsPartOfLastParaInNextLink; bool aSwitchingToNextBox; }; diff --git a/svx/inc/textchaincursor.hxx b/svx/inc/textchaincursor.hxx index 8dfb65725a92..84171ab56167 100644 --- a/svx/inc/textchaincursor.hxx +++ b/svx/inc/textchaincursor.hxx @@ -23,7 +23,7 @@ class SdrObjEditView; class SdrTextObj; class KeyEvent; class SdrOutliner; -enum class CursorChainingEvent; +enum class CursorChainingEvent : sal_uInt8; struct ESelection; diff --git a/svx/inc/textchainflow.hxx b/svx/inc/textchainflow.hxx index a46c47a2d59a..d423939b6b89 100644 --- a/svx/inc/textchainflow.hxx +++ b/svx/inc/textchainflow.hxx @@ -51,14 +51,6 @@ public: SdrTextObj* GetLinkTarget() const; protected: - // Cursor related - bool mbPossiblyCursorOut; - ESelection maOverflowPosSel; - ESelection maPostChainingSel; - - std::unique_ptr<OFlowChainedText> mpOverflChText; - std::unique_ptr<UFlowChainedText> mpUnderflChText; - void impCheckForFlowEvents(SdrOutliner*, SdrOutliner*); TextChain* GetTextChain() const; @@ -69,15 +61,21 @@ protected: virtual void impSetFlowOutlinerParams(SdrOutliner*, SdrOutliner*); private: - bool mbOFisUFinduced; - void impUpdateCursorInfo(); +protected: + std::unique_ptr<OFlowChainedText> mpOverflChText; + std::unique_ptr<UFlowChainedText> mpUnderflChText; + // Cursor related + ESelection maOverflowPosSel; + ESelection maPostChainingSel; + bool mbPossiblyCursorOut; + +private: SdrTextObj* mpTargetLink; SdrTextObj* mpNextLink; - TextChain* mpTextChain; - + bool mbOFisUFinduced; bool bUnderflow; bool bOverflow; }; |