diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-11-15 13:21:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-11-19 07:46:25 +0100 |
| commit | 193207c5abf339253e15b59f398da0c1f6f43bee (patch) | |
| tree | af181e0b4335d73b4db5b2ccf180779f7c82de5b /svx/qa/unit | |
| parent | b4b3949da1aad091b9f8d0f301f9f7031d6ce295 (diff) | |
improve loplugin passparamsbyref
I think I managed to disable this when I converted it to
use the shared plugin infrastructure.
So fix that, and then make it much smarter to avoid various
false positives.
Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx/qa/unit')
| -rw-r--r-- | svx/qa/unit/customshapes.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx index 47ab375e6037..d3858706cdf2 100644 --- a/svx/qa/unit/customshapes.cxx +++ b/svx/qa/unit/customshapes.cxx @@ -60,7 +60,8 @@ protected: sal_uInt8 countShapes(); // fX and fY are positions relative to the size of the bitmap of the shape // Thus the position is independent from DPI - Color getColor(uno::Reference<drawing::XShape> xShape, const double& fX, const double& fY); + Color getColor(const uno::Reference<drawing::XShape>& xShape, const double& fX, + const double& fY); }; uno::Reference<drawing::XShape> CustomshapesTest::getShape(sal_uInt8 nShapeIndex) @@ -87,7 +88,7 @@ sal_uInt8 CustomshapesTest::countShapes() return xDrawPage->getCount(); } -Color CustomshapesTest::getColor(uno::Reference<drawing::XShape> xShape, const double& fX, +Color CustomshapesTest::getColor(const uno::Reference<drawing::XShape>& xShape, const double& fX, const double& fY) { GraphicHelper::SaveShapeAsGraphicToPath(mxComponent, xShape, u"image/png"_ustr, |