diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2021-09-17 21:49:21 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2021-09-20 12:10:44 +0200 |
| commit | b22d4785310eac35696df771803dfba0871a50ac (patch) | |
| tree | 56e394a3c38a2e1f17530fbc18dd8e6b3c5d5098 /svx/source/accessibility/ChildrenManagerImpl.cxx | |
| parent | 3e2370260f2b79c43b4f8a86b123861aa95d3ef2 (diff) | |
clean up ambiguous confusing rectangle APIs like IsInside()
Reading 'rectA.IsInside( rectB )' kind of suggests that the code
checks whether 'rectA is inside rectB', but it's actually the other
way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(),
which should make it clear which way the logic goes.
Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'svx/source/accessibility/ChildrenManagerImpl.cxx')
| -rw-r--r-- | svx/source/accessibility/ChildrenManagerImpl.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/svx/source/accessibility/ChildrenManagerImpl.cxx b/svx/source/accessibility/ChildrenManagerImpl.cxx index c4b75024c9fc..4d474a4953fa 100644 --- a/svx/source/accessibility/ChildrenManagerImpl.cxx +++ b/svx/source/accessibility/ChildrenManagerImpl.cxx @@ -315,7 +315,7 @@ void ChildrenManagerImpl::CreateListOfVisibleShapes ( // Insert shape if it is visible, i.e. its bounding box overlaps // the visible area. - if ( aBoundingBox.IsOver (aVisibleArea) ) + if ( aBoundingBox.Overlaps(aVisibleArea) ) raDescriptorList.emplace_back(xShape); } } @@ -439,7 +439,7 @@ void ChildrenManagerImpl::AddShape (const Reference<drawing::XShape>& rxShape) if (xParent != mxShapeList) return; - if (!aBoundingBox.IsOver (aVisibleArea)) + if (!aBoundingBox.Overlaps(aVisibleArea)) return; // Add shape to list of visible shapes. |