diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-10-21 15:53:34 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-10-22 12:42:07 +0200 |
| commit | 4347b5975283ca1a591b6c3d4559ed360e187022 (patch) | |
| tree | d607931cc2143988fe344f32b8f311bcf4f3ef51 /svx/source/customshapes/EnhancedCustomShapeEngine.cxx | |
| parent | b55fda6d9eb83460382c0da74eb5cd3a3d03cd7f (diff) | |
pvs-studio: V728 An excessive check can be simplified
for...
"The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression"
subcases, where the args are already bool
Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af
Reviewed-on: https://gerrit.libreoffice.org/62146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'svx/source/customshapes/EnhancedCustomShapeEngine.cxx')
| -rw-r--r-- | svx/source/customshapes/EnhancedCustomShapeEngine.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/svx/source/customshapes/EnhancedCustomShapeEngine.cxx b/svx/source/customshapes/EnhancedCustomShapeEngine.cxx index aebd702737a1..55b1f7f2fa27 100644 --- a/svx/source/customshapes/EnhancedCustomShapeEngine.cxx +++ b/svx/source/customshapes/EnhancedCustomShapeEngine.cxx @@ -328,7 +328,7 @@ Reference< drawing::XShape > SAL_CALL EnhancedCustomShapeEngine::render() { long nShearAngle = rGeoStat.nShearAngle; double nTan = rGeoStat.nTan; - if ((bFlipV&&!bFlipH )||(bFlipH&&!bFlipV)) + if (bFlipV != bFlipH) { nShearAngle = -nShearAngle; nTan = -nTan; @@ -429,7 +429,7 @@ drawing::PolyPolygonBezierCoords SAL_CALL EnhancedCustomShapeEngine::getLineGeom { long nShearAngle = rGeoStat.nShearAngle; double nTan = rGeoStat.nTan; - if ((bFlipV&&!bFlipH )||(bFlipH&&!bFlipV)) + if (bFlipV != bFlipH) { nShearAngle = -nShearAngle; nTan = -nTan; |