Avoid conversions between OUString and OString in VCL

Standardize on OUString, which is the main internal string class.
Convert from/to OUString only when communicating with respective
external APIs.

Removes about 200 conversions from the code.

Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/svx/source/dialog/charmap.cxx b/svx/source/dialog/charmap.cxx
index 7b74eab65aa3..bb15cb1efc1f 100644
--- a/svx/source/dialog/charmap.cxx
+++ b/svx/source/dialog/charmap.cxx
@@ -238,19 +238,19 @@ void SvxShowCharSet::createContextMenu()
     Invalidate();
 }
 
-void SvxShowCharSet::ContextMenuSelect(std::string_view rIdent)
+void SvxShowCharSet::ContextMenuSelect(std::u16string_view rIdent)
 {
     sal_UCS4 cChar = GetSelectCharacter();
     OUString aOUStr(&cChar, 1);
 
-    if (rIdent == "insert")
+    if (rIdent == u"insert")
         aDoubleClkHdl.Call(this);
-    else if (rIdent == "add" || rIdent == "remove")
+    else if (rIdent == u"add" || rIdent == u"remove")
     {
         updateFavCharacterList(aOUStr, mxVirDev->GetFont().GetFamilyName());
         aFavClickHdl.Call(this);
     }
-    else if (rIdent == "copy")
+    else if (rIdent == u"copy")
         CopyToClipboard(aOUStr);
 }