diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-26 14:11:32 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-27 08:03:26 +0200 |
commit | 8ce64dbb3d7875c00963ae257d53f2b7b58fc4ad (patch) | |
tree | 070a1a2f11d553511c24423290829713c1f2fba6 /svx/source/dialog | |
parent | 781a30e938c58c4d91d08f8c6f9e3f8745682d72 (diff) |
loplugin:constparams in svx
and fix a bug in the plugin itself when calling operator's like the one
on std::function<>
Change-Id: I1617607107eeff06785c1841f69e13ad2926218e
Reviewed-on: https://gerrit.libreoffice.org/40446
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx/source/dialog')
-rw-r--r-- | svx/source/dialog/dlgctrl.cxx | 2 | ||||
-rw-r--r-- | svx/source/dialog/fntctrl.cxx | 10 | ||||
-rw-r--r-- | svx/source/dialog/grfflt.cxx | 2 | ||||
-rw-r--r-- | svx/source/dialog/langbox.cxx | 2 | ||||
-rw-r--r-- | svx/source/dialog/optgrid.cxx | 2 | ||||
-rw-r--r-- | svx/source/dialog/srchdlg.cxx | 8 | ||||
-rw-r--r-- | svx/source/dialog/svxbmpnumvalueset.cxx | 6 |
7 files changed, 16 insertions, 16 deletions
diff --git a/svx/source/dialog/dlgctrl.cxx b/svx/source/dialog/dlgctrl.cxx index 74fe85448178..8786336dfb01 100644 --- a/svx/source/dialog/dlgctrl.cxx +++ b/svx/source/dialog/dlgctrl.cxx @@ -1498,7 +1498,7 @@ void SvxPreviewBase::dispose() Control::dispose(); } -void SvxPreviewBase::LocalPrePaint(vcl::RenderContext& rRenderContext) +void SvxPreviewBase::LocalPrePaint(vcl::RenderContext const & rRenderContext) { // init BufferDevice if (mpBufferDevice->GetOutputSizePixel() != GetOutputSizePixel()) diff --git a/svx/source/dialog/fntctrl.cxx b/svx/source/dialog/fntctrl.cxx index bd5ff70a24ff..e5d9225450c8 100644 --- a/svx/source/dialog/fntctrl.cxx +++ b/svx/source/dialog/fntctrl.cxx @@ -84,7 +84,7 @@ using ::com::sun::star::i18n::BreakIterator; namespace { -void scaleFontWidth(vcl::Font& rFont, vcl::RenderContext& rRenderContext,long& n100PercentFont) +void scaleFontWidth(vcl::Font& rFont, vcl::RenderContext const & rRenderContext,long& n100PercentFont) { rFont.SetAverageFontWidth(0); n100PercentFont = rRenderContext.GetFontMetric(rFont).GetAverageFontWidth(); @@ -195,13 +195,13 @@ public: } void CheckScript(); - Size CalcTextSize(vcl::RenderContext& rRenderContext, OutputDevice* pPrinter, const SvxFont& rFont); + Size CalcTextSize(vcl::RenderContext& rRenderContext, OutputDevice const * pPrinter, const SvxFont& rFont); void DrawPrev(vcl::RenderContext& rRenderContext, Printer* pPrinter, Point& rPt, const SvxFont& rFont); bool SetFontWidthScale(sal_uInt16 nScaleInPercent); inline void Invalidate100PercentFontWidth(); inline bool Is100PercentFontWidthValid() const; - void ScaleFontWidth(vcl::RenderContext& rRenderContext); + void ScaleFontWidth(vcl::RenderContext const & rRenderContext); // scales rNonCJKFont and aCJKFont depending on nFontWidthScale and // sets the 100%-Font-Widths }; @@ -288,7 +288,7 @@ void FontPrevWin_Impl::CheckScript() * The member nAscent is calculated to the maximal ascent of all used fonts. */ -Size FontPrevWin_Impl::CalcTextSize(vcl::RenderContext& rRenderContext, OutputDevice* _pPrinter, const SvxFont& rInFont) +Size FontPrevWin_Impl::CalcTextSize(vcl::RenderContext& rRenderContext, OutputDevice const * _pPrinter, const SvxFont& rInFont) { sal_uInt16 nScript; sal_uInt16 nIdx = 0; @@ -435,7 +435,7 @@ bool FontPrevWin_Impl::SetFontWidthScale(sal_uInt16 nScale) return false; } -void FontPrevWin_Impl::ScaleFontWidth(vcl::RenderContext& rOutDev) +void FontPrevWin_Impl::ScaleFontWidth(vcl::RenderContext const & rOutDev) { if (!Is100PercentFontWidthValid()) { diff --git a/svx/source/dialog/grfflt.cxx b/svx/source/dialog/grfflt.cxx index 0ca19dfe68f3..0f9d7cbd1f0c 100644 --- a/svx/source/dialog/grfflt.cxx +++ b/svx/source/dialog/grfflt.cxx @@ -31,7 +31,7 @@ #include <memory> -sal_uIntPtr SvxGraphicFilter::ExecuteGrfFilterSlot( SfxRequest& rReq, GraphicObject& rFilterObject ) +sal_uIntPtr SvxGraphicFilter::ExecuteGrfFilterSlot( SfxRequest const & rReq, GraphicObject& rFilterObject ) { const Graphic& rGraphic = rFilterObject.GetGraphic(); sal_uIntPtr nRet = SVX_GRAPHICFILTER_UNSUPPORTED_GRAPHICTYPE; diff --git a/svx/source/dialog/langbox.cxx b/svx/source/dialog/langbox.cxx index 38b3ed4332d1..aaa28edeccca 100644 --- a/svx/source/dialog/langbox.cxx +++ b/svx/source/dialog/langbox.cxx @@ -71,7 +71,7 @@ OUString GetDicInfoStr( const OUString& rName, const LanguageType nLang, bool bN // misc local helper functions -static std::vector< LanguageType > lcl_LocaleSeqToLangSeq( Sequence< css::lang::Locale > &rSeq ) +static std::vector< LanguageType > lcl_LocaleSeqToLangSeq( Sequence< css::lang::Locale > const &rSeq ) { const css::lang::Locale *pLocale = rSeq.getConstArray(); sal_Int32 nCount = rSeq.getLength(); diff --git a/svx/source/dialog/optgrid.cxx b/svx/source/dialog/optgrid.cxx index 15897fbc3526..53521b4178bc 100644 --- a/svx/source/dialog/optgrid.cxx +++ b/svx/source/dialog/optgrid.cxx @@ -28,7 +28,7 @@ #include "svx/dlgutil.hxx" // local functions -static void lcl_GetMinMax(MetricField& rField, long& nFirst, long& nLast, long& nMin, long& nMax) +static void lcl_GetMinMax(MetricField const & rField, long& nFirst, long& nLast, long& nMin, long& nMax) { nFirst = static_cast<long>(rField.Denormalize( rField.GetFirst( FUNIT_TWIP ) )); nLast = static_cast<long>(rField.Denormalize( rField.GetLast( FUNIT_TWIP ) )); diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx index fab2f3f9d459..ae8c1223b929 100644 --- a/svx/source/dialog/srchdlg.cxx +++ b/svx/source/dialog/srchdlg.cxx @@ -677,7 +677,7 @@ void SvxSearchDialog::InitControls_Impl() namespace { - SvtModuleOptions::EFactory getModule(SfxBindings& rBindings) + SvtModuleOptions::EFactory getModule(SfxBindings const & rBindings) { SvtModuleOptions::EFactory eFactory(SvtModuleOptions::EFactory::UNKNOWN_FACTORY); try @@ -1128,10 +1128,10 @@ IMPL_LINK( SvxSearchDialog, FlagHdl_Impl, Button *, pCtrl, void ) ClickHdl_Impl(pCtrl); } -void SvxSearchDialog::ClickHdl_Impl(void* pCtrl) +void SvxSearchDialog::ClickHdl_Impl(void const * pCtrl) { if ( pCtrl && !bSet ) - SetModifyFlag_Impl( static_cast<Control*>(pCtrl) ); + SetModifyFlag_Impl( static_cast<Control const *>(pCtrl) ); else bSet = false; @@ -1780,7 +1780,7 @@ void SvxSearchDialog::EnableControls_Impl( const SearchOptionFlags nFlags ) } -void SvxSearchDialog::EnableControl_Impl( Control* pCtrl ) +void SvxSearchDialog::EnableControl_Impl( Control const * pCtrl ) { if (m_pSearchBtn == pCtrl && ( SearchOptionFlags::SEARCH & nOptions ) ) { diff --git a/svx/source/dialog/svxbmpnumvalueset.cxx b/svx/source/dialog/svxbmpnumvalueset.cxx index 7d73630c2925..61dddbfcde3b 100644 --- a/svx/source/dialog/svxbmpnumvalueset.cxx +++ b/svx/source/dialog/svxbmpnumvalueset.cxx @@ -452,7 +452,7 @@ void SvxNumValueSet::dispose() void SvxNumValueSet::SetNumberingSettings( const Sequence<Sequence<PropertyValue> >& aNum, - Reference<XNumberingFormatter>& xFormat, + Reference<XNumberingFormatter> const & xFormat, const Locale& rLocale ) { aNumSettings = aNum; @@ -469,8 +469,8 @@ void SvxNumValueSet::SetNumberingSettings( } void SvxNumValueSet::SetOutlineNumberingSettings( - Sequence<Reference<XIndexAccess> >& rOutline, - Reference<XNumberingFormatter>& xFormat, + Sequence<Reference<XIndexAccess> > const & rOutline, + Reference<XNumberingFormatter> const & xFormat, const Locale& rLocale) { aOutlineSettings = rOutline; |