diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-16 13:53:00 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-16 13:53:39 +0200 |
| commit | cd9d8315141c3070f43e145ed4ee390e837eb73f (patch) | |
| tree | e037bf798889fd02524e62abedb0c2a880e4672e /svx/source/gallery2/galbrws1.hxx | |
| parent | 26b0e86405b27a0342a5b42f82a944559f3a1358 (diff) | |
tdf#105017 Crash when click a "New Theme..." in Gallery on detached SideBar
caused by VclPtr fixes which meant instead of the dialog staying in an
always-zero ref-count state, it went up to a ref-count of 1, then down
to zero, which triggered a delete before the dialog had finished
displaying.
And revert my fix in commit 0c1cd678f71e519f5a4e623d93442e046485005a
which just worked around the underlying problem
Change-Id: Icb35535dd06a2d1db1016d00d106760847d87430
Diffstat (limited to 'svx/source/gallery2/galbrws1.hxx')
| -rw-r--r-- | svx/source/gallery2/galbrws1.hxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/svx/source/gallery2/galbrws1.hxx b/svx/source/gallery2/galbrws1.hxx index 896fca11a683..294623ce6e9c 100644 --- a/svx/source/gallery2/galbrws1.hxx +++ b/svx/source/gallery2/galbrws1.hxx @@ -76,8 +76,9 @@ class GalleryBrowser1 : public Control, public SfxListener private: - VclPtr<GalleryButton> maNewTheme; + VclPtr<GalleryButton> maNewTheme; VclPtr<GalleryThemeListBox> mpThemes; + VclPtr<VclAbstractDialog2> mpThemePropertiesDialog; // to keep it alive during execution Gallery* mpGallery; ExchangeData* mpExchangeData; SfxItemSet* mpThemePropsDlgItemSet; |