loplugin:stringliteraldefine in svx

Change-Id: I2375ebfe9791c43063ffbc8ddbe1bd365499a576
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125868
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 114 insertions, 112 deletions

diff --git a/svx/source/inc/fmprop.hxx b/svx/source/inc/fmprop.hxx
index 0ea06e09f826..a6125f2ffe2b 100644
--- a/svx/source/inc/fmprop.hxx
+++ b/svx/source/inc/fmprop.hxx
@@ -19,6 +19,8 @@
 #ifndef INCLUDED_SVX_SOURCE_INC_FMPROP_HXX
 #define INCLUDED_SVX_SOURCE_INC_FMPROP_HXX
 
+#include <rtl/ustring.hxx>
+
 // PropertyIds, which have an assignment to a PropertyName, could continue
 // to be WhichIds in the future -> Itemset
 #define FM_ATTR_START           0
@@ -26,125 +28,125 @@
 #define FM_ATTR_FILTER          ( FM_ATTR_START + 1 )
 #define FM_ATTR_FORM_OPERATIONS ( FM_ATTR_START + 2 )
 
-#define FM_PROP_NAME                         "Name"
-#define FM_PROP_CLASSID                      "ClassId"
-#define FM_PROP_ALIGN                        "Align"
-#define FM_PROP_ROWCOUNT                     "RowCount"
-#define FM_PROP_ROWCOUNTFINAL                "IsRowCountFinal"
-#define FM_PROP_FETCHSIZE                    "FetchSize"
-#define FM_PROP_VALUE                        "Value"
-#define FM_PROP_VALUEMIN                     "ValueMin"
-#define FM_PROP_VALUEMAX                     "ValueMax"
-#define FM_PROP_VALUESTEP                    "ValueStep"
-#define FM_PROP_TEXT                         "Text"
-#define FM_PROP_LABEL                        "Label"
-#define FM_PROP_NAVIGATION                   "NavigationBarMode"
-#define FM_PROP_CYCLE                        "Cycle"
-#define FM_PROP_CONTROLSOURCE                "DataField"
-#define FM_PROP_ENABLED                      "Enabled"
-#define FM_PROP_SPIN                         "Spin"
-#define FM_PROP_READONLY                     "ReadOnly"
-#define FM_PROP_FILTER                       "Filter"
-#define FM_PROP_AUTOINCREMENT                "IsAutoIncrement"
-#define FM_PROP_WIDTH                        "Width"
-#define FM_PROP_SEARCHABLE                   "IsSearchable"
-#define FM_PROP_MULTILINE                    "MultiLine"
-#define FM_PROP_TARGET_URL                   "TargetURL"
-#define FM_PROP_DEFAULTCONTROL               "DefaultControl"
-#define FM_PROP_MAXTEXTLEN                   "MaxTextLen"
-#define FM_PROP_DATE                         "Date"
-#define FM_PROP_TIME                         "Time"
-#define FM_PROP_STATE                        "State"
-#define FM_PROP_TRISTATE                     "TriState"
-#define FM_PROP_STRINGITEMLIST               "StringItemList"
-#define FM_PROP_DEFAULT_TEXT                 "DefaultText"
-#define FM_PROP_DEFAULTCHECKED               "DefaultState"
-#define FM_PROP_DEFAULT_DATE                 "DefaultDate"
-#define FM_PROP_DEFAULT_TIME                 "DefaultTime"
-#define FM_PROP_DEFAULT_VALUE                "DefaultValue"
-#define FM_PROP_FORMATKEY                    "FormatKey"
-#define FM_PROP_FORMATSSUPPLIER              "FormatsSupplier"
-#define FM_PROP_LISTSOURCETYPE               "ListSourceType"
-#define FM_PROP_LISTSOURCE                   "ListSource"
-#define FM_PROP_SELECT_SEQ                   "SelectedItems"
-#define FM_PROP_VALUE_SEQ                    "ValueItemList"
-#define FM_PROP_DEFAULT_SELECT_SEQ           "DefaultSelection"
-#define FM_PROP_DECIMAL_ACCURACY             "DecimalAccuracy"
-#define FM_PROP_EDITMASK                     "EditMask"
-#define FM_PROP_ISREADONLY                   "IsReadOnly"
-#define FM_PROP_FIELDTYPE                    "Type"
-#define FM_PROP_REFVALUE                     "RefValue"
-#define FM_PROP_STRICTFORMAT                 "StrictFormat"
-#define FM_PROP_DATASOURCE                   "DataSourceName"
-#define FM_PROP_LITERALMASK                  "LiteralMask"
-#define FM_PROP_SHOWTHOUSANDSEP              "ShowThousandsSeparator"
-#define FM_PROP_CURRENCYSYMBOL               "CurrencySymbol"
-#define FM_PROP_DATEFORMAT                   "DateFormat"
-#define FM_PROP_DATEMIN                      "DateMin"
-#define FM_PROP_DATEMAX                      "DateMax"
-#define FM_PROP_DATE_SHOW_CENTURY            "DateShowCentury"
-#define FM_PROP_TIMEFORMAT                   "TimeFormat"
-#define FM_PROP_TIMEMIN                      "TimeMin"
-#define FM_PROP_TIMEMAX                      "TimeMax"
-#define FM_PROP_LINECOUNT                    "LineCount"
-#define FM_PROP_BOUNDCOLUMN                  "BoundColumn"
+inline constexpr OUStringLiteral FM_PROP_NAME = u"Name";
+inline constexpr OUStringLiteral FM_PROP_CLASSID = u"ClassId";
+inline constexpr OUStringLiteral FM_PROP_ALIGN = u"Align";
+inline constexpr OUStringLiteral FM_PROP_ROWCOUNT = u"RowCount";
+inline constexpr OUStringLiteral FM_PROP_ROWCOUNTFINAL = u"IsRowCountFinal";
+inline constexpr OUStringLiteral FM_PROP_FETCHSIZE = u"FetchSize";
+inline constexpr OUStringLiteral FM_PROP_VALUE = u"Value";
+inline constexpr OUStringLiteral FM_PROP_VALUEMIN = u"ValueMin";
+inline constexpr OUStringLiteral FM_PROP_VALUEMAX = u"ValueMax";
+inline constexpr OUStringLiteral FM_PROP_VALUESTEP = u"ValueStep";
+inline constexpr OUStringLiteral FM_PROP_TEXT = u"Text";
+inline constexpr OUStringLiteral FM_PROP_LABEL = u"Label";
+inline constexpr OUStringLiteral FM_PROP_NAVIGATION = u"NavigationBarMode";
+inline constexpr OUStringLiteral FM_PROP_CYCLE = u"Cycle";
+inline constexpr OUStringLiteral FM_PROP_CONTROLSOURCE = u"DataField";
+inline constexpr OUStringLiteral FM_PROP_ENABLED = u"Enabled";
+inline constexpr OUStringLiteral FM_PROP_SPIN = u"Spin";
+inline constexpr OUStringLiteral FM_PROP_READONLY = u"ReadOnly";
+inline constexpr OUStringLiteral FM_PROP_FILTER = u"Filter";
+inline constexpr OUStringLiteral FM_PROP_AUTOINCREMENT = u"IsAutoIncrement";
+inline constexpr OUStringLiteral FM_PROP_WIDTH = u"Width";
+inline constexpr OUStringLiteral FM_PROP_SEARCHABLE = u"IsSearchable";
+inline constexpr OUStringLiteral FM_PROP_MULTILINE = u"MultiLine";
+inline constexpr OUStringLiteral FM_PROP_TARGET_URL = u"TargetURL";
+inline constexpr OUStringLiteral FM_PROP_DEFAULTCONTROL = u"DefaultControl";
+inline constexpr OUStringLiteral FM_PROP_MAXTEXTLEN = u"MaxTextLen";
+inline constexpr OUStringLiteral FM_PROP_DATE = u"Date";
+inline constexpr OUStringLiteral FM_PROP_TIME = u"Time";
+inline constexpr OUStringLiteral FM_PROP_STATE = u"State";
+inline constexpr OUStringLiteral FM_PROP_TRISTATE = u"TriState";
+inline constexpr OUStringLiteral FM_PROP_STRINGITEMLIST = u"StringItemList";
+inline constexpr OUStringLiteral FM_PROP_DEFAULT_TEXT = u"DefaultText";
+inline constexpr OUStringLiteral FM_PROP_DEFAULTCHECKED = u"DefaultState";
+inline constexpr OUStringLiteral FM_PROP_DEFAULT_DATE = u"DefaultDate";
+inline constexpr OUStringLiteral FM_PROP_DEFAULT_TIME = u"DefaultTime";
+inline constexpr OUStringLiteral FM_PROP_DEFAULT_VALUE = u"DefaultValue";
+inline constexpr OUStringLiteral FM_PROP_FORMATKEY = u"FormatKey";
+inline constexpr OUStringLiteral FM_PROP_FORMATSSUPPLIER = u"FormatsSupplier";
+inline constexpr OUStringLiteral FM_PROP_LISTSOURCETYPE = u"ListSourceType";
+inline constexpr OUStringLiteral FM_PROP_LISTSOURCE = u"ListSource";
+inline constexpr OUStringLiteral FM_PROP_SELECT_SEQ = u"SelectedItems";
+inline constexpr OUStringLiteral FM_PROP_VALUE_SEQ = u"ValueItemList";
+inline constexpr OUStringLiteral FM_PROP_DEFAULT_SELECT_SEQ = u"DefaultSelection";
+inline constexpr OUStringLiteral FM_PROP_DECIMAL_ACCURACY = u"DecimalAccuracy";
+inline constexpr OUStringLiteral FM_PROP_EDITMASK = u"EditMask";
+inline constexpr OUStringLiteral FM_PROP_ISREADONLY = u"IsReadOnly";
+inline constexpr OUStringLiteral FM_PROP_FIELDTYPE = u"Type";
+inline constexpr OUStringLiteral FM_PROP_REFVALUE = u"RefValue";
+inline constexpr OUStringLiteral FM_PROP_STRICTFORMAT = u"StrictFormat";
+inline constexpr OUStringLiteral FM_PROP_DATASOURCE = u"DataSourceName";
+inline constexpr OUStringLiteral FM_PROP_LITERALMASK = u"LiteralMask";
+inline constexpr OUStringLiteral FM_PROP_SHOWTHOUSANDSEP = u"ShowThousandsSeparator";
+inline constexpr OUStringLiteral FM_PROP_CURRENCYSYMBOL = u"CurrencySymbol";
+inline constexpr OUStringLiteral FM_PROP_DATEFORMAT = u"DateFormat";
+inline constexpr OUStringLiteral FM_PROP_DATEMIN = u"DateMin";
+inline constexpr OUStringLiteral FM_PROP_DATEMAX = u"DateMax";
+inline constexpr OUStringLiteral FM_PROP_DATE_SHOW_CENTURY = u"DateShowCentury";
+inline constexpr OUStringLiteral FM_PROP_TIMEFORMAT = u"TimeFormat";
+inline constexpr OUStringLiteral FM_PROP_TIMEMIN = u"TimeMin";
+inline constexpr OUStringLiteral FM_PROP_TIMEMAX = u"TimeMax";
+inline constexpr OUStringLiteral FM_PROP_LINECOUNT = u"LineCount";
+inline constexpr OUStringLiteral FM_PROP_BOUNDCOLUMN = u"BoundColumn";
 #define FM_PROP_HASNAVIGATION                "HasNavigationBar"
-#define FM_PROP_FONT                         "FontDescriptor"
+inline constexpr OUStringLiteral FM_PROP_FONT = u"FontDescriptor";
 #define FM_PROP_BACKGROUNDCOLOR              "BackgroundColor"
 #define FM_PROP_TEXTCOLOR                    "TextColor"
-#define FM_PROP_BORDER                       "Border"
-#define FM_PROP_DROPDOWN                     "Dropdown"
-#define FM_PROP_ROWHEIGHT                    "RowHeight"
-#define FM_PROP_HELPTEXT                     "HelpText"
+inline constexpr OUStringLiteral FM_PROP_BORDER = u"Border";
+inline constexpr OUStringLiteral FM_PROP_DROPDOWN = u"Dropdown";
+inline constexpr OUStringLiteral FM_PROP_ROWHEIGHT = u"RowHeight";
+inline constexpr OUStringLiteral FM_PROP_HELPTEXT = u"HelpText";
 #define FM_PROP_HELPURL                      "HelpURL"
 #define FM_PROP_RECORDMARKER                 "HasRecordMarker"
-#define FM_PROP_BOUNDFIELD                   "BoundField"
-#define FM_PROP_EFFECTIVE_VALUE              "EffectiveValue"
-#define FM_PROP_EFFECTIVE_DEFAULT            "EffectiveDefault"
-#define FM_PROP_EFFECTIVE_MIN                "EffectiveMin"
-#define FM_PROP_EFFECTIVE_MAX                "EffectiveMax"
-#define FM_PROP_HIDDEN                       "Hidden"
-#define FM_PROP_FILTERPROPOSAL               "UseFilterValueProposal"
-#define FM_PROP_FIELDSOURCE                  "FieldSource"
-#define FM_PROP_TABLENAME                    "TableName"
-#define FM_PROP_CONTROLLABEL                 "LabelControl"
-#define FM_PROP_CURSORCOLOR                  "CursorColor"
-#define FM_PROP_ALWAYSSHOWCURSOR             "AlwaysShowCursor"
-#define FM_PROP_DISPLAYSYNCHRON              "DisplayIsSynchron"
-#define FM_PROP_ISMODIFIED                   "IsModified"
-#define FM_PROP_ISNEW                        "IsNew"
-#define FM_PROP_PRIVILEGES                   "Privileges"
-#define FM_PROP_COMMAND                      "Command"
-#define FM_PROP_COMMANDTYPE                  "CommandType"
-#define FM_PROP_RESULTSET_CONCURRENCY        "ResultSetConcurrency"
-#define FM_PROP_INSERTONLY                   "IgnoreResult"
-#define FM_PROP_RESULTSET_TYPE               "ResultSetType"
-#define FM_PROP_ESCAPE_PROCESSING            "EscapeProcessing"
-#define FM_PROP_APPLYFILTER                  "ApplyFilter"
-#define FM_PROP_ISNULLABLE                   "IsNullable"
-#define FM_PROP_ACTIVECOMMAND                "ActiveCommand"
-#define FM_PROP_ISCURRENCY                   "IsCurrency"
-#define FM_PROP_URL                          "URL"
-#define FM_PROP_ACTIVE_CONNECTION            "ActiveConnection"
-#define FM_PROP_CONTROLSOURCEPROPERTY        "DataFieldProperty"
-#define FM_PROP_REALNAME                     "RealName"
-#define FM_PROP_TEXTLINECOLOR                "TextLineColor"
+inline constexpr OUStringLiteral FM_PROP_BOUNDFIELD = u"BoundField";
+inline constexpr OUStringLiteral FM_PROP_EFFECTIVE_VALUE = u"EffectiveValue";
+inline constexpr OUStringLiteral FM_PROP_EFFECTIVE_DEFAULT = u"EffectiveDefault";
+inline constexpr OUStringLiteral FM_PROP_EFFECTIVE_MIN = u"EffectiveMin";
+inline constexpr OUStringLiteral FM_PROP_EFFECTIVE_MAX = u"EffectiveMax";
+inline constexpr OUStringLiteral FM_PROP_HIDDEN = u"Hidden";
+inline constexpr OUStringLiteral FM_PROP_FILTERPROPOSAL = u"UseFilterValueProposal";
+inline constexpr OUStringLiteral FM_PROP_FIELDSOURCE = u"FieldSource";
+inline constexpr OUStringLiteral FM_PROP_TABLENAME = u"TableName";
+inline constexpr OUStringLiteral FM_PROP_CONTROLLABEL = u"LabelControl";
+inline constexpr OUStringLiteral FM_PROP_CURSORCOLOR = u"CursorColor";
+inline constexpr OUStringLiteral FM_PROP_ALWAYSSHOWCURSOR = u"AlwaysShowCursor";
+inline constexpr OUStringLiteral FM_PROP_DISPLAYSYNCHRON = u"DisplayIsSynchron";
+inline constexpr OUStringLiteral FM_PROP_ISMODIFIED = u"IsModified";
+inline constexpr OUStringLiteral FM_PROP_ISNEW = u"IsNew";
+inline constexpr OUStringLiteral FM_PROP_PRIVILEGES = u"Privileges";
+inline constexpr OUStringLiteral FM_PROP_COMMAND = u"Command";
+inline constexpr OUStringLiteral FM_PROP_COMMANDTYPE = u"CommandType";
+inline constexpr OUStringLiteral FM_PROP_RESULTSET_CONCURRENCY = u"ResultSetConcurrency";
+inline constexpr OUStringLiteral FM_PROP_INSERTONLY = u"IgnoreResult";
+inline constexpr OUStringLiteral FM_PROP_RESULTSET_TYPE = u"ResultSetType";
+inline constexpr OUStringLiteral FM_PROP_ESCAPE_PROCESSING = u"EscapeProcessing";
+inline constexpr OUStringLiteral FM_PROP_APPLYFILTER = u"ApplyFilter";
+inline constexpr OUStringLiteral FM_PROP_ISNULLABLE = u"IsNullable";
+inline constexpr OUStringLiteral FM_PROP_ACTIVECOMMAND = u"ActiveCommand";
+inline constexpr OUStringLiteral FM_PROP_ISCURRENCY = u"IsCurrency";
+inline constexpr OUStringLiteral FM_PROP_URL = u"URL";
+inline constexpr OUStringLiteral FM_PROP_ACTIVE_CONNECTION = u"ActiveConnection";
+inline constexpr OUStringLiteral FM_PROP_CONTROLSOURCEPROPERTY = u"DataFieldProperty";
+inline constexpr OUStringLiteral FM_PROP_REALNAME = u"RealName";
+inline constexpr OUStringLiteral FM_PROP_TEXTLINECOLOR = u"TextLineColor";
 #define FM_PROP_FONTEMPHASISMARK             "FontEmphasisMark"
 #define FM_PROP_FONTRELIEF                   "FontRelief"
-#define FM_PROP_ORIENTATION                  "Orientation"
-#define FM_PROP_LINEENDFORMAT                "LineEndFormat"
-#define FM_PROP_VISUALEFFECT                 "VisualEffect"
-#define FM_PROP_BORDERCOLOR                  "BorderColor"
-#define FM_PROP_DYNAMIC_CONTROL_BORDER       "DynamicControlBorder"
-#define FM_PROP_CONTROL_BORDER_COLOR_FOCUS   "ControlBorderColorOnFocus"
-#define FM_PROP_CONTROL_BORDER_COLOR_MOUSE   "ControlBorderColorOnHover"
-#define FM_PROP_CONTROL_BORDER_COLOR_INVALID "ControlBorderColorOnInvalid"
-#define FM_PROP_BUTTON_TYPE                  "ButtonType"
-#define FM_PROP_FORM_OPERATIONS              "FormOperations"
-#define FM_PROP_INPUT_REQUIRED               "InputRequired"
-#define FM_PROP_WRITING_MODE                 "WritingMode"
-#define FM_PROP_MOUSE_WHEEL_BEHAVIOR         "MouseWheelBehavior"
-#define FM_PROP_DESCRIPTION                  "Description"
+inline constexpr OUStringLiteral FM_PROP_ORIENTATION = u"Orientation";
+inline constexpr OUStringLiteral FM_PROP_LINEENDFORMAT = u"LineEndFormat";
+inline constexpr OUStringLiteral FM_PROP_VISUALEFFECT = u"VisualEffect";
+inline constexpr OUStringLiteral FM_PROP_BORDERCOLOR = u"BorderColor";
+inline constexpr OUStringLiteral FM_PROP_DYNAMIC_CONTROL_BORDER = u"DynamicControlBorder";
+inline constexpr OUStringLiteral FM_PROP_CONTROL_BORDER_COLOR_FOCUS = u"ControlBorderColorOnFocus";
+inline constexpr OUStringLiteral FM_PROP_CONTROL_BORDER_COLOR_MOUSE = u"ControlBorderColorOnHover";
+inline constexpr OUStringLiteral FM_PROP_CONTROL_BORDER_COLOR_INVALID = u"ControlBorderColorOnInvalid";
+inline constexpr OUStringLiteral FM_PROP_BUTTON_TYPE = u"ButtonType";
+inline constexpr OUStringLiteral FM_PROP_FORM_OPERATIONS = u"FormOperations";
+inline constexpr OUStringLiteral FM_PROP_INPUT_REQUIRED = u"InputRequired";
+inline constexpr OUStringLiteral FM_PROP_WRITING_MODE = u"WritingMode";
+inline constexpr OUStringLiteral FM_PROP_MOUSE_WHEEL_BEHAVIOR = u"MouseWheelBehavior";
+inline constexpr OUStringLiteral FM_PROP_DESCRIPTION = u"Description";
 
 #endif