Enable -Wnon-virtual-dtor for GCC 4.6

...which has the necessary features to support it.

Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.

cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.

Includes a patch for libcmis, intended to be upstreamed.

5 files changed, 20 insertions, 2 deletions

diff --git a/svx/source/inc/docrecovery.hxx b/svx/source/inc/docrecovery.hxx
index 040eed75c359..ec4b9dff5940 100644
--- a/svx/source/inc/docrecovery.hxx
+++ b/svx/source/inc/docrecovery.hxx
@@ -209,6 +209,9 @@ class IRecoveryUpdateListener
 
         // TODO
         virtual void stepNext(TURLInfo* pItem) = 0;
+
+    protected:
+        ~IRecoveryUpdateListener() {}
 };
 
 //===============================================
diff --git a/svx/source/inc/fmslotinvalidator.hxx b/svx/source/inc/fmslotinvalidator.hxx
index b92201939953..2b8a1baf8df6 100644
--- a/svx/source/inc/fmslotinvalidator.hxx
+++ b/svx/source/inc/fmslotinvalidator.hxx
@@ -45,6 +45,9 @@ namespace svx
     {
     public:
         virtual void    Invalidate( SfxSlotId _nSlot ) = 0;
+
+    protected:
+        ~ISlotInvalidator() {}
     };
 
 //........................................................................
diff --git a/svx/source/inc/fmtextcontrolshell.hxx b/svx/source/inc/fmtextcontrolshell.hxx
index 3a0198758cbc..37cd875a9268 100644
--- a/svx/source/inc/fmtextcontrolshell.hxx
+++ b/svx/source/inc/fmtextcontrolshell.hxx
@@ -71,6 +71,9 @@ namespace svx
     public:
         virtual void    focusGained( const ::com::sun::star::awt::FocusEvent& _rEvent ) = 0;
         virtual void    focusLost( const ::com::sun::star::awt::FocusEvent& _rEvent ) = 0;
+
+    protected:
+        ~IFocusObserver() {}
     };
 
     //====================================================================
@@ -80,6 +83,9 @@ namespace svx
     {
     public:
         virtual void    contextMenuRequested( const ::com::sun::star::awt::MouseEvent& _rEvent ) = 0;
+
+    protected:
+        ~IContextRequestObserver() {}
     };
 
     //====================================================================
diff --git a/svx/source/inc/formcontrolling.hxx b/svx/source/inc/formcontrolling.hxx
index ae27a1299ed0..1412df2e91a7 100644
--- a/svx/source/inc/formcontrolling.hxx
+++ b/svx/source/inc/formcontrolling.hxx
@@ -78,6 +78,9 @@ namespace svx
                 Ids of the features to be invalidated.
         */
         virtual void invalidateFeatures( const ::std::vector< sal_Int32 >& _rFeatures ) = 0;
+
+    protected:
+        ~IControllerFeatureInvalidation() {}
     };
 
     //====================================================================
diff --git a/svx/source/inc/formdispatchinterceptor.hxx b/svx/source/inc/formdispatchinterceptor.hxx
index f6987e6ce252..ae70507463b8 100644
--- a/svx/source/inc/formdispatchinterceptor.hxx
+++ b/svx/source/inc/formdispatchinterceptor.hxx
@@ -47,12 +47,15 @@ namespace svxform
     class DispatchInterceptor
     {
     public:
-        DispatchInterceptor() { }
-
         virtual ::com::sun::star::uno::Reference< ::com::sun::star::frame::XDispatch> interceptedQueryDispatch(
             const ::com::sun::star::util::URL& aURL, const ::rtl::OUString& aTargetFrameName, sal_Int32 nSearchFlags) throw( ::com::sun::star::uno::RuntimeException ) = 0;
 
         virtual ::osl::Mutex* getInterceptorMutex() = 0;
+
+    protected:
+        DispatchInterceptor() {}
+
+        ~DispatchInterceptor() {}
     };
 
     //====================================================================