tdf#120703 PVS: V547 Expression is always true/false

Change-Id: If748a205b328a23473152872c6d0ed87d0570cc1
Reviewed-on: https://gerrit.libreoffice.org/62857
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1 files changed, 6 insertions, 13 deletions

diff --git a/svx/source/items/numfmtsh.cxx b/svx/source/items/numfmtsh.cxx
index a870053d54fd..923a0db04f4b 100644
--- a/svx/source/items/numfmtsh.cxx
+++ b/svx/source/items/numfmtsh.cxx
@@ -1548,25 +1548,18 @@ bool SvxNumberFormatShell::IsInTable(sal_uInt16 const nPos, bool const bTmpBanki
     if (nPos != sal_uInt16(-1))
     {
         const NfCurrencyTable& rCurrencyTable = SvNumberFormatter::GetTheCurrencyTable();
-        sal_uInt16 nCount = rCurrencyTable.size();
 
-        if (nPos < nCount)
+        if (nPos < rCurrencyTable.size())
         {
             NfWSStringsDtor aWSStringsDtor;
+            pFormatter->GetCurrencyFormatStrings(aWSStringsDtor, rCurrencyTable[nPos], bTmpBanking);
 
-            const NfCurrencyEntry* pTmpCurrencyEntry = &rCurrencyTable[nPos];
-
-            if (pTmpCurrencyEntry != nullptr)
+            for (const OUString& s : aWSStringsDtor)
             {
-                pFormatter->GetCurrencyFormatStrings(aWSStringsDtor, *pTmpCurrencyEntry, bTmpBanking);
-
-                for (const OUString& s : aWSStringsDtor)
+                if (s == rFmtString)
                 {
-                    if (s == rFmtString)
-                    {
-                        bFlag = true;
-                        break;
-                    }
+                    bFlag = true;
+                    break;
                 }
             }
         }