tdf#144052 reduce Primitive2D copying

when creating charts, by using a
Primitive2DContainer&&
parameter in the GroupPrimitive2D constructor, which forces the call
sites to pass a temporary, and at most call sites, we can std::move in
an existing local variable.

Change-Id: I531970918800c6832ab606b5a4ff5fd2d47ccf5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121844
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 2 insertions, 2 deletions

diff --git a/svx/source/sdr/overlay/overlayobject.cxx b/svx/source/sdr/overlay/overlayobject.cxx
index 02211a192c16..841e241895af 100644
--- a/svx/source/sdr/overlay/overlayobject.cxx
+++ b/svx/source/sdr/overlay/overlayobject.cxx
@@ -111,10 +111,10 @@ namespace sdr::overlay
                     const basegfx::B2DHomMatrix aTranslateGridOffset(
                         basegfx::utils::createTranslateB2DHomMatrix(
                             getOffset()));
-                    const drawinglayer::primitive2d::Primitive2DReference aEmbed(
+                    drawinglayer::primitive2d::Primitive2DReference aEmbed(
                         new drawinglayer::primitive2d::TransformPrimitive2D(
                             aTranslateGridOffset,
-                            maPrimitive2DSequence));
+                            std::move(const_cast<drawinglayer::primitive2d::Primitive2DContainer&>(maPrimitive2DSequence))));
 
                     const_cast< OverlayObject* >(this)->maPrimitive2DSequence = drawinglayer::primitive2d::Primitive2DContainer { aEmbed };
                 }