diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-30 15:34:20 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-07-31 12:42:50 +0200 |
commit | 714fe0fed88d01bac1a658fbb2de193a7704e24b (patch) | |
tree | 48d669b9555ff78dba0c87e9206db030e39cb499 /svx/source/svdraw/svdview.cxx | |
parent | cb9ce13d82839a7ce0db3bd113e70bbcc125076a (diff) |
loplugin:returnconstant in svx
Change-Id: I0cc0c32afa0d735738c6744873f3518a2763821e
Reviewed-on: https://gerrit.libreoffice.org/58334
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx/source/svdraw/svdview.cxx')
-rw-r--r-- | svx/source/svdraw/svdview.cxx | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/svx/source/svdraw/svdview.cxx b/svx/source/svdraw/svdview.cxx index 47e6af06b353..5022243ff455 100644 --- a/svx/source/svdraw/svdview.cxx +++ b/svx/source/svdraw/svdview.cxx @@ -248,9 +248,9 @@ bool SdrView::Command(const CommandEvent& rCEvt, vcl::Window* pWin) return bRet; } -bool SdrView::GetAttributes(SfxItemSet& rTargetSet, bool bOnlyHardAttr) const +void SdrView::GetAttributes(SfxItemSet& rTargetSet, bool bOnlyHardAttr) const { - return SdrCreateView::GetAttributes(rTargetSet, bOnlyHardAttr); + SdrCreateView::GetAttributes(rTargetSet, bOnlyHardAttr); } SfxStyleSheet* SdrView::GetStyleSheet() const @@ -864,7 +864,8 @@ bool SdrView::DoMouseEvent(const SdrViewEvent& rVEvt) case SdrEventKind::MarkPoint: { // + (if applicable) BegDrag if (!rVEvt.bAddMark) UnmarkAllPoints(); if (rVEvt.bPrevNextMark) { - bRet=MarkNextPoint(); + MarkNextPoint(); + bRet=false; } else { bRet=MarkPoint(*rVEvt.pHdl,rVEvt.bUnmark); } @@ -876,7 +877,8 @@ bool SdrView::DoMouseEvent(const SdrViewEvent& rVEvt) case SdrEventKind::MarkGluePoint: { // + (if applicable) BegDrag if (!rVEvt.bAddMark) UnmarkAllGluePoints(); if (rVEvt.bPrevNextMark) { - bRet=MarkNextGluePoint(); + MarkNextGluePoint(); + bRet=false; } else { bRet=MarkGluePoint(rVEvt.pObj,rVEvt.nGlueId,rVEvt.bUnmark); } @@ -905,7 +907,8 @@ bool SdrView::DoMouseEvent(const SdrViewEvent& rVEvt) } else bRet=BegCreateObj(aLogicPos); } break; case SdrEventKind::BeginMacroObj: { - bRet=BegMacroObj(aLogicPos,mnHitTolLog,rVEvt.pObj,rVEvt.pPV,static_cast<vcl::Window*>(mpActualOutDev.get())); + BegMacroObj(aLogicPos,mnHitTolLog,rVEvt.pObj,rVEvt.pPV,static_cast<vcl::Window*>(mpActualOutDev.get())); + bRet=false; } break; case SdrEventKind::BeginTextEdit: { if (!IsObjMarked(rVEvt.pObj)) { @@ -1428,7 +1431,8 @@ bool SdrView::BegMark(const Point& rPnt, bool bAddMark, bool bUnmark) return BegMarkPoints(rPnt,bUnmark); } else { if (!bAddMark) UnmarkAllObj(); - return BegMarkObj(rPnt,bUnmark); + BegMarkObj(rPnt,bUnmark); + return true; } } |