diff options
| author | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-01-23 09:01:42 +0100 |
|---|---|---|
| committer | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-01-23 13:50:45 +0000 |
| commit | abc8057ab1a1189ff7f88d42b13b363ceb228d16 (patch) | |
| tree | 20145fa90c9a1bf91dea3489d384fe6d28ac2ec0 /svx/source/table | |
| parent | 5f1bc19a9a0dbdf88e11ef81cc8c2f302748632c (diff) | |
pass ownership by pointer
to show the intend of the code.
assert on invalid objects.
remove useless OSL_ENSURE.
make sure list of owning pointers can't be copied.
Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c
Reviewed-on: https://gerrit.libreoffice.org/33393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Diffstat (limited to 'svx/source/table')
| -rw-r--r-- | svx/source/table/tablecontroller.cxx | 2 | ||||
| -rw-r--r-- | svx/source/table/tablehandles.cxx | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/svx/source/table/tablecontroller.cxx b/svx/source/table/tablecontroller.cxx index fc5acd491ba8..600495aadc82 100644 --- a/svx/source/table/tablecontroller.cxx +++ b/svx/source/table/tablecontroller.cxx @@ -2118,7 +2118,7 @@ void SvxTableController::updateSelectionOverlay() xOverlayManager->add(*pOverlay); mpSelectionOverlay = new sdr::overlay::OverlayObjectList; - mpSelectionOverlay->append(*pOverlay); + mpSelectionOverlay->append(pOverlay); } } } diff --git a/svx/source/table/tablehandles.cxx b/svx/source/table/tablehandles.cxx index a6645d2fe37a..63b2ac8f4d47 100644 --- a/svx/source/table/tablehandles.cxx +++ b/svx/source/table/tablehandles.cxx @@ -176,7 +176,7 @@ void TableEdgeHdl::CreateB2dIAObject() // create overlay object for visible parts sdr::overlay::OverlayObject* pOverlayObject = new OverlayTableEdge(aVisible, true); xManager->add(*pOverlayObject); - maOverlayGroup.append(*pOverlayObject); + maOverlayGroup.append(pOverlayObject); } if(aInvisible.count()) @@ -186,7 +186,7 @@ void TableEdgeHdl::CreateB2dIAObject() // (see OverlayTableEdge implementation) sdr::overlay::OverlayObject* pOverlayObject = new OverlayTableEdge(aInvisible, false); xManager->add(*pOverlayObject); - maOverlayGroup.append(*pOverlayObject); + maOverlayGroup.append(pOverlayObject); } } } @@ -293,7 +293,7 @@ void TableBorderHdl::CreateB2dIAObject() aHilightColor, fTransparence, fWidth, 0.0, 0.0, bAnimate); xManager->add(*pOverlayObject); - maOverlayGroup.append(*pOverlayObject); + maOverlayGroup.append(pOverlayObject); } } } |