Change OUStringLiteral from char[] to char16_t[]

This is a prerequisite for making conversion from OUStringLiteral to OUString
more efficient at least for C++20 (by replacing its internals with a constexpr-
generated sal_uString-compatible layout with a SAL_STRING_STATIC_FLAG refCount,
conditionally for C++20 for now).

For a configure-wise bare-bones build on Linux, size reported by `du -bs
instdir` grew by 118792 bytes from 1155636636 to 1155755428.

In most places just a u"..." string literal prefix had to be added.  In some
places

char const a[] = "...";

variables have been changed to char16_t, and a few places required even further
changes to code (which prompted the addition of include/o3tl/string_view.hxx
helper function o3tl::equalsIgnoreAsciiCase and the additional
OUString::createFromAscii overload).

For all uses of macros expanding to string literals, the relevant uses have been
rewritten as

u"" MACRO

instead of changing the macro definitions.  It should be possible to change at
least some of those macro definitions (and drop the u"" from their call sites)
in follow-up commits.

Change-Id: Iec4ef1a057d412d22443312d40c6a8a290dc6144
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101483
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

2 files changed, 41 insertions, 41 deletions

diff --git a/svx/source/tbxctrls/extrusioncontrols.cxx b/svx/source/tbxctrls/extrusioncontrols.cxx
index 767fb9a99497..e073aae5e6b5 100644
--- a/svx/source/tbxctrls/extrusioncontrols.cxx
+++ b/svx/source/tbxctrls/extrusioncontrols.cxx
@@ -46,54 +46,54 @@ const char g_sExtrusionProjection[] = ".uno:ExtrusionProjection";
 
 const OUStringLiteral aLightOffBmps[] =
 {
-    RID_SVXBMP_LIGHT_OFF_FROM_TOP_LEFT,
-    RID_SVXBMP_LIGHT_OFF_FROM_TOP,
-    RID_SVXBMP_LIGHT_OFF_FROM_TOP_RIGHT,
-    RID_SVXBMP_LIGHT_OFF_FROM_LEFT,
-    "",
-    RID_SVXBMP_LIGHT_OFF_FROM_RIGHT,
-    RID_SVXBMP_LIGHT_OFF_FROM_BOTTOM_LEFT,
-    RID_SVXBMP_LIGHT_OFF_FROM_BOTTOM,
-    RID_SVXBMP_LIGHT_OFF_FROM_BOTTOM_RIGHT
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_TOP_LEFT,
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_TOP,
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_TOP_RIGHT,
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_LEFT,
+    u"",
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_RIGHT,
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_BOTTOM_LEFT,
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_BOTTOM,
+    u"" RID_SVXBMP_LIGHT_OFF_FROM_BOTTOM_RIGHT
 };
 
 const OUStringLiteral aLightOnBmps[] =
 {
-    RID_SVXBMP_LIGHT_ON_FROM_TOP_LEFT,
-    RID_SVXBMP_LIGHT_ON_FROM_TOP,
-    RID_SVXBMP_LIGHT_ON_FROM_TOP_RIGHT,
-    RID_SVXBMP_LIGHT_ON_FROM_LEFT,
-    "",
-    RID_SVXBMP_LIGHT_ON_FROM_RIGHT,
-    RID_SVXBMP_LIGHT_ON_FROM_BOTTOM_LEFT,
-    RID_SVXBMP_LIGHT_ON_FROM_BOTTOM,
-    RID_SVXBMP_LIGHT_ON_FROM_BOTTOM_RIGHT
+    u"" RID_SVXBMP_LIGHT_ON_FROM_TOP_LEFT,
+    u"" RID_SVXBMP_LIGHT_ON_FROM_TOP,
+    u"" RID_SVXBMP_LIGHT_ON_FROM_TOP_RIGHT,
+    u"" RID_SVXBMP_LIGHT_ON_FROM_LEFT,
+    u"",
+    u"" RID_SVXBMP_LIGHT_ON_FROM_RIGHT,
+    u"" RID_SVXBMP_LIGHT_ON_FROM_BOTTOM_LEFT,
+    u"" RID_SVXBMP_LIGHT_ON_FROM_BOTTOM,
+    u"" RID_SVXBMP_LIGHT_ON_FROM_BOTTOM_RIGHT
 };
 
 const OUStringLiteral aLightPreviewBmps[] =
 {
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_TOP_LEFT,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_TOP,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_TOP_RIGHT,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_LEFT,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_RIGHT,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_FRONT,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_BOTTOM_LEFT,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_BOTTOM,
-    RID_SVXBMP_LIGHT_PREVIEW_FROM_BOTTOM_RIGHT
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_TOP_LEFT,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_TOP,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_TOP_RIGHT,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_LEFT,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_RIGHT,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_FRONT,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_BOTTOM_LEFT,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_BOTTOM,
+    u"" RID_SVXBMP_LIGHT_PREVIEW_FROM_BOTTOM_RIGHT
 };
 
 const OUStringLiteral aDirectionBmps[] =
 {
-    RID_SVXBMP_DIRECTION_DIRECTION_NW,
-    RID_SVXBMP_DIRECTION_DIRECTION_N,
-    RID_SVXBMP_DIRECTION_DIRECTION_NE,
-    RID_SVXBMP_DIRECTION_DIRECTION_W,
-    RID_SVXBMP_DIRECTION_DIRECTION_NONE,
-    RID_SVXBMP_DIRECTION_DIRECTION_E,
-    RID_SVXBMP_DIRECTION_DIRECTION_SW,
-    RID_SVXBMP_DIRECTION_DIRECTION_S,
-    RID_SVXBMP_DIRECTION_DIRECTION_SE
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_NW,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_N,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_NE,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_W,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_NONE,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_E,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_SW,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_S,
+    u"" RID_SVXBMP_DIRECTION_DIRECTION_SE
 };
 
 static const char* aDirectionStrs[] =
@@ -323,8 +323,8 @@ double ExtrusionDepthDialog::getDepth() const
 double const aDepthListInch[] = { 0, 1270,2540,5080,10160 };
 double const aDepthListMM[] = { 0, 1000, 2500, 5000, 10000 };
 
-const OUStringLiteral gsExtrusionDepth( ".uno:ExtrusionDepth" );
-const OUStringLiteral gsMetricUnit(     ".uno:MetricUnit"     );
+const OUStringLiteral gsExtrusionDepth( u".uno:ExtrusionDepth" );
+const OUStringLiteral gsMetricUnit(     u".uno:MetricUnit"     );
 
 ExtrusionDepthWindow::ExtrusionDepthWindow(svt::PopupWindowController* pControl, weld::Widget* pParent)
     : WeldToolbarPopup(pControl->getFrameInterface(), pParent, "svx/ui/depthwindow.ui", "DepthWindow")
diff --git a/svx/source/tbxctrls/fontworkgallery.cxx b/svx/source/tbxctrls/fontworkgallery.cxx
index 2f52fb965c12..d51f2e647422 100644
--- a/svx/source/tbxctrls/fontworkgallery.cxx
+++ b/svx/source/tbxctrls/fontworkgallery.cxx
@@ -278,7 +278,7 @@ private:
 
 }
 
-const OUStringLiteral gsFontworkAlignment(".uno:FontworkAlignment");
+const OUStringLiteral gsFontworkAlignment(u".uno:FontworkAlignment");
 
 FontworkAlignmentWindow::FontworkAlignmentWindow(svt::PopupWindowController* pControl, weld::Widget* pParent)
     : WeldToolbarPopup(pControl->getFrameInterface(), pParent, "svx/ui/fontworkalignmentcontrol.ui", "FontworkAlignmentControl")
@@ -464,8 +464,8 @@ private:
 
 }
 
-const OUStringLiteral gsFontworkCharacterSpacing(".uno:FontworkCharacterSpacing");
-const OUStringLiteral gsFontworkKernCharacterPairs(".uno:FontworkKernCharacterPairs");
+const OUStringLiteral gsFontworkCharacterSpacing(u".uno:FontworkCharacterSpacing");
+const OUStringLiteral gsFontworkKernCharacterPairs(u".uno:FontworkKernCharacterPairs");
 
 FontworkCharacterSpacingWindow::FontworkCharacterSpacingWindow(svt::PopupWindowController* pControl, weld::Widget* pParent)
     : WeldToolbarPopup(pControl->getFrameInterface(), pParent, "svx/ui/fontworkcharacterspacingcontrol.ui", "FontworkCharacterSpacingControl")