Replace fallthrough comments with new SAL_FALLTHROUGH macro

...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca

1 files changed, 22 insertions, 11 deletions

diff --git a/svx/source/toolbars/extrusionbar.cxx b/svx/source/toolbars/extrusionbar.cxx
index c30ee0cbf09a..b956061ab902 100644
--- a/svx/source/toolbars/extrusionbar.cxx
+++ b/svx/source/toolbars/extrusionbar.cxx
@@ -482,57 +482,68 @@ void ExtrusionBar::execute( SdrView* pSdrView, SfxRequest& rReq, SfxBindings& rB
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_ON_OFF;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_TILT_DOWN:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_ROTATE_DOWN;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_TILT_UP:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_ROTATE_UP;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_TILT_LEFT:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_ROTATE_LEFT;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_TILT_RIGHT:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_ROTATE_RIGHT;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_DIRECTION:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_ORIENTATION;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_PROJECTION:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_PROJECTION;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_DEPTH:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_DEPTH;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_3D_COLOR:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_COLOR;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_SURFACE:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_SURFACE;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_LIGHTING_INTENSITY:
         {
             if ( !nStrResId )
                 nStrResId = RID_SVXSTR_UNDO_APPLY_EXTRUSION_BRIGHTNESS;
-        }   // PASSTROUGH
+            SAL_FALLTHROUGH;
+        }
         case SID_EXTRUSION_LIGHTING_DIRECTION:
         {
             if ( !nStrResId )