diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-04-10 20:17:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-04-11 14:45:38 +0200 |
| commit | 85c2ed8dc790689ce69ff0a08ff5a4de98df54b7 (patch) | |
| tree | f7d7f6fce51d1a4443608971da7d9c42b1201fa3 /svx/source/xoutdev/xattr.cxx | |
| parent | 117688bd3f51a7a50b2620aa7dcc0c065f29d402 (diff) | |
loplugin:stringview add check for getToken().toInt32
where we can convert that to
o3tl::toInt32(o3tl::getToken(
and avoid the heap allocation of a temporary string
Change-Id: Ib11c19c6e6cdc0de3e551affd3578d181e292de4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132810
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx/source/xoutdev/xattr.cxx')
| -rw-r--r-- | svx/source/xoutdev/xattr.cxx | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/svx/source/xoutdev/xattr.cxx b/svx/source/xoutdev/xattr.cxx index 49248a03cf57..d94d51a398a8 100644 --- a/svx/source/xoutdev/xattr.cxx +++ b/svx/source/xoutdev/xattr.cxx @@ -235,7 +235,7 @@ OUString NameOrIndex::CheckNamedItem( const NameOrIndex* pCheckItem, const sal_u if( pNameOrIndex->GetName().startsWith( aUser ) ) { - sal_Int32 nThisIndex = pNameOrIndex->GetName().copy( aUser.getLength() ).toInt32(); + sal_Int32 nThisIndex = o3tl::toInt32(pNameOrIndex->GetName().subView( aUser.getLength() )); if( nThisIndex >= nUserIndex ) nUserIndex = nThisIndex + 1; } @@ -1236,7 +1236,7 @@ std::unique_ptr<XLineStartItem> XLineStartItem::checkForUniqueItem( SdrModel* pM if (pItem->GetName().startsWith(aUser)) { - sal_Int32 nThisIndex = pItem->GetName().copy(aUser.getLength()).toInt32(); + sal_Int32 nThisIndex = o3tl::toInt32(pItem->GetName().subView(aUser.getLength())); if (nThisIndex >= nUserIndex) nUserIndex = nThisIndex + 1; } @@ -1258,7 +1258,7 @@ std::unique_ptr<XLineStartItem> XLineStartItem::checkForUniqueItem( SdrModel* pM if (pItem->GetName().startsWith(aUser)) { - sal_Int32 nThisIndex = pItem->GetName().copy(aUser.getLength()).toInt32(); + sal_Int32 nThisIndex = o3tl::toInt32(pItem->GetName().subView(aUser.getLength())); if (nThisIndex >= nUserIndex) nUserIndex = nThisIndex + 1; } @@ -1475,7 +1475,7 @@ std::unique_ptr<XLineEndItem> XLineEndItem::checkForUniqueItem( SdrModel* pModel if (pItem->GetName().startsWith(aUser)) { - sal_Int32 nThisIndex = pItem->GetName().copy(aUser.getLength()).toInt32(); + sal_Int32 nThisIndex = o3tl::toInt32(pItem->GetName().subView(aUser.getLength())); if (nThisIndex >= nUserIndex) nUserIndex = nThisIndex + 1; } @@ -1497,7 +1497,7 @@ std::unique_ptr<XLineEndItem> XLineEndItem::checkForUniqueItem( SdrModel* pModel if (pItem->GetName().startsWith(aUser)) { - sal_Int32 nThisIndex = pItem->GetName().copy(aUser.getLength()).toInt32(); + sal_Int32 nThisIndex = o3tl::toInt32(pItem->GetName().subView(aUser.getLength())); if (nThisIndex >= nUserIndex) nUserIndex = nThisIndex + 1; } |