V801: Decreased performance

Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a

17 files changed, 38 insertions, 41 deletions

diff --git a/svx/source/dialog/charmap.cxx b/svx/source/dialog/charmap.cxx
index 5da4f6e3b248..75ec603653b3 100644
--- a/svx/source/dialog/charmap.cxx
+++ b/svx/source/dialog/charmap.cxx
@@ -739,11 +739,11 @@ sal_Int32 SvxShowCharSet::getMaxCharCount() const
 // TODO: should be moved into Font Attributes stuff
 // we let it mature here though because it is currently the only use
 
-SubsetMap::SubsetMap( const FontCharMapPtr pFontCharMap )
+SubsetMap::SubsetMap( const FontCharMapPtr& rFontCharMap )
 :   Resource( SVX_RES(RID_SUBSETMAP) )
 {
     InitList();
-    ApplyCharMap( pFontCharMap );
+    ApplyCharMap(rFontCharMap);
     FreeResource();
 }
 
@@ -1571,9 +1571,9 @@ void SubsetMap::InitList()
     maSubsets = aAllSubsets;
 }
 
-void SubsetMap::ApplyCharMap( const FontCharMapPtr pFontCharMap )
+void SubsetMap::ApplyCharMap( const FontCharMapPtr& rFontCharMap )
 {
-    if( !pFontCharMap )
+    if( !rFontCharMap )
         return;
 
     // remove subsets that are not matched in any range
@@ -1584,7 +1584,7 @@ void SubsetMap::ApplyCharMap( const FontCharMapPtr pFontCharMap )
         sal_uInt32 cMin = rSubset.GetRangeMin();
         sal_uInt32 cMax = rSubset.GetRangeMax();
 
-        int nCount =  pFontCharMap->CountCharsInRange( cMin, cMax );
+        int nCount =  rFontCharMap->CountCharsInRange( cMin, cMax );
         if( nCount <= 0 )
             it = maSubsets.erase(it);
         else
diff --git a/svx/source/dialog/framelink.cxx b/svx/source/dialog/framelink.cxx
index fec46f81bc2c..c74b2c21774d 100644
--- a/svx/source/dialog/framelink.cxx
+++ b/svx/source/dialog/framelink.cxx
@@ -1400,9 +1400,9 @@ double lcl_GetExtent( const Style& rBorder, const Style& rSide, const Style& rOp
     return nCut;
 }
 
-basegfx::B2DPoint lcl_PointToB2DPoint( const Point aPoint )
+basegfx::B2DPoint lcl_PointToB2DPoint( const Point& rPoint )
 {
-    return basegfx::B2DPoint( aPoint.getX(), aPoint.getY() );
+    return basegfx::B2DPoint(rPoint.getX(), rPoint.getY());
 }
 
 drawinglayer::primitive2d::Primitive2DSequence CreateClippedBorderPrimitives (
diff --git a/svx/source/engine3d/lathe3d.cxx b/svx/source/engine3d/lathe3d.cxx
index bb53605524bd..7869e63a988f 100644
--- a/svx/source/engine3d/lathe3d.cxx
+++ b/svx/source/engine3d/lathe3d.cxx
@@ -56,7 +56,7 @@ TYPEINIT1(E3dLatheObj, E3dCompoundObject);
 
 // Constructor from 3D polygon, scale is the conversion factor for the coordinates
 
-E3dLatheObj::E3dLatheObj(E3dDefaultAttributes& rDefault, const basegfx::B2DPolyPolygon rPoly2D)
+E3dLatheObj::E3dLatheObj(E3dDefaultAttributes& rDefault, const basegfx::B2DPolyPolygon& rPoly2D)
 :   E3dCompoundObject(rDefault),
     maPolyPoly2D(rPoly2D)
 {
diff --git a/svx/source/form/fmtextcontrolshell.cxx b/svx/source/form/fmtextcontrolshell.cxx
index b080786558a5..7d1366c5852d 100644
--- a/svx/source/form/fmtextcontrolshell.cxx
+++ b/svx/source/form/fmtextcontrolshell.cxx
@@ -1260,8 +1260,8 @@ namespace svx
     }
 
 
-    void FmTextControlShell::fillFeatureDispatchers(  const Reference< XControl > _rxControl, SfxSlotId* _pZeroTerminatedSlots,
-            ControlFeatures& _rDispatchers )
+    void FmTextControlShell::fillFeatureDispatchers(const Reference< XControl >& _rxControl, SfxSlotId* _pZeroTerminatedSlots,
+            ControlFeatures& _rDispatchers)
     {
         Reference< XDispatchProvider > xProvider( _rxControl, UNO_QUERY );
         SfxApplication* pApplication = SfxGetpApp();
diff --git a/svx/source/inc/fmtextcontrolshell.hxx b/svx/source/inc/fmtextcontrolshell.hxx
index 3f2a9f82e795..241ecaf380ce 100644
--- a/svx/source/inc/fmtextcontrolshell.hxx
+++ b/svx/source/inc/fmtextcontrolshell.hxx
@@ -165,7 +165,7 @@ namespace svx
 
         // fills the given structure with dispatchers for the given slots, for the given control
         void            fillFeatureDispatchers(
-                            const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControl > _rxControl,
+                            const ::com::sun::star::uno::Reference< ::com::sun::star::awt::XControl >& _rxControl,
                             SfxSlotId* _pZeroTerminatedSlots,
                             ControlFeatures& _rDispatchers
                         );
diff --git a/svx/source/inc/xmlxtexp.hxx b/svx/source/inc/xmlxtexp.hxx
index 82fdb20e1f23..bf21883f75f9 100644
--- a/svx/source/inc/xmlxtexp.hxx
+++ b/svx/source/inc/xmlxtexp.hxx
@@ -36,7 +36,7 @@ class SvxXMLXTableExportComponent : public SvXMLExport
 public:
     // #110680#
     SvxXMLXTableExportComponent(
-        const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext,
+        const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext,
         const OUString& rFileName,
         const com::sun::star::uno::Reference< com::sun::star::xml::sax::XDocumentHandler > & xHandler,
         const com::sun::star::uno::Reference< com::sun::star::container::XNameContainer > & xTable,
diff --git a/svx/source/inc/xmlxtimp.hxx b/svx/source/inc/xmlxtimp.hxx
index e112205602f6..f3a6f32e0b88 100644
--- a/svx/source/inc/xmlxtimp.hxx
+++ b/svx/source/inc/xmlxtimp.hxx
@@ -35,9 +35,9 @@ class SvxXMLXTableImport : public SvXMLImport
 public:
     // #110680#
     SvxXMLXTableImport(
-        const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext,
+        const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& rContext,
         const ::com::sun::star::uno::Reference< ::com::sun::star::container::XNameContainer > & rTable,
-        com::sun::star::uno::Reference< com::sun::star::document::XGraphicObjectResolver >& xGrfResolver);
+        com::sun::star::uno::Reference< com::sun::star::document::XGraphicObjectResolver >& rGrfResolver);
 
     virtual ~SvxXMLXTableImport() throw ();
 
diff --git a/svx/source/smarttags/SmartTagMgr.cxx b/svx/source/smarttags/SmartTagMgr.cxx
index 2e02ca7b6175..df96a6b84d9c 100644
--- a/svx/source/smarttags/SmartTagMgr.cxx
+++ b/svx/source/smarttags/SmartTagMgr.cxx
@@ -86,8 +86,8 @@ void SmartTagMgr::CreateBreakIterator() const
 /** Dispatches the recognize call to all installed smart tag recognizers
 */
 void SmartTagMgr::RecognizeString( const OUString& rText,
-                             const Reference< text::XTextMarkup > xMarkup,
-                             const Reference< frame::XController > xController,
+                             const Reference< text::XTextMarkup >& xMarkup,
+                             const Reference< frame::XController >& xController,
                              const lang::Locale& rLocale,
                              sal_uInt32 nStart, sal_uInt32 nLen ) const
 {
@@ -117,9 +117,9 @@ void SmartTagMgr::RecognizeString( const OUString& rText,
     }
 }
 
-void SmartTagMgr::RecognizeTextRange(const Reference< text::XTextRange> xRange,
-                             const Reference< text::XTextMarkup > xMarkup,
-                             const Reference< frame::XController > xController) const
+void SmartTagMgr::RecognizeTextRange(const Reference< text::XTextRange>& xRange,
+                             const Reference< text::XTextMarkup >& xMarkup,
+                             const Reference< frame::XController >& xController) const
 {
     for ( sal_uInt32 i = 0; i < maRecognizerList.size(); i++ )
     {
diff --git a/svx/source/svdraw/svdoashp.cxx b/svx/source/svdraw/svdoashp.cxx
index 8ae276892ffd..5d6bf2d8d7c3 100644
--- a/svx/source/svdraw/svdoashp.cxx
+++ b/svx/source/svdraw/svdoashp.cxx
@@ -2073,7 +2073,7 @@ void SdrObjCustomShape::DragResizeCustomShape( const Rectangle& rNewRect )
     }
 }
 
-void SdrObjCustomShape::DragMoveCustomShapeHdl( const Point aDestination,
+void SdrObjCustomShape::DragMoveCustomShapeHdl( const Point& rDestination,
         const sal_uInt16 nCustomShapeHdlNum, bool bMoveCalloutRectangle )
 {
     std::vector< SdrCustomShapeInteraction > aInteractionHandles( GetInteractionHandles() );
@@ -2084,7 +2084,7 @@ void SdrObjCustomShape::DragMoveCustomShapeHdl( const Point aDestination,
         {
             try
             {
-                com::sun::star::awt::Point aPt( aDestination.X(), aDestination.Y() );
+                com::sun::star::awt::Point aPt( rDestination.X(), rDestination.Y() );
                 if ( aInteractionHandle.nMode & CUSTOMSHAPE_HANDLE_MOVE_SHAPE && bMoveCalloutRectangle )
                 {
                     sal_Int32 nXDiff = aPt.X - aInteractionHandle.aPosition.X;
diff --git a/svx/source/svdraw/svdotextpathdecomposition.cxx b/svx/source/svdraw/svdotextpathdecomposition.cxx
index 4e87e4cd7896..61b5f8acf1e9 100644
--- a/svx/source/svdraw/svdotextpathdecomposition.cxx
+++ b/svx/source/svdraw/svdotextpathdecomposition.cxx
@@ -261,7 +261,7 @@ namespace
             mxBreak = com::sun::star::i18n::BreakIterator::create(xContext);
         }
 
-        void HandlePair(const basegfx::B2DPolygon rPolygonCandidate, const ::std::vector< const impPathTextPortion* >& rTextPortions)
+        void HandlePair(const basegfx::B2DPolygon& rPolygonCandidate, const ::std::vector< const impPathTextPortion* >& rTextPortions)
         {
             // prepare polygon geometry, take into account as many parameters as possible
             basegfx::B2DPolygon aPolygonCandidate(rPolygonCandidate);
diff --git a/svx/source/svdraw/svdtrans.cxx b/svx/source/svdraw/svdtrans.cxx
index d2a70835d72d..e4c0b85ffff5 100644
--- a/svx/source/svdraw/svdtrans.cxx
+++ b/svx/source/svdraw/svdtrans.cxx
@@ -276,7 +276,7 @@ double CrookSlantXPoint(Point& rPnt, Point* pC1, Point* pC2, const Point& rCente
 
 double CrookStretchXPoint(Point& rPnt, Point* pC1, Point* pC2, const Point& rCenter,
                           const Point& rRad, double& rSin, double& rCos, bool bVert,
-                          const Rectangle rRefRect)
+                          const Rectangle& rRefRect)
 {
     long y0=rPnt.Y();
     CrookSlantXPoint(rPnt,pC1,pC2,rCenter,rRad,rSin,rCos,bVert);
@@ -340,7 +340,7 @@ void CrookSlantPoly(XPolygon& rPoly, const Point& rCenter, const Point& rRad, bo
     }
 }
 
-void CrookStretchPoly(XPolygon& rPoly, const Point& rCenter, const Point& rRad, bool bVert, const Rectangle rRefRect)
+void CrookStretchPoly(XPolygon& rPoly, const Point& rCenter, const Point& rRad, bool bVert, const Rectangle& rRefRect)
 {
     double nSin,nCos;
     sal_uInt16 nPointAnz=rPoly.GetPointCount();
@@ -381,7 +381,7 @@ void CrookSlantPoly(XPolyPolygon& rPoly, const Point& rCenter, const Point& rRad
     }
 }
 
-void CrookStretchPoly(XPolyPolygon& rPoly, const Point& rCenter, const Point& rRad, bool bVert, const Rectangle rRefRect)
+void CrookStretchPoly(XPolyPolygon& rPoly, const Point& rCenter, const Point& rRad, bool bVert, const Rectangle& rRefRect)
 {
     sal_uInt16 nPolyAnz=rPoly.Count();
     for (sal_uInt16 nPolyNum=0; nPolyNum<nPolyAnz; nPolyNum++) {
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index 595f90aff5e8..cbe80906ce85 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -106,7 +106,7 @@ namespace
 class CellTextProvider : public svx::ITextProvider
 {
 public:
-    explicit CellTextProvider(const sdr::table::CellRef xCell);
+    explicit CellTextProvider(const sdr::table::CellRef& rCell);
     virtual ~CellTextProvider();
 
 private:
@@ -117,8 +117,8 @@ private:
     const sdr::table::CellRef m_xCell;
 };
 
-CellTextProvider::CellTextProvider(const sdr::table::CellRef xCell)
-    : m_xCell(xCell)
+CellTextProvider::CellTextProvider(const sdr::table::CellRef& rCell)
+    : m_xCell(rCell)
 {
 }
 
diff --git a/svx/source/tbxctrls/PaletteManager.cxx b/svx/source/tbxctrls/PaletteManager.cxx
index ac8e03d11507..109f934f1b3b 100644
--- a/svx/source/tbxctrls/PaletteManager.cxx
+++ b/svx/source/tbxctrls/PaletteManager.cxx
@@ -213,7 +213,7 @@ void PaletteManager::PopupColorPicker(const OUString& aCommand)
     }
 }
 
-void PaletteManager::DispatchColorCommand(const OUString& aCommand, const Color aColor)
+void PaletteManager::DispatchColorCommand(const OUString& aCommand, const Color& rColor)
 {
     using namespace css::uno;
     using namespace css::frame;
@@ -229,7 +229,7 @@ void PaletteManager::DispatchColorCommand(const OUString& aCommand, const Color
 
         Sequence<PropertyValue> aArgs(1);
         aArgs[0].Name = aObj.GetURLPath();
-        aArgs[0].Value = makeAny(sal_Int32(aColor.GetColor()));
+        aArgs[0].Value = makeAny(sal_Int32(rColor.GetColor()));
 
         URL aTargetURL;
         aTargetURL.Complete = aCommand;
diff --git a/svx/source/unodraw/shapepropertynotifier.cxx b/svx/source/unodraw/shapepropertynotifier.cxx
index 9c286f23c856..5b7d9a15d2b5 100644
--- a/svx/source/unodraw/shapepropertynotifier.cxx
+++ b/svx/source/unodraw/shapepropertynotifier.cxx
@@ -103,24 +103,21 @@ namespace svx
     {
     }
 
-
     PropertyChangeNotifier::~PropertyChangeNotifier()
     {
     }
 
-
-    void PropertyChangeNotifier::registerProvider( const ShapeProperty _eProperty, const PPropertyValueProvider _pProvider )
+    void PropertyChangeNotifier::registerProvider(const ShapeProperty _eProperty, const PPropertyValueProvider& _rProvider)
     {
         ENSURE_OR_THROW( _eProperty != eInvalidShapeProperty, "Illegal ShapeProperty value!" );
-        ENSURE_OR_THROW( !!_pProvider, "NULL factory not allowed." );
+        ENSURE_OR_THROW( !!_rProvider, "NULL factory not allowed." );
 
         OSL_ENSURE( m_xData->m_aProviders.find( _eProperty ) == m_xData->m_aProviders.end(),
             "PropertyChangeNotifier::registerProvider: factory for this ID already present!" );
 
-        m_xData->m_aProviders[ _eProperty ] = _pProvider;
+        m_xData->m_aProviders[ _eProperty ] = _rProvider;
     }
 
-
     void PropertyChangeNotifier::notifyPropertyChange( const ShapeProperty _eProperty ) const
     {
         ENSURE_OR_THROW( _eProperty != eInvalidShapeProperty, "Illegal ShapeProperty value!" );
diff --git a/svx/source/xml/xmlxtexp.cxx b/svx/source/xml/xmlxtexp.cxx
index d8a8c3b11e1f..6bd11a0df730 100644
--- a/svx/source/xml/xmlxtexp.cxx
+++ b/svx/source/xml/xmlxtexp.cxx
@@ -145,12 +145,12 @@ private:
 
 // #110680#
 SvxXMLXTableExportComponent::SvxXMLXTableExportComponent(
-    const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext,
+    const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& rContext,
     const OUString& rFileName,
     const uno::Reference<xml::sax::XDocumentHandler> & rHandler,
     const uno::Reference<container::XNameContainer >& xTable,
     uno::Reference<document::XGraphicObjectResolver >& xGrfResolver )
-:   SvXMLExport( xContext, "", rFileName, rHandler, NULL, FUNIT_100TH_MM),
+:   SvXMLExport(rContext, "", rFileName, rHandler, NULL, FUNIT_100TH_MM),
     mxTable( xTable )
 {
 
diff --git a/svx/source/xml/xmlxtimp.cxx b/svx/source/xml/xmlxtimp.cxx
index b49c717e5747..57632db61458 100644
--- a/svx/source/xml/xmlxtimp.cxx
+++ b/svx/source/xml/xmlxtimp.cxx
@@ -325,10 +325,10 @@ void SvxXMLTableImportContext::importBitmap( sal_uInt16 nPrfx, const OUString& r
 
 // #110680#
 SvxXMLXTableImport::SvxXMLXTableImport(
-    const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > xContext,
+    const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& rContext,
     const uno::Reference< XNameContainer > & rTable,
     uno::Reference< XGraphicObjectResolver >& xGrfResolver )
-:   SvXMLImport(xContext, "", SvXMLImportFlags::NONE),
+:   SvXMLImport(rContext, "", SvXMLImportFlags::NONE),
     mrTable( rTable )
 {
     SetGraphicResolver( xGrfResolver );
diff --git a/svx/source/xoutdev/xexch.cxx b/svx/source/xoutdev/xexch.cxx
index f363a7781d9d..5fae82cdacdf 100644
--- a/svx/source/xoutdev/xexch.cxx
+++ b/svx/source/xoutdev/xexch.cxx
@@ -38,7 +38,7 @@ XFillExchangeData::XFillExchangeData() :
 {
 }
 
-XFillExchangeData::XFillExchangeData( const XFillAttrSetItem rXFillAttrSetItem ) :
+XFillExchangeData::XFillExchangeData( const XFillAttrSetItem& rXFillAttrSetItem ) :
     pXFillAttrSetItem( static_cast<XFillAttrSetItem*>( rXFillAttrSetItem.Clone( rXFillAttrSetItem.GetItemSet().GetPool() ) ) ),
     pPool( rXFillAttrSetItem.GetItemSet().GetPool() )
 {