loplugin:passstuffbyref in svx

Change-Id: I7d405830785cb12aaceb65d6ed03dda04aa90fd8

20 files changed, 28 insertions, 28 deletions

diff --git a/svx/source/dialog/dlgctrl.cxx b/svx/source/dialog/dlgctrl.cxx
index 69dbc1ed95e7..c80c8c930109 100644
--- a/svx/source/dialog/dlgctrl.cxx
+++ b/svx/source/dialog/dlgctrl.cxx
@@ -515,7 +515,7 @@ void SvxRectCtl::Paint(vcl::RenderContext& rRenderContext, const Rectangle&)
 
 // Convert RECT_POINT Point
 
-Point SvxRectCtl::GetPointFromRP( RECT_POINT _eRP) const
+const Point& SvxRectCtl::GetPointFromRP( RECT_POINT _eRP) const
 {
     switch( _eRP )
     {
diff --git a/svx/source/dialog/docrecovery.cxx b/svx/source/dialog/docrecovery.cxx
index 08e9944b60d4..d1d997022e74 100644
--- a/svx/source/dialog/docrecovery.cxx
+++ b/svx/source/dialog/docrecovery.cxx
@@ -79,7 +79,7 @@ RecoveryCore::~RecoveryCore()
 }
 
 
-css::uno::Reference< css::uno::XComponentContext > RecoveryCore::getComponentContext()
+const css::uno::Reference< css::uno::XComponentContext >& RecoveryCore::getComponentContext()
 {
     return m_xContext;
 }
@@ -1314,7 +1314,7 @@ bool BrokenRecoveryDialog::isExecutionNeeded()
 }
 
 
-OUString BrokenRecoveryDialog::getSaveDirURL()
+const OUString& BrokenRecoveryDialog::getSaveDirURL()
 {
     return m_sSavePath;
 }
diff --git a/svx/source/dialog/imapwnd.hxx b/svx/source/dialog/imapwnd.hxx
index a82775b98e78..ed25c721db5c 100644
--- a/svx/source/dialog/imapwnd.hxx
+++ b/svx/source/dialog/imapwnd.hxx
@@ -76,7 +76,7 @@ public:
 
     virtual SdrObjUserData* Clone( SdrObject * ) const override { return new IMapUserData( *this ); }
 
-    const IMapObjectPtr     GetObject() const { return mpObj; }
+    const IMapObjectPtr&    GetObject() const { return mpObj; }
     void                    ReplaceObject( const IMapObjectPtr& pNewIMapObject ) { mpObj = pNewIMapObject; }
 };
 
diff --git a/svx/source/form/formcontroller.cxx b/svx/source/form/formcontroller.cxx
index ab51d0a6c0fa..072eae04298c 100644
--- a/svx/source/form/formcontroller.cxx
+++ b/svx/source/form/formcontroller.cxx
@@ -433,7 +433,7 @@ class OParameterContinuation : public OInteraction< XInteractionSupplyParameters
 public:
     OParameterContinuation() { }
 
-    Sequence< PropertyValue >   getValues() const { return m_aValues; }
+    const Sequence< PropertyValue >&   getValues() const { return m_aValues; }
 
 // XInteractionSupplyParameters
     virtual void SAL_CALL setParameters( const Sequence< PropertyValue >& _rValues ) throw(RuntimeException, std::exception) override;
diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index 8f1cdb1c6d80..05037da5ee5e 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -1530,7 +1530,7 @@ bool GalleryTheme::IsReadOnly() const { return pThm->IsReadOnly(); }
 bool GalleryTheme::IsDefault() const { return pThm->IsDefault(); }
 bool GalleryTheme::IsModified() const { return pThm->IsModified(); }
 
-tools::SvRef<SotStorage> GalleryTheme::GetSvDrawStorage() const
+const tools::SvRef<SotStorage>& GalleryTheme::GetSvDrawStorage() const
 {
     return aSvDrawStorageRef;
 }
diff --git a/svx/source/inc/datanavi.hxx b/svx/source/inc/datanavi.hxx
index c22b00800d6a..1869711b5734 100644
--- a/svx/source/inc/datanavi.hxx
+++ b/svx/source/inc/datanavi.hxx
@@ -301,7 +301,7 @@ namespace svxform
         inline css::uno::Reference<css::beans::XPropertySet>
                                     GetBindingForNode( const css::uno::Reference<css::xml::dom::XNode> &xNode ) { return m_xUIHelper->getBindingForNode(xNode,true); }
         inline OUString             GetServiceNameForNode( const css::uno::Reference<css::xml::dom::XNode> &xNode ) { return m_xUIHelper->getDefaultServiceNameForNode(xNode); }
-        inline XFormsUIHelper1_ref  GetXFormsHelper() const { return m_xUIHelper; }
+        const XFormsUIHelper1_ref&  GetXFormsHelper() const { return m_xUIHelper; }
     };
 
 
@@ -489,7 +489,7 @@ namespace svxform
         virtual ~AddConditionDialog();
         virtual void dispose() override;
 
-        XFormsUIHelper1_ref GetUIHelper() const { return m_xUIHelper; }
+        const XFormsUIHelper1_ref& GetUIHelper() const { return m_xUIHelper; }
         OUString GetCondition() const { return m_pConditionED->GetText(); }
         void SetCondition(const OUString& _rCondition)
         {
diff --git a/svx/source/inc/docrecovery.hxx b/svx/source/inc/docrecovery.hxx
index 62a624671035..31bfdfee0907 100644
--- a/svx/source/inc/docrecovery.hxx
+++ b/svx/source/inc/docrecovery.hxx
@@ -232,7 +232,7 @@ class RecoveryCore : public ::cppu::WeakImplHelper< css::frame::XStatusListener
 
 
         /** @short  TODO */
-        css::uno::Reference< css::uno::XComponentContext > getComponentContext();
+        const css::uno::Reference< css::uno::XComponentContext >& getComponentContext();
 
 
         /** @short  TODO */
@@ -583,7 +583,7 @@ class BrokenRecoveryDialog : public ModalDialog
 
 
         /** @short TODO */
-        OUString getSaveDirURL();
+        const OUString& getSaveDirURL();
 
 
     // helper
diff --git a/svx/source/inc/filtnav.hxx b/svx/source/inc/filtnav.hxx
index f0ed25cfc09d..91353645b3bd 100644
--- a/svx/source/inc/filtnav.hxx
+++ b/svx/source/inc/filtnav.hxx
@@ -69,7 +69,7 @@ public:
     virtual ~FmFilterData(){}
 
     void    SetText( const OUString& rText ){ m_aText = rText; }
-    OUString  GetText() const { return m_aText; }
+    const OUString& GetText() const { return m_aText; }
     FmParentData* GetParent() const {return m_pParent;}
 
     virtual Image GetImage() const;
diff --git a/svx/source/inc/fmexch.hxx b/svx/source/inc/fmexch.hxx
index 182d5a7a85c2..c0cd1dc27416 100644
--- a/svx/source/inc/fmexch.hxx
+++ b/svx/source/inc/fmexch.hxx
@@ -183,10 +183,10 @@ namespace svxform
             // Aufrufer sicherstellen)
 
         const ListBoxEntrySet&      selected() const { return m_aSelectedEntries; }
-        css::uno::Sequence< css::uno::Reference< css::uno::XInterface > >
+        const css::uno::Sequence< css::uno::Reference< css::uno::XInterface > >&
                                     hiddenControls() const { return m_aHiddenControlModels; }
 
-        css::uno::Reference< css::form::XForms >
+        const css::uno::Reference< css::form::XForms >&
                                 getFormsRoot() const { return m_xFormsRoot; }
     };
 
diff --git a/svx/source/inc/fmexpl.hxx b/svx/source/inc/fmexpl.hxx
index d3b606aecb98..1059b262b8b5 100644
--- a/svx/source/inc/fmexpl.hxx
+++ b/svx/source/inc/fmexpl.hxx
@@ -110,7 +110,7 @@ public:
     virtual ~FmNavNameChangedHint();
 
     FmEntryData*    GetEntryData() const { return pEntryData; }
-    OUString          GetNewName() const { return aNewName; }
+    const OUString& GetNewName() const { return aNewName; }
 };
 
 
@@ -163,7 +163,7 @@ public:
 
     const Image&    GetNormalImage() const { return m_aNormalImage; }
 
-    OUString          GetText() const { return aText; }
+    const OUString& GetText() const { return aText; }
     FmEntryData*    GetParent() const { return pParent; }
     FmEntryDataList* GetChildList() const { return pChildList; }
 
diff --git a/svx/source/inc/fmitems.hxx b/svx/source/inc/fmitems.hxx
index 7e3dbd3b128f..c04445f81115 100644
--- a/svx/source/inc/fmitems.hxx
+++ b/svx/source/inc/fmitems.hxx
@@ -44,7 +44,7 @@ public:
     virtual SfxPoolItem*    Create(SvStream &, sal_uInt16) const override;
     virtual SvStream&       Store(SvStream &, sal_uInt16 nItemVersion ) const override;
 
-    const css::uno::Reference< css::uno::XInterface >         GetInterface() const { return xInterface; }
+    const css::uno::Reference< css::uno::XInterface >&  GetInterface() const { return xInterface; }
 };
 
 inline FmInterfaceItem& FmInterfaceItem::operator=( const FmInterfaceItem &rCpy )
diff --git a/svx/source/inc/fmshimp.hxx b/svx/source/inc/fmshimp.hxx
index 8de87da53967..196526237c6f 100644
--- a/svx/source/inc/fmshimp.hxx
+++ b/svx/source/inc/fmshimp.hxx
@@ -382,7 +382,7 @@ public:
     SAL_DLLPRIVATE bool    setCurrentSelectionFromMark(const SdrMarkList& rMarkList);
 
     /// returns the currently selected form, or the form which all currently selected controls belong to, or <NULL/>
-    SAL_DLLPRIVATE css::uno::Reference< css::form::XForm >
+    SAL_DLLPRIVATE const css::uno::Reference< css::form::XForm >&
                 getCurrentForm() const { return m_xCurrentForm; }
     SAL_DLLPRIVATE void        forgetCurrentForm();
     /// returns whether the last known marking contained only controls
@@ -556,7 +556,7 @@ class SearchableControlIterator : public ::comphelper::IndexAccessIterator
         // der aktuelle Wert der ControlSource-css::beans::Property
 
 public:
-    OUString     getCurrentValue() const { return m_sCurrentValue; }
+    const OUString& getCurrentValue() const { return m_sCurrentValue; }
 
 public:
     SearchableControlIterator(css::uno::Reference< css::uno::XInterface> xStartingPoint);
diff --git a/svx/source/inc/fmvwimp.hxx b/svx/source/inc/fmvwimp.hxx
index 475a47651d4a..32d4459db349 100644
--- a/svx/source/inc/fmvwimp.hxx
+++ b/svx/source/inc/fmvwimp.hxx
@@ -121,7 +121,7 @@ protected:
     void setController(
             const css::uno::Reference< css::form::XForm >& xForm,
             const css::uno::Reference< css::form::runtime::XFormController >& _rxParentController );
-    css::uno::Reference< css::awt::XControlContainer >  getControlContainer() const { return m_xControlContainer; }
+    const css::uno::Reference< css::awt::XControlContainer >&  getControlContainer() const { return m_xControlContainer; }
     void updateTabOrder( const css::uno::Reference< css::form::XForm >& _rxForm );
     void dispose();
     vcl::Window* getWindow() const {return m_pWindow;}
diff --git a/svx/source/inc/svdoutlinercache.hxx b/svx/source/inc/svdoutlinercache.hxx
index 03572fc29389..39bb5d85ce3c 100644
--- a/svx/source/inc/svdoutlinercache.hxx
+++ b/svx/source/inc/svdoutlinercache.hxx
@@ -42,7 +42,7 @@ public:
 
     SdrOutliner* createOutliner( sal_uInt16 nOutlinerMode );
     void disposeOutliner( SdrOutliner* pOutliner );
-    std::vector<SdrOutliner*> GetActiveOutliners() const
+    const std::vector<SdrOutliner*>& GetActiveOutliners() const
     {
         return maActiveOutliners;
     }
diff --git a/svx/source/inc/tabwin.hxx b/svx/source/inc/tabwin.hxx
index ab224a428b97..e042fc746040 100644
--- a/svx/source/inc/tabwin.hxx
+++ b/svx/source/inc/tabwin.hxx
@@ -94,7 +94,7 @@ public:
     void FillInfo( SfxChildWinInfo& rInfo ) const override;
 
     const OUString&      GetDatabaseName() const { return m_aDatabaseName; }
-    ::dbtools::SharedConnection GetConnection() const { return m_aConnection; }
+    const ::dbtools::SharedConnection& GetConnection() const { return m_aConnection; }
     const OUString&      GetObjectName() const { return m_aObjectName; }
     sal_Int32                   GetObjectType() const { return m_nObjectType; }
 
diff --git a/svx/source/sdr/attribute/sdrformtextattribute.cxx b/svx/source/sdr/attribute/sdrformtextattribute.cxx
index 5c8330e0597d..ac34ebc32817 100644
--- a/svx/source/sdr/attribute/sdrformtextattribute.cxx
+++ b/svx/source/sdr/attribute/sdrformtextattribute.cxx
@@ -233,7 +233,7 @@ namespace drawinglayer
             XFormTextStyle getFormTextStyle() const { return meFormTextStyle; }
             XFormTextAdjust getFormTextAdjust() const { return meFormTextAdjust; }
             XFormTextShadow getFormTextShadow() const { return meFormTextShadow; }
-            Color getFormTextShdwColor() const { return maFormTextShdwColor; }
+            const Color& getFormTextShdwColor() const { return maFormTextShdwColor; }
             const SdrFormTextOutlineAttribute& getOutline() const { return maOutline; }
             const SdrFormTextOutlineAttribute& getShadowOutline() const { return maShadowOutline; }
             bool getFormTextMirror() const { return mbFormTextMirror; }
diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
index 836821b64579..cbb4f7a75622 100644
--- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
+++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
@@ -1257,7 +1257,7 @@ IMPL_LINK_NOARG_TYPED(AreaPropertyPanelBase, ModifyTransparentHdl_Impl, Edit&, v
     setFillTransparence(aLinearItem);
 }
 
-XGradient AreaPropertyPanelBase::GetGradient (const css::awt::GradientStyle eStyle) const
+const XGradient& AreaPropertyPanelBase::GetGradient (const css::awt::GradientStyle eStyle) const
 {
     switch (eStyle)
     {
diff --git a/svx/source/svdraw/svdograf.cxx b/svx/source/svdraw/svdograf.cxx
index a2bd48eda579..2ebf0effe434 100644
--- a/svx/source/svdraw/svdograf.cxx
+++ b/svx/source/svdraw/svdograf.cxx
@@ -124,7 +124,7 @@ public:
     void                UpdateAsynchron();
     void                RemoveGraphicUpdater();
 
-    OUString getReferer() const { return rGrafObj.aReferer; }
+    const OUString& getReferer() const { return rGrafObj.aReferer; }
 };
 
 class SdrGraphicUpdater : public ::osl::Thread
diff --git a/svx/source/svdraw/svdoole2.cxx b/svx/source/svdraw/svdoole2.cxx
index bfcd7d5853cc..0b8116e212e1 100644
--- a/svx/source/svdraw/svdoole2.cxx
+++ b/svx/source/svdraw/svdoole2.cxx
@@ -127,8 +127,8 @@ public:
         m_aScaleHeight = aScaleHeight;
     }
 
-    Fraction GetScaleWidth() const { return m_aScaleWidth; }
-    Fraction GetScaleHeight() const { return m_aScaleHeight; }
+    const Fraction& GetScaleWidth() const { return m_aScaleWidth; }
+    const Fraction& GetScaleHeight() const { return m_aScaleHeight; }
 
     void setWindow(const uno::Reference< awt::XWindow >& _xWindow);
 
@@ -1558,7 +1558,7 @@ void SdrOle2Obj::AbandonObject()
 }
 
 
-OUString SdrOle2Obj::GetPersistName() const
+const OUString& SdrOle2Obj::GetPersistName() const
 {
     return mpImpl->aPersistName;
 }
diff --git a/svx/source/table/accessiblecell.hxx b/svx/source/table/accessiblecell.hxx
index 0aa17a227b47..0279b6a96fbb 100644
--- a/svx/source/table/accessiblecell.hxx
+++ b/svx/source/table/accessiblecell.hxx
@@ -72,7 +72,7 @@ public:
     virtual css::uno::Reference< css::accessibility::XAccessibleStateSet> SAL_CALL getAccessibleStateSet() throw(css::uno::RuntimeException, std::exception) override;
     virtual sal_Int32 SAL_CALL getAccessibleIndexInParent() throw(css::uno::RuntimeException, std::exception) override;
     virtual OUString SAL_CALL getAccessibleName() throw (css::uno::RuntimeException, std::exception) override;
-    sdr::table::CellRef getCellRef() { return mxCell;}
+    const sdr::table::CellRef& getCellRef() { return mxCell;}
     void UpdateChildren();
     static OUString getCellName( sal_Int32 nCol, sal_Int32 nRow );