loplugin:countusersofdefaultparams in svx

Change-Id: Ic46a0dcce477c8b27aa2d4771c48fd45ad73718c
Reviewed-on: https://gerrit.libreoffice.org/27574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

22 files changed, 37 insertions, 37 deletions

diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index 5381909264ef..2b63e5acbf10 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -604,7 +604,7 @@ void DbCellControl::implDoPropertyListening(const OUString& _rPropertyName, bool
 
 void DbCellControl::doPropertyListening(const OUString& _rPropertyName)
 {
-    implDoPropertyListening( _rPropertyName );
+    implDoPropertyListening( _rPropertyName, true );
 }
 
 static void lcl_clearBroadCaster(rtl::Reference<::comphelper::OPropertyChangeMultiplexer>& _pBroadcaster)
diff --git a/svx/source/form/ParseContext.cxx b/svx/source/form/ParseContext.cxx
index 590b374f3dbd..758412c1db9a 100644
--- a/svx/source/form/ParseContext.cxx
+++ b/svx/source/form/ParseContext.cxx
@@ -159,7 +159,7 @@ namespace
         return s_nCounter;
     }
 
-    OSystemParseContext* getSharedContext(OSystemParseContext* _pContext = nullptr,bool _bSet = false)
+    OSystemParseContext* getSharedContext(OSystemParseContext* _pContext, bool _bSet)
     {
         static OSystemParseContext* s_pSharedContext = nullptr;
         if ( _pContext && !s_pSharedContext )
@@ -183,7 +183,7 @@ OParseContextClient::OParseContextClient()
     ::osl::MutexGuard aGuard( getSafteyMutex() );
     if ( 1 == osl_atomic_increment( &getCounter() ) )
     {   // first instance
-        getSharedContext( new OSystemParseContext );
+        getSharedContext( new OSystemParseContext, false );
     }
 }
 
@@ -199,7 +199,7 @@ OParseContextClient::~OParseContextClient()
 
 const OSystemParseContext* OParseContextClient::getParseContext() const
 {
-    return getSharedContext();
+    return getSharedContext(nullptr, false);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx
index 2b9bebaecbdd..eba73ac0734e 100644
--- a/svx/source/form/filtnav.cxx
+++ b/svx/source/form/filtnav.cxx
@@ -1767,7 +1767,7 @@ void FmFilterNavigator::KeyInput(const KeyEvent& rKEvt)
 
         if ( pTargetItems )
         {
-            insertFilterItem( aItemList, pTargetItems );
+            insertFilterItem( aItemList, pTargetItems, false );
             return;
         }
     }
diff --git a/svx/source/form/fmshell.cxx b/svx/source/form/fmshell.cxx
index e710f0f931a0..8825467035cd 100644
--- a/svx/source/form/fmshell.cxx
+++ b/svx/source/form/fmshell.cxx
@@ -1150,7 +1150,7 @@ void FmFormShell::GetFormState(SfxItemSet &rSet, sal_uInt16 nWhich)
             case SID_FM_SORTDOWN:
             case SID_FM_AUTOFILTER:
             case SID_FM_ORDERCRIT:
-                bEnable = GetImpl()->IsFormSlotEnabled( nWhich );
+                bEnable = GetImpl()->IsFormSlotEnabled( nWhich, nullptr );
                 break;
 
             case SID_FM_FORM_FILTERED:
@@ -1273,7 +1273,7 @@ void FmFormShell::GetTextAttributeState( SfxItemSet& _rSet )
 
 bool FmFormShell::IsActiveControl() const
 {
-    return m_pImpl->IsActiveControl();
+    return m_pImpl->IsActiveControl(false);
 }
 
 
diff --git a/svx/source/form/fmtextcontrolshell.cxx b/svx/source/form/fmtextcontrolshell.cxx
index b16df02caaa9..f21f324dd2c0 100644
--- a/svx/source/form/fmtextcontrolshell.cxx
+++ b/svx/source/form/fmtextcontrolshell.cxx
@@ -646,7 +646,7 @@ namespace svx
 
         // put the current states of the items into the set
         std::unique_ptr<SfxAllItemSet> xCurrentItems( new SfxAllItemSet( *xPureItems ) );
-        transferFeatureStatesToItemSet( m_aControlFeatures, *xCurrentItems );
+        transferFeatureStatesToItemSet( m_aControlFeatures, *xCurrentItems, false );
 
         // additional items, which we are not responsible for at the SfxShell level,
         // but which need to be forwarded to the dialog, anyway
diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
index da804566691e..8e65ae5d365b 100644
--- a/svx/source/form/fmvwimp.cxx
+++ b/svx/source/form/fmvwimp.cxx
@@ -1442,7 +1442,7 @@ SdrObject* FmXFormView::implCreateXFormsControl( const svx::OXFormsDescriptor &_
             SdrUnoObj* pLabel( nullptr );
             SdrUnoObj* pControl( nullptr );
             if  (   !createControlLabelPair( *pOutDev, 0, 0, nullptr, xNumberFormats, nOBJID, sLabelPostfix,
-                        pLabel, pControl )
+                        pLabel, pControl, nullptr, "", "", -1 )
                 )
             {
                 return nullptr;
diff --git a/svx/source/form/navigatortree.cxx b/svx/source/form/navigatortree.cxx
index 29a89b04bdda..35ca31efc13f 100644
--- a/svx/source/form/navigatortree.cxx
+++ b/svx/source/form/navigatortree.cxx
@@ -453,7 +453,7 @@ namespace svxform
                             pFormModel->BegUndo(aUndoStr);
                             // slot was valid for (exactly) one selected form
                             OUString fControlName = FM_COMPONENT_HIDDEN;
-                            NewControl( fControlName, *m_arrCurrentSelection.begin() );
+                            NewControl( fControlName, *m_arrCurrentSelection.begin(), true );
                             pFormModel->EndUndo();
 
                         }   break;
@@ -641,7 +641,7 @@ namespace svxform
         for( size_t i = 0; i < nChildCount; i++ )
         {
             FmEntryData* pChildData = pChildList->at( i );
-            Insert( pChildData );
+            Insert( pChildData, TREELIST_APPEND );
         }
 
         return pNewEntry;
diff --git a/svx/source/form/navigatortreemodel.cxx b/svx/source/form/navigatortreemodel.cxx
index 88bb2ac5194c..bec558d0032e 100644
--- a/svx/source/form/navigatortreemodel.cxx
+++ b/svx/source/form/navigatortreemodel.cxx
@@ -674,7 +674,7 @@ namespace svxform
 
             if (FmFormData* pFormData = bRecurs ? dynamic_cast<FmFormData*>(pEntryData) : nullptr)
             {
-                pChildData = FindData(rText, pFormData);
+                pChildData = FindData(rText, pFormData, true);
                 if( pChildData )
                     return pChildData;
             }
diff --git a/svx/source/gallery2/galbrws2.cxx b/svx/source/gallery2/galbrws2.cxx
index c6069dec1fb7..fc6f78570504 100644
--- a/svx/source/gallery2/galbrws2.cxx
+++ b/svx/source/gallery2/galbrws2.cxx
@@ -678,7 +678,7 @@ bool GalleryBrowser2::KeyInput( const KeyEvent& rKEvt, vcl::Window* pWindow )
                 // Inserting a gallery item in the document must be dispatched
                 if( bValidURL )
                 {
-                    Dispatch( MN_ADD );
+                    Dispatch( MN_ADD, css::uno::Reference<css::frame::XDispatch>(), css::util::URL() );
                     return true;
                 }
             }
diff --git a/svx/source/inc/filtnav.hxx b/svx/source/inc/filtnav.hxx
index afc6f0b760d1..021ff495ceeb 100644
--- a/svx/source/inc/filtnav.hxx
+++ b/svx/source/inc/filtnav.hxx
@@ -292,7 +292,7 @@ private:
      *    @param  _bCopy
      *        If <TRUE/> the items will not be removed from the model, otherwise they will.
      */
-    void insertFilterItem(const ::std::vector<FmFilterItem*>& _rFilterList,FmFilterItems* _pTargetItems, bool _bCopy = false);
+    void insertFilterItem(const ::std::vector<FmFilterItem*>& _rFilterList,FmFilterItems* _pTargetItems, bool _bCopy);
     SvTreeListEntry* getPrevEntry(SvTreeListEntry* _pStartWith = nullptr);
     SvTreeListEntry* getNextEntry(SvTreeListEntry* _pStartWith = nullptr);
 
diff --git a/svx/source/inc/fmexpl.hxx b/svx/source/inc/fmexpl.hxx
index 5b5486af54fe..49b9ecdf6ee0 100644
--- a/svx/source/inc/fmexpl.hxx
+++ b/svx/source/inc/fmexpl.hxx
@@ -377,7 +377,7 @@ namespace svxform
         FmFormShell*        GetFormShell() const { return m_pFormShell; }
         FmFormPage*         GetFormPage() const { return m_pFormPage; }
         FmEntryData*        FindData( const css::uno::Reference< css::uno::XInterface >& xElement, FmEntryDataList* pDataList, bool bRecurs=true );
-        FmEntryData*        FindData( const OUString& rText, FmFormData* pParentData, bool bRecurs=true );
+        FmEntryData*        FindData( const OUString& rText, FmFormData* pParentData, bool bRecurs );
         FmEntryDataList*    GetRootList() const { return m_pRootList; }
         static css::uno::Reference< css::container::XIndexContainer >   GetFormComponents( FmFormData* pParentFormData );
         SdrObject*          Search(SdrObjListIter& rIter, const css::uno::Reference< css::form::XFormComponent >& xComp);
@@ -429,9 +429,9 @@ namespace svxform
         bool            m_bInitialUpdate        : 1;   // bin ich das erste Mal im UpdateContent ?
         bool            m_bKeyboardCut          : 1;
 
-        FmControlData*  NewControl( const OUString& rServiceName, SvTreeListEntry* pParentEntry, bool bEditName = true );
+        FmControlData*  NewControl( const OUString& rServiceName, SvTreeListEntry* pParentEntry, bool bEditName );
         void            NewForm( SvTreeListEntry* pParentEntry );
-        SvTreeListEntry*    Insert( FmEntryData* pEntryData, sal_uLong nRelPos=TREELIST_APPEND );
+        SvTreeListEntry*    Insert( FmEntryData* pEntryData, sal_uLong nRelPos );
         void            Remove( FmEntryData* pEntryData );
 
 
diff --git a/svx/source/inc/fmshimp.hxx b/svx/source/inc/fmshimp.hxx
index d42f13fcd21a..1df45baefd2f 100644
--- a/svx/source/inc/fmshimp.hxx
+++ b/svx/source/inc/fmshimp.hxx
@@ -438,7 +438,7 @@ public:
 
     SAL_DLLPRIVATE void    ExecuteTextAttribute( SfxRequest& _rReq );
     SAL_DLLPRIVATE void    GetTextAttributeState( SfxItemSet& _rSet );
-    SAL_DLLPRIVATE bool    IsActiveControl( bool _bCountRichTextOnly = false ) const;
+    SAL_DLLPRIVATE bool    IsActiveControl( bool _bCountRichTextOnly ) const;
     SAL_DLLPRIVATE void    ForgetActiveControl();
     SAL_DLLPRIVATE void    SetControlActivationHandler( const Link<LinkParamNone*,void>& _rHdl );
 
@@ -528,7 +528,7 @@ public:
 
     /** determines whether the current form slot is currently enabled
     */
-    SAL_DLLPRIVATE bool    IsFormSlotEnabled( sal_Int32 _nSlot, css::form::runtime::FeatureState* _pCompleteState = nullptr );
+    SAL_DLLPRIVATE bool    IsFormSlotEnabled( sal_Int32 _nSlot, css::form::runtime::FeatureState* _pCompleteState );
 
 protected:
     DECL_DLLPRIVATE_LINK_TYPED( OnLoadForms, void*, void );
diff --git a/svx/source/inc/fmtextcontrolshell.hxx b/svx/source/inc/fmtextcontrolshell.hxx
index 148c88b500f4..36825fa24286 100644
--- a/svx/source/inc/fmtextcontrolshell.hxx
+++ b/svx/source/inc/fmtextcontrolshell.hxx
@@ -174,7 +174,7 @@ namespace svx
         static void     transferFeatureStatesToItemSet(
                             ControlFeatures& _rDispatchers,
                             SfxAllItemSet& _rSet,
-                            bool _bTranslateLatin = false
+                            bool _bTranslateLatin
                         );
 
         /// to be called when a control has been activated
diff --git a/svx/source/inc/fmvwimp.hxx b/svx/source/inc/fmvwimp.hxx
index bda4a412820b..299b18133722 100644
--- a/svx/source/inc/fmvwimp.hxx
+++ b/svx/source/inc/fmvwimp.hxx
@@ -277,10 +277,10 @@ private:
         const OUString& _rFieldPostfix,
         SdrUnoObj*& _rpLabel,
         SdrUnoObj*& _rpControl,
-        const css::uno::Reference< css::sdbc::XDataSource >& _rxDataSource = nullptr,
-        const OUString& _rDataSourceName = OUString(),
-        const OUString& _rCommand = OUString(),
-        const sal_Int32 _nCommandType = -1
+        const css::uno::Reference< css::sdbc::XDataSource >& _rxDataSource,
+        const OUString& _rDataSourceName,
+        const OUString& _rCommand,
+        const sal_Int32 _nCommandType
     );
 
     void ObjectRemovedInAliveMode(const SdrObject* pObject);
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 26b632a5eeee..8801a6a5968a 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -327,7 +327,7 @@ protected:
     virtual void _propertyChanged(const css::beans::PropertyChangeEvent& evt) throw(css::uno::RuntimeException) override;
 
 private:
-    void implDoPropertyListening( const OUString& _rPropertyName, bool _bWarnIfNotExistent = true );
+    void implDoPropertyListening( const OUString& _rPropertyName, bool _bWarnIfNotExistent );
 
     /// updates the "readonly" setting on m_pWindow, according to the respective property value in the given model
     void implAdjustReadOnly( const css::uno::Reference< css::beans::XPropertySet >& _rxModel,bool i_bReadOnly );
diff --git a/svx/source/svdraw/svdibrow.cxx b/svx/source/svdraw/svdibrow.cxx
index 45ab770115ac..b007ba0a9877 100644
--- a/svx/source/svdraw/svdibrow.cxx
+++ b/svx/source/svdraw/svdibrow.cxx
@@ -1123,7 +1123,7 @@ void SdrItemBrowser::Undirty()
     }
     else
     {
-        SetAttributes(&aSet);
+        SetAttributes(&aSet, nullptr);
     }
 }
 
diff --git a/svx/source/table/tablelayouter.hxx b/svx/source/table/tablelayouter.hxx
index 0ab692c2591c..5cb2e648dd65 100644
--- a/svx/source/table/tablelayouter.hxx
+++ b/svx/source/table/tablelayouter.hxx
@@ -91,8 +91,8 @@ public:
 
     void updateCells( ::Rectangle& rRectangle );
 
-    sal_Int32 getHorizontalEdge( int nEdgeY, sal_Int32* pnMin = nullptr, sal_Int32* pnMax = nullptr );
-    sal_Int32 getVerticalEdge( int nEdgeX , sal_Int32* pnMin = nullptr, sal_Int32* pnMax = nullptr);
+    sal_Int32 getHorizontalEdge( int nEdgeY, sal_Int32* pnMin, sal_Int32* pnMax );
+    sal_Int32 getVerticalEdge( int nEdgeX , sal_Int32* pnMin, sal_Int32* pnMax);
 
     void DistributeColumns( ::Rectangle& rArea, sal_Int32 nFirstCol, sal_Int32 nLastCol );
     void DistributeRows( ::Rectangle& rArea, sal_Int32 nFirstRow, sal_Int32 nLastRow );
diff --git a/svx/source/table/tablemodel.cxx b/svx/source/table/tablemodel.cxx
index a63520ca57f4..a66f497b4563 100644
--- a/svx/source/table/tablemodel.cxx
+++ b/svx/source/table/tablemodel.cxx
@@ -619,7 +619,7 @@ void TableModel::insertColumns( sal_Int32 nIndex, sal_Int32 nCount )
 
             sal_Int32 nRows = getRowCountImpl();
             while( nRows-- )
-                maRows[nRows]->insertColumns( nIndex, nCount );
+                maRows[nRows]->insertColumns( nIndex, nCount, nullptr );
 
             ColumnVector aNewColumns(nCount);
             for( sal_Int32 nOffset = 0; nOffset < nCount; ++nOffset )
diff --git a/svx/source/table/tablerow.hxx b/svx/source/table/tablerow.hxx
index a6719c8564b1..b857b66ed170 100644
--- a/svx/source/table/tablerow.hxx
+++ b/svx/source/table/tablerow.hxx
@@ -45,7 +45,7 @@ public:
 
     TableRow& operator=( const TableRow& );
 
-    void insertColumns( sal_Int32 nIndex, sal_Int32 nCount, CellVector::iterator* pIter = nullptr );
+    void insertColumns( sal_Int32 nIndex, sal_Int32 nCount, CellVector::iterator* pIter );
     void removeColumns( sal_Int32 nIndex, sal_Int32 nCount );
     /// Reference to the table model containing this row.
     const TableModelRef& getModel() const;
diff --git a/svx/source/tbxctrls/extrusioncontrols.cxx b/svx/source/tbxctrls/extrusioncontrols.cxx
index 87521a9c402b..0832955ff033 100644
--- a/svx/source/tbxctrls/extrusioncontrols.cxx
+++ b/svx/source/tbxctrls/extrusioncontrols.cxx
@@ -174,7 +174,7 @@ void ExtrusionDirectionWindow::statusChanged(
         {
             sal_Int32 nValue = 0;
             if( Event.State >>= nValue )
-                implSetDirection( nValue );
+                implSetDirection( nValue, true );
         }
     }
     else if( Event.FeatureURL.Main == g_sExtrusionProjection )
@@ -187,7 +187,7 @@ void ExtrusionDirectionWindow::statusChanged(
         {
             sal_Int32 nValue = 0;
             if( Event.State >>= nValue )
-                implSetProjection( nValue );
+                implSetProjection( nValue, true );
         }
     }
 }
@@ -224,7 +224,7 @@ void ExtrusionDirectionWindow::SelectHdl(void* pControl)
             aArgs[0].Value <<= (sal_Int32)nProjection;
 
             mrController.dispatchCommand( g_sExtrusionProjection, aArgs );
-            implSetProjection( nProjection );
+            implSetProjection( nProjection, true );
         }
     }
 }
diff --git a/svx/source/tbxctrls/extrusioncontrols.hxx b/svx/source/tbxctrls/extrusioncontrols.hxx
index 6d90ec2168ab..62c1aa091894 100644
--- a/svx/source/tbxctrls/extrusioncontrols.hxx
+++ b/svx/source/tbxctrls/extrusioncontrols.hxx
@@ -58,8 +58,8 @@ private:
     DECL_LINK_TYPED( SelectValueSetHdl, ValueSet*, void );
     void SelectHdl(void*);
 
-    void implSetDirection( sal_Int32 nSkew, bool bEnabled = true );
-    void implSetProjection( sal_Int32 nProjection, bool bEnabled = true );
+    void implSetDirection( sal_Int32 nSkew, bool bEnabled );
+    void implSetProjection( sal_Int32 nProjection, bool bEnabled );
 
 };
 
diff --git a/svx/source/tbxctrls/tbunocontroller.cxx b/svx/source/tbxctrls/tbunocontroller.cxx
index f0e32a7af069..8a3e502935a0 100644
--- a/svx/source/tbxctrls/tbunocontroller.cxx
+++ b/svx/source/tbxctrls/tbunocontroller.cxx
@@ -89,7 +89,7 @@ public:
                                              const uno::Reference< frame::XFrame >& _xFrame,
                                              FontHeightToolBoxControl& rCtrl );
 
-    void                statusChanged_Impl( long nHeight, bool bErase = false );
+    void                statusChanged_Impl( long nHeight, bool bErase );
     void                UpdateFont( const css::awt::FontDescriptor& rCurrentFont );
     void                SetOptimalSize();
 
@@ -342,7 +342,7 @@ throw ( uno::RuntimeException, std::exception )
                 m_pBox->Enable();
                 frame::status::FontHeight aFontHeight;
                 if ( rEvent.State >>= aFontHeight )
-                    m_pBox->statusChanged_Impl( long( 10. * aFontHeight.Height ) );
+                    m_pBox->statusChanged_Impl( long( 10. * aFontHeight.Height ), false );
                 else
                     m_pBox->statusChanged_Impl( long( -1 ), true );
             }