summaryrefslogtreecommitdiff
path: root/svx
diff options
context:
space:
mode:
authorMike Kaganski <mike.kaganski@collabora.com>2020-04-23 18:09:42 +0300
committerMike Kaganski <mike.kaganski@collabora.com>2020-04-23 21:45:08 +0200
commit41e1e44a1fe102be0957e83b7b3f04bcd4ed19a8 (patch)
tree8120e6cf46b45689ba70450e7676bb49cc4ef10e /svx
parente18570e5e0ff0b656bfad2b4c1a7da54a4f0649f (diff)
Don't call default ctor only to reassign later
Change-Id: Ia725652f5124a2288bcca319a35d549c0bc3e351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92793 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'svx')
-rw-r--r--svx/source/sdr/primitive2d/sdrattributecreator.cxx9
1 files changed, 3 insertions, 6 deletions
diff --git a/svx/source/sdr/primitive2d/sdrattributecreator.cxx b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
index 55c44f3dc3b2..ddfddd5998b4 100644
--- a/svx/source/sdr/primitive2d/sdrattributecreator.cxx
+++ b/svx/source/sdr/primitive2d/sdrattributecreator.cxx
@@ -756,7 +756,6 @@ namespace drawinglayer::primitive2d
attribute::SdrLineAttribute aLine;
attribute::SdrLineStartEndAttribute aLineStartEnd;
attribute::SdrTextAttribute aText;
- attribute::SdrGlowAttribute aGlow;
bool bFontworkHideContour(false);
// look for text first
@@ -790,7 +789,7 @@ namespace drawinglayer::primitive2d
{
// try shadow
const attribute::SdrShadowAttribute aShadow(createNewSdrShadowAttribute(rSet));
- aGlow = createNewSdrGlowAttribute(rSet);
+ attribute::SdrGlowAttribute aGlow = createNewSdrGlowAttribute(rSet);
return attribute::SdrLineShadowTextAttribute(aLine, aLineStartEnd, aShadow, aText, aGlow);
}
@@ -806,10 +805,8 @@ namespace drawinglayer::primitive2d
attribute::SdrLineAttribute aLine;
attribute::SdrFillAttribute aFill;
attribute::SdrLineStartEndAttribute aLineStartEnd;
- attribute::SdrShadowAttribute aShadow;
attribute::FillGradientAttribute aFillFloatTransGradient;
attribute::SdrTextAttribute aText;
- attribute::SdrGlowAttribute aGlow;
bool bFontworkHideContour(false);
// look for text first
@@ -853,10 +850,10 @@ namespace drawinglayer::primitive2d
if(bHasContent || !aLine.isDefault() || !aFill.isDefault() || !aText.isDefault())
{
// try shadow
- aShadow = createNewSdrShadowAttribute(rSet);
+ attribute::SdrShadowAttribute aShadow = createNewSdrShadowAttribute(rSet);
// glow
- aGlow = createNewSdrGlowAttribute(rSet);
+ attribute::SdrGlowAttribute aGlow = createNewSdrGlowAttribute(rSet);
return attribute::SdrLineFillShadowTextAttribute(
aLine, aFill, aLineStartEnd, aShadow, aFillFloatTransGradient, aText, aGlow);