diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-10-20 20:51:50 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2017-10-21 15:44:11 +0200 |
| commit | ead920a48aa8c35075fdb980b9d213ff1c580dd1 (patch) | |
| tree | bb1628fd293f03b22920bc74e89657320da6442e /svx | |
| parent | fe5b70723fc83f229fb4b41231a663a8700f48c4 (diff) | |
loplugin:redundantcast handle dynamic_cast
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb
Reviewed-on: https://gerrit.libreoffice.org/43621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/engine3d/view3d.cxx | 2 | ||||
| -rw-r--r-- | svx/source/svdraw/svdedxv.cxx | 17 |
2 files changed, 9 insertions, 10 deletions
diff --git a/svx/source/engine3d/view3d.cxx b/svx/source/engine3d/view3d.cxx index 076668af6fcf..7ce414051170 100644 --- a/svx/source/engine3d/view3d.cxx +++ b/svx/source/engine3d/view3d.cxx @@ -507,7 +507,7 @@ bool E3dView::ImpCloneAll3DObjectsToDestScene(E3dScene const * pSrcScene, E3dSce if(pCompoundObj) { - E3dCompoundObject* pNewCompoundObj = dynamic_cast< E3dCompoundObject* >(pCompoundObj->Clone()); + E3dCompoundObject* pNewCompoundObj = pCompoundObj->Clone(); if(pNewCompoundObj) { diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx index f4f61d646ee4..c8ee3a7b5fff 100644 --- a/svx/source/svdraw/svdedxv.cxx +++ b/svx/source/svdraw/svdedxv.cxx @@ -1490,18 +1490,17 @@ SdrEndTextEditKind SdrObjEditView::SdrEndTextEdit(bool bDontDeleteReally) // check deletion of entire TextObj SdrUndoAction* pDelUndo=nullptr; bool bDelObj=false; - SdrTextObj* pTextObj=dynamic_cast<SdrTextObj*>( pTEObj ); - if (pTextObj!=nullptr && bTextEditNewObj) + if (pTEObj!=nullptr && bTextEditNewObj) { - bDelObj=pTextObj->IsTextFrame() && - !pTextObj->HasText() && - !pTextObj->IsEmptyPresObj() && - !pTextObj->HasFill() && - !pTextObj->HasLine(); + bDelObj=pTEObj->IsTextFrame() && + !pTEObj->HasText() && + !pTEObj->IsEmptyPresObj() && + !pTEObj->HasFill() && + !pTEObj->HasLine(); - if(pTEObj->IsInserted() && bDelObj && pTextObj->GetObjInventor()==SdrInventor::Default && !bDontDeleteReally) + if(pTEObj->IsInserted() && bDelObj && pTEObj->GetObjInventor()==SdrInventor::Default && !bDontDeleteReally) { - SdrObjKind eIdent=(SdrObjKind)pTextObj->GetObjIdentifier(); + SdrObjKind eIdent=(SdrObjKind)pTEObj->GetObjIdentifier(); if(eIdent==OBJ_TEXT || eIdent==OBJ_TEXTEXT) { pDelUndo= GetModel()->GetSdrUndoFactory().CreateUndoDeleteObject(*pTEObj); |