diff options
| author | Armin Le Grand <Armin.Le.Grand@me.com> | 2021-06-05 21:30:30 +0200 |
|---|---|---|
| committer | Armin Le Grand <Armin.Le.Grand@me.com> | 2021-06-08 10:44:21 +0200 |
| commit | f3b737ab76efaf1a70dfb22c6b60b08b340cf343 (patch) | |
| tree | e9ff1657de11943e164954b7f494ce6c276918d5 /svx | |
| parent | 8fee41f75c5da6c6e7df34a9b4f73ddf59944446 (diff) | |
Remove SfxItemState::READONLY
As I experimented with redesigning the whole
Item/ItemSet/ItemPool paradigm, I alredy checked that
SfxItemState::READONLY is not used (and no one
really knows what it should do or stands for).
Since a removal of complexity is needed to get forward
with that redesign and I already made some experiences
in branch item_refactor2, I propose to remove this
state. It is not really used (gets never set).
It is mirrored/used in the UNO API in
css::frame::status::ItemState as 'READ_ONLY', but also
not used in the office's code. ItenmState itself is
used in three places, but all set the Item involved
by using a SfxVoidItem to state SfxItemState::DISABLED,
which I described in ItemState.idl. This means that
no state of READ_ONLY in UNO API is ever imported
to office code as DISABLED state at all, so not
used.
I also marked it as deprecated in the *.idl file.
I think - including the experimenting in the
mentioned branch - that this is safe for now. I
already run a full 'make check' on the changed stuff.
Change-Id: I8c15cf7b4f803076ecaaea67659f6e022ac7ef70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116752
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/table/cell.cxx | 1 | ||||
| -rw-r--r-- | svx/source/unodraw/unoshape.cxx | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx index 6e46f2a60ed6..eafaea0a1fa7 100644 --- a/svx/source/table/cell.cxx +++ b/svx/source/table/cell.cxx @@ -1415,7 +1415,6 @@ PropertyState SAL_CALL Cell::getPropertyState( const OUString& PropertyName ) switch( rSet.GetItemState( pMap->nWID, false ) ) { - case SfxItemState::READONLY: case SfxItemState::SET: eState = PropertyState_DIRECT_VALUE; break; diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx index 984356691261..fd5296007a1d 100644 --- a/svx/source/unodraw/unoshape.cxx +++ b/svx/source/unodraw/unoshape.cxx @@ -1992,7 +1992,6 @@ beans::PropertyState SvxShape::_getPropertyState( const OUString& PropertyName ) switch( rSet.GetItemState( pMap->nWID, false ) ) { - case SfxItemState::READONLY: case SfxItemState::SET: eState = beans::PropertyState_DIRECT_VALUE; break; |