diff options
author | Caolán McNamara <caolan.mcnamara@collabora.com> | 2023-07-25 21:28:54 +0100 |
---|---|---|
committer | Caolán McNamara <caolan.mcnamara@collabora.com> | 2023-07-27 13:38:39 +0200 |
commit | 6057cc1df797b980f3d1d917befcb3256f3a9fb6 (patch) | |
tree | e5f7bcd300f28b521e0f23d863120160a12e938c /svx | |
parent | 69184e2eff8eeb1f2a0b10279c1d08f70b2e7000 (diff) |
Resolves: tdf#156411 listen to "value-changed" not "changed"
we were listening to "changed" and querying the "value", but the value
isn't guaranteed to have changed while the contents are being edited,
only when "value-changed" arrives.
Change-Id: I077051555813df48adae4259aa9a93d39c360dc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154927
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
Diffstat (limited to 'svx')
-rw-r--r-- | svx/source/dialog/compressgraphicdialog.cxx | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/svx/source/dialog/compressgraphicdialog.cxx b/svx/source/dialog/compressgraphicdialog.cxx index a8be5ed6c5e8..8fcf479d889d 100644 --- a/svx/source/dialog/compressgraphicdialog.cxx +++ b/svx/source/dialog/compressgraphicdialog.cxx @@ -135,8 +135,8 @@ void CompressGraphicsDialog::Initialize() m_xInterpolationCombo->connect_changed(LINK(this, CompressGraphicsDialog, NewInterpolationModifiedHdl)); - m_xMFNewWidth->connect_changed( LINK( this, CompressGraphicsDialog, NewWidthModifiedHdl )); - m_xMFNewHeight->connect_changed( LINK( this, CompressGraphicsDialog, NewHeightModifiedHdl )); + m_xMFNewWidth->connect_value_changed( LINK( this, CompressGraphicsDialog, NewWidthModifiedHdl )); + m_xMFNewHeight->connect_value_changed( LINK( this, CompressGraphicsDialog, NewHeightModifiedHdl )); m_xResolutionLB->connect_changed( LINK( this, CompressGraphicsDialog, ResolutionModifiedHdl )); m_xBtnCalculate->connect_clicked( LINK( this, CompressGraphicsDialog, CalculateClickHdl ) ); @@ -148,8 +148,8 @@ void CompressGraphicsDialog::Initialize() m_xQualitySlider->connect_value_changed( LINK( this, CompressGraphicsDialog, SlideHdl )); m_xCompressionSlider->connect_value_changed( LINK( this, CompressGraphicsDialog, SlideHdl )); - m_xQualityMF->connect_changed( LINK( this, CompressGraphicsDialog, NewQualityModifiedHdl )); - m_xCompressionMF->connect_changed( LINK( this, CompressGraphicsDialog, NewCompressionModifiedHdl )); + m_xQualityMF->connect_value_changed( LINK( this, CompressGraphicsDialog, NewQualityModifiedHdl )); + m_xCompressionMF->connect_value_changed( LINK( this, CompressGraphicsDialog, NewCompressionModifiedHdl )); m_xJpegCompRB->set_active(true); m_xReduceResolutionCB->set_active(true); @@ -288,7 +288,7 @@ IMPL_LINK_NOARG( CompressGraphicsDialog, OkayClickHdl, weld::Button&, void ) CompressGraphicsDialog::response(RET_OK); } -IMPL_LINK_NOARG( CompressGraphicsDialog, NewWidthModifiedHdl, weld::Entry&, void ) +IMPL_LINK_NOARG( CompressGraphicsDialog, NewWidthModifiedHdl, weld::SpinButton&, void ) { m_dResolution = m_xMFNewWidth->get_value() / GetViewWidthInch(); @@ -311,19 +311,19 @@ IMPL_LINK_NOARG( CompressGraphicsDialog, NewInterpolationModifiedHdl, weld::Comb Update(); } -IMPL_LINK_NOARG( CompressGraphicsDialog, NewQualityModifiedHdl, weld::Entry&, void ) +IMPL_LINK_NOARG( CompressGraphicsDialog, NewQualityModifiedHdl, weld::SpinButton&, void ) { m_xQualitySlider->set_value(m_xQualityMF->get_value()); Update(); } -IMPL_LINK_NOARG( CompressGraphicsDialog, NewCompressionModifiedHdl, weld::Entry&, void ) +IMPL_LINK_NOARG( CompressGraphicsDialog, NewCompressionModifiedHdl, weld::SpinButton&, void ) { m_xCompressionSlider->set_value(m_xCompressionMF->get_value()); Update(); } -IMPL_LINK_NOARG( CompressGraphicsDialog, NewHeightModifiedHdl, weld::Entry&, void ) +IMPL_LINK_NOARG( CompressGraphicsDialog, NewHeightModifiedHdl, weld::SpinButton&, void ) { m_dResolution = m_xMFNewHeight->get_value() / GetViewHeightInch(); |