diff options
| author | Jim Raykowski <raykowj@gmail.com> | 2019-04-08 19:44:31 -0800 |
|---|---|---|
| committer | Jim Raykowski <raykowj@gmail.com> | 2019-04-14 00:04:06 +0200 |
| commit | 2e3b0c5d42d60d46cd9f8b8eda9424b095c63418 (patch) | |
| tree | 4774a3659bc3485c78defcdf0cea65aee98ec82c /svx | |
| parent | c034a7f68322c0f0c86a056af92cdc7fdfa18e4b (diff) | |
Remove check for empty color name
In ToolboxButtonColorUpdater::Update(const NamedColor &rNamedColor) if
the color name is empty the check for color name emptiness causes the
tool tip to remain unchanged. This produces an incorrect tool tip.
Better to show either the hex representation of the color or simply
empty. This patch shows the color name as empty. Currently there are not
any colors that I know of that have empty color names but with this
patch we are ready for them :-)
Change-Id: Ia96789b668cb358d7b03904a75e327303411e56d
Reviewed-on: https://gerrit.libreoffice.org/70448
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/tbxctrls/tbxcolorupdate.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svx/source/tbxctrls/tbxcolorupdate.cxx b/svx/source/tbxctrls/tbxcolorupdate.cxx index f7524c02bc1a..7bbeea79c346 100644 --- a/svx/source/tbxctrls/tbxcolorupdate.cxx +++ b/svx/source/tbxctrls/tbxcolorupdate.cxx @@ -75,7 +75,7 @@ namespace svx void ToolboxButtonColorUpdater::Update(const NamedColor &rNamedColor) { Update(rNamedColor.first); - if (!mbWideButton && !rNamedColor.second.isEmpty()) + if (!mbWideButton) { // Also show the current color as QuickHelpText OUString colorSuffix = " (%1)"; |