diff options
| author | Tamás Zolnai <tamas.zolnai@collabora.com> | 2018-10-31 17:20:46 +0100 |
|---|---|---|
| committer | Tamás Zolnai <tamas.zolnai@collabora.com> | 2018-11-01 13:02:26 +0100 |
| commit | 26ccd00bc96c585b7065af0dcce246b5bfaae5e1 (patch) | |
| tree | 960e163c0041c813e10f567995d648dc9332449d /svx | |
| parent | 0610c4439edf95b4cc4e16ee625b60ba606f7528 (diff) | |
clang-tidy: (WIP) bugprone-too-small-loop-variable findings
Change-Id: Iaa255b39928ac45dec1ed37e368c149d6027f561
Reviewed-on: https://gerrit.libreoffice.org/62701
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/dialog/ClassificationDialog.cxx | 2 | ||||
| -rw-r--r-- | svx/source/dialog/srchdlg.cxx | 2 | ||||
| -rw-r--r-- | svx/source/dialog/svxruler.cxx | 4 | ||||
| -rw-r--r-- | svx/source/form/fmshimp.cxx | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/svx/source/dialog/ClassificationDialog.cxx b/svx/source/dialog/ClassificationDialog.cxx index db5d4f29e22e..124fbe61da3f 100644 --- a/svx/source/dialog/ClassificationDialog.cxx +++ b/svx/source/dialog/ClassificationDialog.cxx @@ -506,7 +506,7 @@ void ClassificationDialog::toggleWidgetsDependingOnCategory() for (sal_Int32 nParagraph = 0; nParagraph < rEditEngine.GetParagraphCount(); ++nParagraph) { sal_uInt16 nFieldCount = rEditEngine.GetFieldCount(nParagraph); - for (sal_Int16 nField = 0; nField < nFieldCount; ++nField) + for (sal_uInt16 nField = 0; nField < nFieldCount; ++nField) { EFieldInfo aFieldInfo = rEditEngine.GetFieldInfo(nParagraph, nField); if (aFieldInfo.pFieldItem) diff --git a/svx/source/dialog/srchdlg.cxx b/svx/source/dialog/srchdlg.cxx index 795df4e6c1b9..83c7aad998a9 100644 --- a/svx/source/dialog/srchdlg.cxx +++ b/svx/source/dialog/srchdlg.cxx @@ -245,7 +245,7 @@ void SearchAttrItemList::Remove(size_t nPos) if ( nPos + nLen > size() ) nLen = size() - nPos; - for ( sal_uInt16 i = nPos; i < nPos + nLen; ++i ) + for ( size_t i = nPos; i < nPos + nLen; ++i ) if ( !IsInvalidItem( (*this)[i].pItem ) ) delete (*this)[i].pItem; diff --git a/svx/source/dialog/svxruler.cxx b/svx/source/dialog/svxruler.cxx index af26b6ebe48d..1fa955469697 100644 --- a/svx/source/dialog/svxruler.cxx +++ b/svx/source/dialog/svxruler.cxx @@ -3518,7 +3518,7 @@ long SvxRuler::CalcPropMaxRight(sal_uInt16 nCol) const lFences = mpBorders[nCol].nWidth; } - for(sal_uInt16 i = nStart; i < mpBorders.size() - 1; ++i) + for(size_t i = nStart; i < mpBorders.size() - 1; ++i) { long lWidth = mpBorders[i].nPos - lOldPos; lColumns += lWidth; @@ -3599,7 +3599,7 @@ long SvxRuler::CalcPropMaxRight(sal_uInt16 nCol) const else { long lWidth = 0; - for(sal_uInt16 i = nCol; i < mpBorders.size() - 1; i++) + for(size_t i = nCol; i < mpBorders.size() - 1; i++) { lWidth += glMinFrame + mpBorders[i].nWidth; } diff --git a/svx/source/form/fmshimp.cxx b/svx/source/form/fmshimp.cxx index 2390f17f362c..c3a202a06be7 100644 --- a/svx/source/form/fmshimp.cxx +++ b/svx/source/form/fmshimp.cxx @@ -1318,7 +1318,7 @@ bool FmXFormShell::canConvertCurrentSelectionToControl_Lock(const OString& rIden void FmXFormShell::checkControlConversionSlotsForCurrentSelection_Lock(Menu& rMenu) { - for (sal_Int16 i = 0; i < rMenu.GetItemCount(); ++i) + for (sal_uInt16 i = 0; i < rMenu.GetItemCount(); ++i) { // the context is already of a type that corresponds to the entry -> disable const sal_uInt16 nId = rMenu.GetItemId(i); |