diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 08:37:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 11:20:07 +0200 |
| commit | c0cc59adca23580864a2e5cdadf66212246cbfcc (patch) | |
| tree | 57413c8efb3ca4a59f3699592353da1c575e345d /svx | |
| parent | 4bf2052e9dbdfcd32a749747c918f2d714010633 (diff) | |
loplugin:singlevalfields improvement
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr
Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/sidebar/line/LineWidthValueSet.cxx | 7 | ||||
| -rw-r--r-- | svx/source/sidebar/line/LineWidthValueSet.hxx | 2 |
2 files changed, 0 insertions, 9 deletions
diff --git a/svx/source/sidebar/line/LineWidthValueSet.cxx b/svx/source/sidebar/line/LineWidthValueSet.cxx index f08d3462e24b..efe0db1851d1 100644 --- a/svx/source/sidebar/line/LineWidthValueSet.cxx +++ b/svx/source/sidebar/line/LineWidthValueSet.cxx @@ -25,7 +25,6 @@ namespace svx { namespace sidebar { LineWidthValueSet::LineWidthValueSet(vcl::Window* pParent) : ValueSet(pParent, WB_TABSTOP) - , pVDev(nullptr) , nSelItem(0) , bCusEnable(false) { @@ -43,12 +42,6 @@ LineWidthValueSet::~LineWidthValueSet() disposeOnce(); } -void LineWidthValueSet::dispose() -{ - pVDev.disposeAndClear(); - ValueSet::dispose(); -} - void LineWidthValueSet::SetUnit(std::array<OUString,9> const & strUnits) { maStrUnits = strUnits; diff --git a/svx/source/sidebar/line/LineWidthValueSet.hxx b/svx/source/sidebar/line/LineWidthValueSet.hxx index abc200b64e3a..1e60de09e73c 100644 --- a/svx/source/sidebar/line/LineWidthValueSet.hxx +++ b/svx/source/sidebar/line/LineWidthValueSet.hxx @@ -30,7 +30,6 @@ class LineWidthValueSet final : public ValueSet public: explicit LineWidthValueSet(vcl::Window* pParent); virtual ~LineWidthValueSet() override; - virtual void dispose() override; void SetUnit(std::array<OUString,9> const & strUnits); void SetSelItem(sal_uInt16 nSel); @@ -43,7 +42,6 @@ public: virtual Size GetOptimalSize() const override; private: - VclPtr<VirtualDevice> pVDev; sal_uInt16 nSelItem; std::array<OUString,9> maStrUnits; Image imgCus; |