diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-02 15:10:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-03 08:07:41 +0100 |
| commit | acdba3c2eee18ef0c079b7c41cd4165e06c956c7 (patch) | |
| tree | 18c6da7b7d46bf901b6dd4f7a5b280caa7f62280 /svx | |
| parent | f4bd9029ba7b500ebf99b7fa3d774de7fa029176 (diff) | |
loplugin:passstuffbyref more return improvements
slightly less restrictive check when calling functions
Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/inc/tablemodel.hxx | 4 | ||||
| -rw-r--r-- | svx/source/items/clipfmtitem.cxx | 2 | ||||
| -rw-r--r-- | svx/source/table/tablemodel.cxx | 4 |
3 files changed, 5 insertions, 5 deletions
diff --git a/svx/source/inc/tablemodel.hxx b/svx/source/inc/tablemodel.hxx index 5c1ac7a86e6d..e59626da0200 100644 --- a/svx/source/inc/tablemodel.hxx +++ b/svx/source/inc/tablemodel.hxx @@ -163,9 +163,9 @@ private: virtual void SAL_CALL disposing() override; /// @throws css::lang::IndexOutOfBoundsException - TableRowRef getRow( sal_Int32 nRow ) const; + TableRowRef const & getRow( sal_Int32 nRow ) const; /// @throws css::lang::IndexOutOfBoundsException - TableColumnRef getColumn( sal_Int32 nColumn ) const; + TableColumnRef const & getColumn( sal_Int32 nColumn ) const; void updateRows(); void updateColumns(); diff --git a/svx/source/items/clipfmtitem.cxx b/svx/source/items/clipfmtitem.cxx index 08aa4782f376..2855ae46789e 100644 --- a/svx/source/items/clipfmtitem.cxx +++ b/svx/source/items/clipfmtitem.cxx @@ -138,7 +138,7 @@ SotClipboardFormatId SvxClipboardFormatItem::GetClipbrdFormatId( sal_uInt16 nPos return pImpl->aFmtIds[ nPos ]; } -const OUString SvxClipboardFormatItem::GetClipbrdFormatName( sal_uInt16 nPos ) const +OUString const & SvxClipboardFormatItem::GetClipbrdFormatName( sal_uInt16 nPos ) const { return pImpl->aFmtNms[nPos]; } diff --git a/svx/source/table/tablemodel.cxx b/svx/source/table/tablemodel.cxx index 4d6a558a3622..224d6280b4a1 100644 --- a/svx/source/table/tablemodel.cxx +++ b/svx/source/table/tablemodel.cxx @@ -942,7 +942,7 @@ void TableModel::removeRows( sal_Int32 nIndex, sal_Int32 nCount ) } -TableRowRef TableModel::getRow( sal_Int32 nRow ) const +TableRowRef const & TableModel::getRow( sal_Int32 nRow ) const { if( (nRow >= 0) && (nRow < getRowCountImpl()) ) return maRows[nRow]; @@ -951,7 +951,7 @@ TableRowRef TableModel::getRow( sal_Int32 nRow ) const } -TableColumnRef TableModel::getColumn( sal_Int32 nColumn ) const +TableColumnRef const & TableModel::getColumn( sal_Int32 nColumn ) const { if( (nColumn >= 0) && (nColumn < getColumnCountImpl()) ) return maColumns[nColumn]; |