diff options
| author | Lionel Elie Mamane <lionel@mamane.lu> | 2014-06-24 19:09:48 +0200 |
|---|---|---|
| committer | Lionel Elie Mamane <lionel@mamane.lu> | 2014-06-24 19:15:45 +0200 |
| commit | 402e0c0a679dd4da2b1767d959be9aa364c1878d (patch) | |
| tree | dfea94048790969110ea94f34361232536050458 /svx | |
| parent | de00dd0a4e9c10e283f5b8093ac1771545cbe243 (diff) | |
fdo#75339 object comparison by reference, not pointer
Reference<>::operator== ensures that the comparison is done right.
::get may return different raw pointers for the same object,
yielding false positives.
Although the same end effect is reached by
commit f8115ce72dad45b82b044d9c8f5c253d0514574d
author Stephan Bergmann <sbergman@redhat.com> 2014-06-24 09:40:23 (GMT)
fdo#75339: Substituting XInterface* eq. for object eq. requires queryInterface
This way is more robust against future "clean-up"s.
Change-Id: I2f3c63ac577152c666554b78b88d3779dabe4d45
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/form/formcontroller.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svx/source/form/formcontroller.cxx b/svx/source/form/formcontroller.cxx index 6660be4dfa0e..e46897a153d8 100644 --- a/svx/source/form/formcontroller.cxx +++ b/svx/source/form/formcontroller.cxx @@ -308,7 +308,7 @@ namespace bool lcl_isBoundTo( const Reference< XPropertySet >& _rxControlModel, const Reference< XInterface >& _rxNormDBField ) { Reference< XInterface > xNormBoundField( _rxControlModel->getPropertyValue( FM_PROP_BOUNDFIELD ), UNO_QUERY ); - return ( xNormBoundField.get() == _rxNormDBField.get() ); + return ( xNormBoundField == _rxNormDBField ); } bool lcl_isInputRequired( const Reference< XPropertySet >& _rxControlModel ) |