More -Werror,-Wunused-private-field

...detected with a modified trunk Clang with

> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp	(revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp	(working copy)
> @@ -1917,9 +1917,10 @@
>    const Type *T = FD.getType()->getBaseElementTypeUnsafe();
>    // FIXME: Destruction of ObjC lifetime types has side-effects.
>    if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> -    return !RD->isCompleteDefinition() ||
> -           !RD->hasTrivialDefaultConstructor() ||
> -           !RD->hasTrivialDestructor();
> +    return !RD->hasAttr<WarnUnusedAttr>() &&
> +           (!RD->isCompleteDefinition() ||
> +            !RD->hasTrivialDefaultConstructor() ||
> +            !RD->hasTrivialDestructor());
>    return false;
>  }
>
> @@ -3517,9 +3518,11 @@
>    bool addFieldInitializer(CXXCtorInitializer *Init) {
>      AllToInit.push_back(Init);
>
> +#if 0
>      // Check whether this initializer makes the field "used".
>      if (Init->getInit()->HasSideEffects(S.Context))
>        S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
>      return false;
>    }

to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").

Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628

3 files changed, 0 insertions, 14 deletions

diff --git a/svx/source/inc/docrecovery.hxx b/svx/source/inc/docrecovery.hxx
index bd5dbac2b6e9..74946f132e08 100644
--- a/svx/source/inc/docrecovery.hxx
+++ b/svx/source/inc/docrecovery.hxx
@@ -402,7 +402,6 @@ class SaveProgressDialog : public ModalDialog
 {
     // member
     private:
-        OUString      m_aProgrBaseTxt;
         vcl::Window*       m_pProgrParent;
 
         // @short   TODO
diff --git a/svx/source/sidebar/area/AreaPropertyPanel.hxx b/svx/source/sidebar/area/AreaPropertyPanel.hxx
index b0c2b0ea1deb..0d3540f6e21d 100644
--- a/svx/source/sidebar/area/AreaPropertyPanel.hxx
+++ b/svx/source/sidebar/area/AreaPropertyPanel.hxx
@@ -137,7 +137,6 @@ private:
     Image                                               maImgLinear;
     Image                                               maImgColor;
 
-    OUString                                            msHelpFillType;
     OUString                                            msHelpFillAttr;
 
     AreaTransparencyGradientPopup maTrGrPopup;
diff --git a/svx/source/sidebar/possize/PosSizePropertyPanel.hxx b/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
index b5718ef54b69..97fa3e27708d 100644
--- a/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
+++ b/svx/source/sidebar/possize/PosSizePropertyPanel.hxx
@@ -125,18 +125,6 @@ private:
     ::sfx2::sidebar::EnumContext            maContext;
     SfxBindings*                            mpBindings;
 
-    // to remember original positions for restoring these for different layouts
-    Point                                   maFtWidthOrigPos;
-    Point                                   maMtrWidthOrigPos;
-    Point                                   maFtHeightOrigPos;
-    Point                                   maMtrHeightOrigPos;
-    Point                                   maCbxScaleOrigPos;
-    Point                                   maFtAngleOrigPos;
-    Point                                   maMtrAnglOrigPos;
-    Point                                   maFlipTbxOrigPos;
-    Point                                   maDialOrigPos;
-    Point                                   maFtFlipOrigPos;
-
     /// bitfield
     bool                                    mbMtrPosXMirror : 1;
     bool                                    mbSizeProtected : 1;