summaryrefslogtreecommitdiff
path: root/svx
diff options
context:
space:
mode:
authorMichael Stahl <mstahl@redhat.com>2012-09-04 20:38:17 +0200
committerMichael Stahl <mstahl@redhat.com>2012-09-04 20:47:59 +0200
commit1146b889325fd01f24c6aacf557d3940dd147936 (patch)
treef5480c70d913726bea4ad9b1634ad330a086aef8 /svx
parent61b899e4b6b10c78daa818751e341f0c69e6f3d7 (diff)
fdo#53872: reportdesign: fix section drawpage crash:
In order to wrap the SdrPage's UNO object completely, set its mxUnoPage member to the OSection wrapper instance in OSection::init; only OSection should have access to it. Also initialize m_xDrawPage_Tunnel (thanks Lionel for the hint). (regression from 05218c101df486302bf4cfe8be23ad840daa3f73) Change-Id: I048ddafc31e946853e56e6a403ddc9487cfbcf0e
Diffstat (limited to 'svx')
-rw-r--r--svx/inc/svx/svdpage.hxx11
-rw-r--r--svx/source/svdraw/svdpage.cxx5
2 files changed, 11 insertions, 5 deletions
diff --git a/svx/inc/svx/svdpage.hxx b/svx/inc/svx/svdpage.hxx
index 5ab0f5ab916a..cc1761dba71e 100644
--- a/svx/inc/svx/svdpage.hxx
+++ b/svx/inc/svx/svdpage.hxx
@@ -42,12 +42,14 @@
#include <svx/sdrmasterpagedescriptor.hxx>
#include "svx/svxdllapi.h"
#include <com/sun/star/container/XIndexAccess.hpp>
+#include <com/sun/star/drawing/XDrawPage.hpp>
#include <svx/svdobj.hxx>
#include <boost/scoped_ptr.hpp>
//////////////////////////////////////////////////////////////////////////////
// predefines
+namespace reportdesign { class OSection; }
namespace sdr { namespace contact { class ViewContact; }}
class SdrPage;
class SdrModel;
@@ -444,8 +446,8 @@ public:
friend class SvxUnoDrawPagesAccess;
// this class uses its own UNO wrapper
-// and thus has to set mxUnoPage
-friend class ChXChartDocument;
+// and thus has to set mxUnoPage (it also relies on mxUnoPage not being WeakRef)
+friend class reportdesign::OSection;
sal_Int32 nWdt; // Seitengroesse
sal_Int32 nHgt; // Seitengroesse
@@ -454,12 +456,11 @@ friend class ChXChartDocument;
sal_Int32 nBordRgt; // Seitenrand rechts
sal_Int32 nBordLwr; // Seitenrand unten
- ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > mxUnoPage;
-
protected:
SdrLayerAdmin* pLayerAdmin;
private:
SdrPageProperties* mpSdrPageProperties;
+ ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > mxUnoPage;
public:
SdrPageProperties& getSdrPageProperties() { return *mpSdrPageProperties; }
@@ -482,6 +483,8 @@ protected:
// #i93597#
unsigned mbPageBorderOnlyLeftRight : 1;
+ void SetUnoPage(::com::sun::star::uno::Reference<
+ ::com::sun::star::drawing::XDrawPage> const&);
virtual ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > createUnoPage();
public:
diff --git a/svx/source/svdraw/svdpage.cxx b/svx/source/svdraw/svdpage.cxx
index fffb8ed6c87b..05434c43dbfa 100644
--- a/svx/source/svdraw/svdpage.cxx
+++ b/svx/source/svdraw/svdpage.cxx
@@ -1785,10 +1785,13 @@ void SdrPage::SetInserted( bool bIns )
}
}
+void SdrPage::SetUnoPage(uno::Reference<drawing::XDrawPage> const& xNewPage)
+{
+ mxUnoPage = xNewPage;
+}
uno::Reference< uno::XInterface > SdrPage::getUnoPage()
{
- // try weak reference first
if( !mxUnoPage.is() )
{
// create one