loplugin:unusedfields in svx part2

Change-Id: Ie9fd55b71a152f428a397d9917918f0e9de39aaf
Reviewed-on: https://gerrit.libreoffice.org/39014
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

24 files changed, 7 insertions, 171 deletions

diff --git a/svx/inc/svdibrow.hxx b/svx/inc/svdibrow.hxx
index bcfe6a1dcc7b..682333ad4401 100644
--- a/svx/inc/svdibrow.hxx
+++ b/svx/inc/svdibrow.hxx
@@ -41,13 +41,9 @@ friend class ImpItemEdit;
     ImpItemListRow* pAktChangeEntry;
     long   nLastWhichOfs;
     sal_uInt16 nLastWhich;
-    sal_uInt16 nLastWhichOben;
-    sal_uInt16 nLastWhichUnten;
     bool bWhichesButNames;
     bool bDontHideIneffectiveItems;
     bool bDontSortItems;
-    bool bShowWhichIds;
-    bool bShowRealValues;
 
 private:
     void ImpCtor();
diff --git a/svx/source/dialog/ctredlin.cxx b/svx/source/dialog/ctredlin.cxx
index 79bdc8465bc3..b84393490c6f 100644
--- a/svx/source/dialog/ctredlin.cxx
+++ b/svx/source/dialog/ctredlin.cxx
@@ -95,7 +95,6 @@ void SvLBoxColorString::Paint(const Point& rPos, SvTreeListBox& rDev, vcl::Rende
 
 SvxRedlinTable::SvxRedlinTable(SvSimpleTableContainer& rParent, WinBits nBits)
     : SvSimpleTable(rParent,nBits)
-    , bIsCalc(false)
     , nDatePos(WRITER_DATE)
     , bAuthor(false)
     , bDate(false)
@@ -163,9 +162,9 @@ sal_Int32 SvxRedlinTable::ColCompare(SvTreeListEntry* pLeft,SvTreeListEntry* pRi
 
     return nCompare;
 }
+
 void SvxRedlinTable::SetCalcView()
 {
-    bIsCalc=true;
     nDatePos=CALC_DATE;
 }
 
diff --git a/svx/source/dialog/frmdirlbox.cxx b/svx/source/dialog/frmdirlbox.cxx
index 83ecb4bb0ac1..d4fccb836360 100644
--- a/svx/source/dialog/frmdirlbox.cxx
+++ b/svx/source/dialog/frmdirlbox.cxx
@@ -38,7 +38,6 @@ inline SvxFrameDirection lclVoidToEnum( void* pDirection )
 
 FrameDirectionListBox::FrameDirectionListBox( vcl::Window* pParent, WinBits nBits )
     : ListBox(pParent, nBits)
-    , meSaveValue(SvxFrameDirection::Horizontal_LR_TB)
 {
 }
 
diff --git a/svx/source/dialog/hdft.cxx b/svx/source/dialog/hdft.cxx
index 6a4d0bb2ece3..ac1fa114b4e7 100644
--- a/svx/source/dialog/hdft.cxx
+++ b/svx/source/dialog/hdft.cxx
@@ -730,20 +730,6 @@ IMPL_LINK_NOARG(SvxHFPage, BackgroundHdl, Button*, void)
                 }
             }
 
-            {
-                const sal_uInt16 nWhich = GetWhich(SID_ATTR_BORDER_OUTER);
-
-                if(pBBSet->GetItemState(nWhich) == SfxItemState::SET)
-                {
-                    const SvxBoxItem& rItem = static_cast<const SvxBoxItem&>(pBBSet->Get(nWhich));
-
-                    if(nId == SID_ATTR_PAGE_HEADERSET)
-                        m_pBspWin->SetHdBorder(rItem);
-                    else
-                        m_pBspWin->SetFtBorder(rItem);
-                }
-            }
-
         }
 
         UpdateExample();
@@ -806,14 +792,6 @@ void SvxHFPage::ResetBackground_Impl( const SfxItemSet& rSet )
             }
 
             m_pBspWin->setHeaderFillAttributes(aHeaderFillAttributes);
-            nWhich = GetWhich(SID_ATTR_BORDER_OUTER);
-
-            if(rTmpSet.GetItemState(nWhich) == SfxItemState::SET)
-            {
-                const SvxBoxItem& rItem =
-                    static_cast<const SvxBoxItem&>(rTmpSet.Get(nWhich));
-                m_pBspWin->SetHdBorder(rItem);
-            }
         }
     }
 
@@ -851,12 +829,6 @@ void SvxHFPage::ResetBackground_Impl( const SfxItemSet& rSet )
 
             m_pBspWin->setFooterFillAttributes(aFooterFillAttributes);
             nWhich = GetWhich(SID_ATTR_BORDER_OUTER);
-
-            if(rTmpSet.GetItemState(nWhich) == SfxItemState::SET)
-            {
-                const SvxBoxItem& rItem = static_cast< const SvxBoxItem& >(rTmpSet.Get(nWhich));
-                m_pBspWin->SetFtBorder(rItem);
-            }
         }
     }
 
@@ -883,13 +855,6 @@ void SvxHFPage::ResetBackground_Impl( const SfxItemSet& rSet )
     }
 
     m_pBspWin->setPageFillAttributes(aPageFillAttributes);
-    nWhich = GetWhich(SID_ATTR_BORDER_OUTER);
-
-    if(rSet.GetItemState(nWhich) >= SfxItemState::DEFAULT)
-    {
-        const SvxBoxItem& rItem = static_cast< const SvxBoxItem& >(rSet.Get(nWhich));
-        m_pBspWin->SetBorder(rItem);
-    }
 }
 
 void SvxHFPage::ActivatePage( const SfxItemSet& rSet )
diff --git a/svx/source/dialog/langbox.cxx b/svx/source/dialog/langbox.cxx
index f6ee80824c03..2cb2ec5e7d7a 100644
--- a/svx/source/dialog/langbox.cxx
+++ b/svx/source/dialog/langbox.cxx
@@ -138,7 +138,6 @@ VCL_BUILDER_DECL_FACTORY(SvxLanguageComboBox)
 
 SvxLanguageBoxBase::SvxLanguageBoxBase()
     : m_pSpellUsedLang(nullptr)
-    , m_nLangList(SvxLanguageListFlags::EMPTY)
     , m_bHasLangNone(false)
     , m_bLangNoneIsLangAll(false)
     , m_bWithCheckmark(false)
@@ -150,7 +149,6 @@ void SvxLanguageBoxBase::ImplLanguageBoxBaseInit()
     m_aNotCheckedImage = Image(BitmapEx(RID_SVXBMP_NOTCHECKED));
     m_aCheckedImage = Image(BitmapEx(RID_SVXBMP_CHECKED));
     m_aAllString            = SvxResId( RID_SVXSTR_LANGUAGE_ALL );
-    m_nLangList             = SvxLanguageListFlags::EMPTY;
     m_bHasLangNone          = false;
     m_bLangNoneIsLangAll    = false;
 
@@ -171,7 +169,6 @@ void SvxLanguageBoxBase::ImplLanguageBoxBaseInit()
             if ( bInsert )
                 InsertLanguage( nLangType );
         }
-        m_nLangList = SvxLanguageListFlags::ALL;
     }
 }
 
@@ -227,7 +224,6 @@ void SvxLanguageBoxBase::SetLanguageList( SvxLanguageListFlags nLangList,
 {
     ImplClear();
 
-    m_nLangList             = nLangList;
     m_bHasLangNone          = bHasLangNone;
     m_bLangNoneIsLangAll    = bLangNoneIsLangAll;
     m_bWithCheckmark        = bCheckSpellAvail;
diff --git a/svx/source/dialog/pagectrl.cxx b/svx/source/dialog/pagectrl.cxx
index 02eb8d54a5cc..1af0c97f9139 100644
--- a/svx/source/dialog/pagectrl.cxx
+++ b/svx/source/dialog/pagectrl.cxx
@@ -46,7 +46,6 @@ SvxPageWindow::SvxPageWindow(vcl::Window* pParent)
     nLeft(0),
     nRight(0),
 
-    pBorder(nullptr),
     bResetBackground(false),
     bFrameDirection(false),
     nFrameDirection(SvxFrameDirection::Horizontal_LR_TB),
@@ -56,14 +55,11 @@ SvxPageWindow::SvxPageWindow(vcl::Window* pParent)
     nHdDist(0),
     nHdHeight(0),
 
-    pHdBorder(nullptr),
     nFtLeft(0),
     nFtRight(0),
     nFtDist(0),
     nFtHeight(0),
 
-    pFtBorder(nullptr),
-
     maHeaderFillAttributes(),
     maFooterFillAttributes(),
     maPageFillAttributes(),
@@ -90,13 +86,6 @@ SvxPageWindow::~SvxPageWindow()
     disposeOnce();
 }
 
-void SvxPageWindow::dispose()
-{
-    delete pHdBorder;
-    delete pFtBorder;
-    vcl::Window::dispose();
-}
-
 VCL_BUILDER_FACTORY(SvxPageWindow)
 
 void SvxPageWindow::Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle&)
@@ -404,26 +393,6 @@ void SvxPageWindow::drawFillAttributes(vcl::RenderContext& rRenderContext,
 }
 
 
-void SvxPageWindow::SetBorder(const SvxBoxItem& rNew)
-{
-    delete pBorder;
-    pBorder = new SvxBoxItem(rNew);
-}
-
-
-void SvxPageWindow::SetHdBorder(const SvxBoxItem& rNew)
-{
-    delete pHdBorder;
-    pHdBorder = new SvxBoxItem(rNew);
-}
-
-
-void SvxPageWindow::SetFtBorder(const SvxBoxItem& rNew)
-{
-    delete pFtBorder;
-    pFtBorder = new SvxBoxItem(rNew);
-}
-
 void SvxPageWindow::EnableFrameDirection(bool bEnable)
 {
     bFrameDirection = bEnable;
diff --git a/svx/source/dialog/paraprev.cxx b/svx/source/dialog/paraprev.cxx
index 4d64c91aebcc..5a7bc24c3440 100644
--- a/svx/source/dialog/paraprev.cxx
+++ b/svx/source/dialog/paraprev.cxx
@@ -31,9 +31,7 @@ SvxParaPrevWindow::SvxParaPrevWindow( vcl::Window* pParent,  WinBits nBits) :
     nLower          ( 0 ),
     eAdjust         ( SvxAdjust::Left ),
     eLastLine       ( SvxAdjust::Left ),
-    eLine           ( SvxPrevLineSpace::N1 ),
-    nLineVal        ( 0 )
-
+    eLine           ( SvxPrevLineSpace::N1 )
 {
     // Count in Twips by default
     SetMapMode(MapMode(MapUnit::MapTwip));
diff --git a/svx/source/dialog/relfld.cxx b/svx/source/dialog/relfld.cxx
index 84c564f5864e..867086467d8d 100644
--- a/svx/source/dialog/relfld.cxx
+++ b/svx/source/dialog/relfld.cxx
@@ -25,7 +25,6 @@ SvxRelativeField::SvxRelativeField(
     : MetricField( pParent, nBits)
     , nRelMin(0)
     , nRelMax(0)
-    , nRelStep(0)
     , bRelativeMode(false)
     , bRelative(false)
     , bNegativeEnabled(false)
@@ -85,13 +84,11 @@ void SvxRelativeField::Modify()
 }
 
 
-void SvxRelativeField::EnableRelativeMode( sal_uInt16 nMin,
-                                           sal_uInt16 nMax, sal_uInt16 nStep )
+void SvxRelativeField::EnableRelativeMode( sal_uInt16 nMin, sal_uInt16 nMax )
 {
     bRelativeMode = true;
     nRelMin       = nMin;
     nRelMax       = nMax;
-    nRelStep      = nStep;
     SetUnit( FUNIT_CM );
 }
 
diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index 58dd644deedd..f5489e3dda16 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -158,8 +158,6 @@ void DbGridColumn::CreateControl(sal_Int32 _nFieldPos, const Reference< css::bea
             case DataType::DATE:
             case DataType::TIME:
             case DataType::TIMESTAMP:
-                m_bDateTime = true;
-                SAL_FALLTHROUGH;
             case DataType::BIT:
             case DataType::BOOLEAN:
             case DataType::TINYINT:
@@ -1215,9 +1213,7 @@ void DbTextField::implSetEffectiveMaxTextLen( sal_Int32 _nMaxLen )
 
 DbFormattedField::DbFormattedField(DbGridColumn& _rColumn)
     :DbLimitedLengthField(_rColumn)
-    ,m_nKeyType(css::util::NumberFormat::UNDEFINED)
 {
-
     // if our model's format key changes we want to propagate the new value to our windows
     doPropertyListening( FM_PROP_FORMATKEY );
 }
@@ -1335,8 +1331,6 @@ void DbFormattedField::Init( vcl::Window& rParent, const Reference< XRowSet >& x
     if (nFormatKey == -1)
         nFormatKey = 0;
 
-    m_nKeyType  = comphelper::getNumberFormatType(m_xSupplier->getNumberFormats(), nFormatKey);
-
     static_cast<FormattedField*>(m_pWindow.get())->SetFormatter(pFormatterUsed);
     static_cast<FormattedField*>(m_pPainter.get())->SetFormatter(pFormatterUsed);
 
@@ -1448,7 +1442,6 @@ void DbFormattedField::_propertyChanged( const PropertyChangeEvent& _rEvent )
     if (_rEvent.PropertyName == FM_PROP_FORMATKEY )
     {
         sal_Int32 nNewKey = _rEvent.NewValue.hasValue() ? ::comphelper::getINT32(_rEvent.NewValue) : 0;
-        m_nKeyType = comphelper::getNumberFormatType(m_xSupplier->getNumberFormats(), nNewKey);
 
         DBG_ASSERT(m_pWindow && m_pPainter, "DbFormattedField::_propertyChanged : where are my windows ?");
         if (m_pWindow)
diff --git a/svx/source/fmcomp/gridctrl.cxx b/svx/source/fmcomp/gridctrl.cxx
index af464e75a3ee..2b0aa598f9bd 100644
--- a/svx/source/fmcomp/gridctrl.cxx
+++ b/svx/source/fmcomp/gridctrl.cxx
@@ -969,7 +969,6 @@ DbGridControl::DbGridControl(
             ,m_bHandle(true)
             ,m_bFilterMode(false)
             ,m_bWantDestruction(false)
-            ,m_bInAdjustDataSource(false)
             ,m_bPendingAdjustRows(false)
             ,m_bHideScrollbars( false )
             ,m_bUpdating(false)
@@ -2252,7 +2251,6 @@ void DbGridControl::AdjustDataSource(bool bFull)
     if (nNewPos < 0)// could not find any position
         return;
 
-    m_bInAdjustDataSource = true;
     if (nNewPos != m_nCurrentPos)
     {
         if (m_bSynchDisplay)
@@ -2270,7 +2268,6 @@ void DbGridControl::AdjustDataSource(bool bFull)
         SetCurrent(nNewPos);
         RowModified(nNewPos);
     }
-    m_bInAdjustDataSource = false;
 
     // if the data cursor was moved from outside, this section is voided
     SetNoSelection();
diff --git a/svx/source/form/fmPropBrw.cxx b/svx/source/form/fmPropBrw.cxx
index e727d526b7a0..7b8e4d02f9e0 100644
--- a/svx/source/form/fmPropBrw.cxx
+++ b/svx/source/form/fmPropBrw.cxx
@@ -186,7 +186,6 @@ FmPropBrw::FmPropBrw( const Reference< XComponentContext >& _xORB, SfxBindings*
     :SfxFloatingWindow(_pBindings, _pMgr, _pParent, WinBits(WB_STDMODELESS|WB_SIZEABLE|WB_3DLOOK|WB_ROLLABLE) )
     ,SfxControllerItem(SID_FM_PROPERTY_CONTROL, *_pBindings)
     ,m_bInitialStateChange(true)
-    ,m_bInStateChange( false )
     ,m_xORB(_xORB)
 {
 
@@ -622,7 +621,6 @@ void FmPropBrw::StateChanged(sal_uInt16 nSID, SfxItemState eState, const SfxPool
     if (!pState  || SID_FM_PROPERTY_CONTROL != nSID)
         return;
 
-    m_bInStateChange = true;
     try
     {
         if (eState >= SfxItemState::DEFAULT)
@@ -671,7 +669,6 @@ void FmPropBrw::StateChanged(sal_uInt16 nSID, SfxItemState eState, const SfxPool
     {
         OSL_FAIL("FmPropBrw::StateChanged: Exception occurred!");
     }
-    m_bInStateChange = false;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/form/fmmodel.cxx b/svx/source/form/fmmodel.cxx
index e0dd072fefb5..823632e7f46f 100644
--- a/svx/source/form/fmmodel.cxx
+++ b/svx/source/form/fmmodel.cxx
@@ -39,13 +39,11 @@ struct FmFormModelImplData
 {
     rtl::Reference<FmXUndoEnvironment>  mxUndoEnv;
     bool                bOpenInDesignIsDefaulted;
-    bool                bMovingPage;
     ::boost::optional< sal_Bool >
                             aControlsUseRefDevice;
 
     FmFormModelImplData()
         :bOpenInDesignIsDefaulted( true )
-        ,bMovingPage( false )
         ,aControlsUseRefDevice()
     {
     }
@@ -109,16 +107,6 @@ void FmFormModel::InsertPage(SdrPage* pPage, sal_uInt16 nPos)
     SdrModel::InsertPage( pPage, nPos );
 }
 
-void FmFormModel::MovePage( sal_uInt16 nPgNum, sal_uInt16 nNewPos )
-{
-    m_pImpl->bMovingPage = true;
-        // see InsertPage for this
-
-    SdrModel::MovePage( nPgNum, nNewPos );
-
-    m_pImpl->bMovingPage = false;
-}
-
 SdrPage* FmFormModel::RemovePage(sal_uInt16 nPgNum)
 {
     FmFormPage* pToBeRemovedPage = dynamic_cast< FmFormPage* >( GetPage( nPgNum ) );
diff --git a/svx/source/inc/fmPropBrw.hxx b/svx/source/inc/fmPropBrw.hxx
index 04c3a28ab467..5c7ca1cfb643 100644
--- a/svx/source/inc/fmPropBrw.hxx
+++ b/svx/source/inc/fmPropBrw.hxx
@@ -43,7 +43,6 @@ class FmFormShell;
 class FmPropBrw : public SfxFloatingWindow, public SfxControllerItem
 {
     bool            m_bInitialStateChange;
-    bool            m_bInStateChange;
     OUString        m_sLastActivePage;
     css::uno::Reference< css::uno::XComponentContext >
                     m_xInspectorContext;
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 151a1f19f2eb..74372fc48700 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -91,7 +91,6 @@ private:
     bool                m_bObject : 1;  // does the column reference an object datatype?
     bool                m_bHidden : 1;
     bool                m_bLocked : 1;
-    bool                m_bDateTime : 1;
 
     static ::svt::CellControllerRef s_xEmptyController;
         // used by locked columns
@@ -113,7 +112,6 @@ public:
         ,m_bObject(false)
         ,m_bHidden(false)
         ,m_bLocked(false)
-        ,m_bDateTime(false)
     {
     }
 
@@ -413,7 +411,6 @@ class DbFormattedField : public DbLimitedLengthField
 {
 protected:
     css::uno::Reference< css::util::XNumberFormatsSupplier >  m_xSupplier;
-    sal_Int16                       m_nKeyType;
 
 
 public:
diff --git a/svx/source/sidebar/line/LineWidthPopup.cxx b/svx/source/sidebar/line/LineWidthPopup.cxx
index 45c9f0db3d54..408619a6d364 100644
--- a/svx/source/sidebar/line/LineWidthPopup.cxx
+++ b/svx/source/sidebar/line/LineWidthPopup.cxx
@@ -36,9 +36,7 @@ LineWidthPopup::LineWidthPopup(LinePropertyPanelBase& rParent)
     , m_eMapUnit(MapUnit::MapTwip)
     , m_bVSFocus(true)
     , m_bCustom(false)
-    , m_bCloseByEdit(false)
     , m_nCustomWidth(0)
-    , m_nTmpCustomWidth(0)
     , m_aIMGCus(BitmapEx(RID_SVXBMP_WIDTH_CUSTOM))
     , m_aIMGCusGray(BitmapEx(RID_SVXBMP_WIDTH_CUSTOM_GRAY))
 {
@@ -123,8 +121,6 @@ IMPL_LINK(LineWidthPopup, VSSelectHdl, ValueSet*, /*pControl*/, void)
         m_rParent.setLineWidth(aWidthItem);
         m_rParent.SetWidthIcon(iPos);
         m_rParent.SetWidth(nVal);
-        m_bCloseByEdit = false;
-        m_nTmpCustomWidth = 0;
     }
     else if (iPos == 9)
     {//last custom
@@ -136,8 +132,6 @@ IMPL_LINK(LineWidthPopup, VSSelectHdl, ValueSet*, /*pControl*/, void)
             XLineWidthItem aWidthItem( nVal );
             m_rParent.setLineWidth(aWidthItem);
             m_rParent.SetWidth(nVal);
-            m_bCloseByEdit = false;
-            m_nTmpCustomWidth = 0;
         }
         else
         {
@@ -170,16 +164,12 @@ IMPL_LINK(LineWidthPopup, MFModifyHdl, Edit&, /*rControl*/, void)
     sal_Int32 nNewWidth = (short)m_xMFWidth->Denormalize( nVal );
     XLineWidthItem aWidthItem(nNewWidth);
     m_rParent.setLineWidth(aWidthItem);
-
-    m_bCloseByEdit = true;
-    m_nTmpCustomWidth = nTmp;
 }
 
 void LineWidthPopup::SetWidthSelect(long lValue, bool bValuable, MapUnit eMapUnit)
 {
     m_bVSFocus = true;
     m_xVSWidth->SetSelItem(0);
-    m_bCloseByEdit = false;
     m_eMapUnit = eMapUnit;
     SvtViewOptions aWinOpt( EViewType::Window, SIDEBAR_LINE_WIDTH_GLOBAL_VALUE );
     if (aWinOpt.Exists())
diff --git a/svx/source/sidebar/nbdtmg.cxx b/svx/source/sidebar/nbdtmg.cxx
index a23d69a54305..aa690a5d7be6 100644
--- a/svx/source/sidebar/nbdtmg.cxx
+++ b/svx/source/sidebar/nbdtmg.cxx
@@ -418,8 +418,6 @@ void NumberingTypeMgr::Init()
         {
             NumSettings_Impl* pNew = lcl_CreateNumberingSettingsPtr(pValuesArr[i]);
             NumberSettings_Impl* pNumEntry = new NumberSettings_Impl;
-            pNumEntry->nIndex = i + 1;
-            pNumEntry->nIndexDefault = i;
             pNumEntry->pNumSetting = pNew;
             if ( i < 8 )
                 pNumEntry->sDescription = SvxResId( RID_SVXSTR_SINGLENUM_DESCRIPTIONS + i );
diff --git a/svx/source/svdraw/svddrgv.cxx b/svx/source/svdraw/svddrgv.cxx
index 2c4d78762e03..1f8ed61d7817 100644
--- a/svx/source/svdraw/svddrgv.cxx
+++ b/svx/source/svdraw/svddrgv.cxx
@@ -56,7 +56,6 @@ void SdrDragView::ImpClearVars()
     meDragHdl=SdrHdlKind::Move;
     mpDragHdl=nullptr;
     mbDragHdl=false;
-    mbDragSpecial=false;
     mpCurrentSdrDragMethod=nullptr;
     mbDragStripes=false;
     mbDragWithCopy=false;
@@ -67,7 +66,6 @@ void SdrDragView::ImpClearVars()
     mnDragXorPolyLimit=100;
     mnDragXorPointLimit=500;
     mbNoDragXorPolys=false;
-    mnDetailedEdgeDraggingLimit=10;
     mbResizeAtCenter=false;
     mbCrookAtCenter=false;
 
@@ -206,7 +204,6 @@ bool SdrDragView::BegDragObj(const Point& rPnt, OutputDevice* pOut, SdrHdl* pHdl
         SetDragWithCopy(false);
         //TODO: aAni.Reset();
         mpCurrentSdrDragMethod=nullptr;
-        mbDragSpecial=false;
         mbDragLimit=false;
         SdrDragMode eTmpMode=meDragMode;
         if (eTmpMode==SdrDragMode::Move && pHdl!=nullptr && pHdl->GetKind()!=SdrHdlKind::Move) {
@@ -462,7 +459,6 @@ bool SdrDragView::BegDragObj(const Point& rPnt, OutputDevice* pOut, SdrHdl* pHdl
                             if(!mpCurrentSdrDragMethod)
                             {
                                 // fallback to DragSpecial if no interaction defined
-                                mbDragSpecial = true;
                                 mpCurrentSdrDragMethod = new SdrDragObjOwn(*this);
                             }
                         }
@@ -486,7 +482,6 @@ bool SdrDragView::BegDragObj(const Point& rPnt, OutputDevice* pOut, SdrHdl* pHdl
                     // Obj may not Move SpecialDrag, so try with MoveFrameDrag
                     delete mpCurrentSdrDragMethod;
                     mpCurrentSdrDragMethod = nullptr;
-                    mbDragSpecial=false;
 
                     if (!IsMoveAllowed())
                         return false;
diff --git a/svx/source/svdraw/svdedtv.cxx b/svx/source/svdraw/svdedtv.cxx
index cdb208e571eb..0382ffc77659 100644
--- a/svx/source/svdraw/svdedtv.cxx
+++ b/svx/source/svdraw/svdedtv.cxx
@@ -48,7 +48,6 @@ void SdrEditView::ImpResetPossibilityFlags()
     bGroupPossible          =false;
     bUnGroupPossible        =false;
     bGrpEnterPossible       =false;
-    bDeletePossible         =false;
     bToTopPossible          =false;
     bToBtmPossible          =false;
     bReverseOrderPossible   =false;
@@ -60,7 +59,6 @@ void SdrEditView::ImpResetPossibilityFlags()
     bDismantleMakeLinesPossible=false;
     bOrthoDesiredOnMarked   =false;
 
-    bMoreThanOneNotMovable  =false;
     bOneOrMoreMovable       =false;
     bMoreThanOneNoMovRot    =false;
     bContortionPossible     =false;
@@ -80,8 +78,6 @@ void SdrEditView::ImpResetPossibilityFlags()
     bCanConvToPath          =false;
     bCanConvToPoly          =false;
     bCanConvToContour       =false;
-    bCanConvToPathLineToArea=false;
-    bCanConvToPolyLineToArea=false;
     bMoveProtect            =false;
     bResizeProtect          =false;
 }
@@ -90,7 +86,6 @@ void SdrEditView::ImpClearVars()
 {
     ImpResetPossibilityFlags();
     bPossibilitiesDirty=true;   // << Purify didn't like this
-    bBundleVirtObj=false;
 }
 
 SdrEditView::SdrEditView(SdrModel* pModel1, OutputDevice* pOut):
@@ -492,7 +487,6 @@ void SdrEditView::CheckPossibilities()
                 }
             }
             bCombineNoPolyPolyPossible=bCombinePossible;
-            bDeletePossible=true;
             // accept transformations for now
             bMoveAllowed      =true;
             bResizeFreeAllowed=true;
@@ -591,8 +585,6 @@ void SdrEditView::CheckPossibilities()
                 // ConvertToCurve: If at least one can be converted, that is fine.
                 if (aInfo.bCanConvToPath          ) bCanConvToPath          =true;
                 if (aInfo.bCanConvToPoly          ) bCanConvToPoly          =true;
-                if (aInfo.bCanConvToPathLineToArea) bCanConvToPathLineToArea=true;
-                if (aInfo.bCanConvToPolyLineToArea) bCanConvToPolyLineToArea=true;
 
                 // Combine/Dismantle
                 if(bCombinePossible)
@@ -624,7 +616,6 @@ void SdrEditView::CheckPossibilities()
                 }
             }
 
-            bMoreThanOneNotMovable=nMovableCount<nMarkCount-1;
             bOneOrMoreMovable=nMovableCount!=0;
             bGrpEnterPossible=bUnGroupPossible;
         }
diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx
index 2643788d7e2c..cb7fa37892f1 100644
--- a/svx/source/svdraw/svdedxv.cxx
+++ b/svx/source/svdraw/svdedxv.cxx
@@ -76,7 +76,6 @@ void SdrObjEditView::ImpClearVars()
     pTextEditPV=nullptr;
     pTextEditWin=nullptr;
     pTextEditCursorMerker=nullptr;
-    pEditPara=nullptr;
     bTextEditNewObj=false;
     bMacroDown=false;
     pMacroObj=nullptr;
diff --git a/svx/source/svdraw/svdetc.cxx b/svx/source/svdraw/svdetc.cxx
index 3e78145dcf7f..ba73c511b18b 100644
--- a/svx/source/svdraw/svdetc.cxx
+++ b/svx/source/svdraw/svdetc.cxx
@@ -496,7 +496,6 @@ sal_uInt16* RemoveWhichRange(const sal_uInt16* pOldWhichTable, sal_uInt16 nRange
 SvdProgressInfo::SvdProgressInfo( const Link<void*,bool>&_rLink )
 {
     maLink = _rLink;
-    m_nSumActionCount = 0;
     m_nSumCurAction   = 0;
 
     m_nObjCount = 0;
@@ -509,9 +508,8 @@ SvdProgressInfo::SvdProgressInfo( const Link<void*,bool>&_rLink )
     m_nCurInsert   = 0;
 }
 
-void SvdProgressInfo::Init( size_t nSumActionCount, size_t nObjCount )
+void SvdProgressInfo::Init( size_t nObjCount )
 {
-    m_nSumActionCount = nSumActionCount;
     m_nObjCount = nObjCount;
 }
 
diff --git a/svx/source/svdraw/svdibrow.cxx b/svx/source/svdraw/svdibrow.cxx
index 303ecff96f45..f3aab1a70f86 100644
--- a/svx/source/svdraw/svdibrow.cxx
+++ b/svx/source/svdraw/svdibrow.cxx
@@ -232,15 +232,9 @@ void SdrItemBrowserControl::ImpCtor()
     pAktChangeEntry = nullptr;
     nLastWhichOfs = 0;
     nLastWhich = 0;
-    nLastWhichOben = 0;  // not implemented yet
-    nLastWhichUnten = 0; // not implemented yet
     bWhichesButNames = false;
     bDontHideIneffectiveItems = false;
     bDontSortItems = false;
-    bShowWhichIds = false;
-    bShowRealValues = false;
-    bShowWhichIds = true;   // not implemented yet
-    bShowRealValues = true; // not implemented yet
 
     InsertDataColumn(
         ITEMBROWSER_WHICHCOL_ID,
@@ -459,8 +453,6 @@ void SdrItemBrowserControl::ImpSaveWhich()
         nLastWhichOfs=nPos-nTop;
         if (nTop<0) nTop=0;
         if (nBtm>=(long)aList.size()) nBtm=aList.size()-1;
-        nLastWhichOben=ImpGetEntry(nTop)->nWhichId;
-        nLastWhichUnten=ImpGetEntry(nBtm)->nWhichId;
     }
 }
 
diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx
index e970442823d1..d487bfd25832 100644
--- a/svx/source/svdraw/svdmodel.cxx
+++ b/svx/source/svdraw/svdmodel.cxx
@@ -124,7 +124,6 @@ void SdrModel::ImpCtor(SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* _pEmbe
     eUIUnit=FUNIT_MM;
     aUIScale=Fraction(1,1);
     nUIUnitDecimalMark=0;
-    bUIOnlyDecimalMark=false;
     pLayerAdmin=nullptr;
     pItemPool=pPool;
     bMyPool=false;
@@ -150,12 +149,9 @@ void SdrModel::ImpCtor(SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* _pEmbe
     nSwapGraphicsMode=SdrSwapGraphicsMode::DEFAULT;
     bPasteResize=false;
     bReadOnly=false;
-    nStreamNumberFormat=SvStreamEndian::BIG;
     nDefaultTabulator=0;
-    mpNumberFormatter = nullptr;
     bTransparentTextFrames=false;
     bStarDrawPreviewMode = false;
-    nStarDrawPreviewMasterPageNum = SDRPAGE_NOTFOUND;
     mpForbiddenCharactersTable = nullptr;
     mbModelLocked = false;
     mpOutlinerCache = nullptr;
@@ -172,9 +168,6 @@ void SdrModel::ImpCtor(SfxItemPool* pPool, ::comphelper::IEmbeddedHelper* _pEmbe
     else
         mnCharCompressType = CharCompressType::NONE;
 
-#ifdef OSL_LITENDIAN
-    nStreamNumberFormat=SvStreamEndian::LITTLE;
-#endif
     bExtColorTable=bUseExtColorTable;
 
     if ( pPool == nullptr )
@@ -304,8 +297,6 @@ SdrModel::~SdrModel()
 
     mpForbiddenCharactersTable.clear();
 
-    delete mpNumberFormatter;
-
     delete mpImpl->mpUndoFactory;
 }
 
@@ -1042,7 +1033,6 @@ void SdrModel::ImpSetUIUnit()
 
     // end preparations, set member values
     aUIUnitFact = Fraction(sal_Int32(nMul), sal_Int32(nDiv));
-    bUIOnlyDecimalMark = (nMul == nDiv);
     TakeUnitStr(eUIUnit, aUIUnitStr);
 }
 
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 333eb014a9c9..c2094783068d 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -138,7 +138,6 @@ void SdrMarkView::ImpClearVars()
     mbMarkedPointsRectsDirty=false;
     mbMarkHandlesHidden = false;
     mbMrkPntDirty=false;
-    mbMarkHdlWhenTextEdit=false;
 
     // Migrate selections
     BrkMarkObj();
diff --git a/svx/source/tbxctrls/itemwin.cxx b/svx/source/tbxctrls/itemwin.cxx
index 92f845b7ac48..fb513a9bd596 100644
--- a/svx/source/tbxctrls/itemwin.cxx
+++ b/svx/source/tbxctrls/itemwin.cxx
@@ -383,8 +383,7 @@ void SvxMetricField::DataChanged( const DataChangedEvent& rDCEvt )
 SvxFillTypeBox::SvxFillTypeBox( vcl::Window* pParent ) :
     FillTypeLB( pParent, WB_BORDER | WB_DROPDOWN | WB_AUTOHSCROLL | WB_TABSTOP ),
     nCurPos ( 0 ),
-    bSelect ( false ),
-    bRelease( true )
+    bSelect ( false )
 {
     SetSizePixel( LogicToPixel( Size(40, 40 ),MapUnit::MapAppFont ));
     Fill();
@@ -433,10 +432,9 @@ bool SvxFillTypeBox::EventNotify( NotifyEvent& rNEvt )
                 bHandled = true;
                 GetSelectHdl().Call( *this );
             break;
+
             case KEY_TAB:
-                bRelease = false;
                 GetSelectHdl().Call( *this );
-                bRelease = true;
                 break;
 
             case KEY_ESCAPE:
@@ -463,9 +461,7 @@ void SvxFillTypeBox::ReleaseFocus_Impl()
 
 SvxFillAttrBox::SvxFillAttrBox( vcl::Window* pParent ) :
     FillAttrLB( pParent, WB_BORDER | WB_DROPDOWN | WB_AUTOHSCROLL | WB_TABSTOP ),
-    nCurPos( 0 ),
-    bRelease( true )
-
+    nCurPos( 0 )
 {
     SetPosPixel( Point( 90, 0 ) );
     SetSizePixel( LogicToPixel( Size(50, 80 ), MapUnit::MapAppFont ));
@@ -500,9 +496,7 @@ bool SvxFillAttrBox::EventNotify( NotifyEvent& rNEvt )
                 bHandled = true;
             break;
             case KEY_TAB:
-                bRelease = false;
                 GetSelectHdl().Call( *this );
-                bRelease = true;
             break;
             case KEY_ESCAPE:
                 SelectEntryPos( nCurPos );