diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2016-06-04 20:43:44 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2016-06-04 20:43:44 +0100 |
| commit | 301a87c861842a616e3e5593c664980466d58ffe (patch) | |
| tree | ba1961d1da777db7144ab5b5516aef86608e1807 /svx | |
| parent | 4005d61cd1bdd71bb74c316f3ad30d23ba459b90 (diff) | |
Resolves: tdf#100201 crash on apply custom color
regression from...
commit 789055bc2acb4c71483fd60ea258d158bd5aec10
Date: Tue Apr 12 16:39:03 2016 +0200
clang-tidy performance-unnecessary-copy-initialization
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
This case has a comment explaining the problem that appeared post
change.
Change-Id: Ib0c0883c57f103656cda00e3a94399a515d7fe41
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/tbxctrls/PaletteManager.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svx/source/tbxctrls/PaletteManager.cxx b/svx/source/tbxctrls/PaletteManager.cxx index 4acf2e469be0..535134f344de 100644 --- a/svx/source/tbxctrls/PaletteManager.cxx +++ b/svx/source/tbxctrls/PaletteManager.cxx @@ -227,7 +227,7 @@ void PaletteManager::SetColorSelectFunction(const std::function<void(const OUStr void PaletteManager::PopupColorPicker(const OUString& aCommand) { // The calling object goes away during aColorDlg.Execute(), so we must copy this - const OUString& aCommandCopy = aCommand; + OUString aCommandCopy = aCommand; SvColorDialog aColorDlg( nullptr ); aColorDlg.SetColor ( mLastColor ); aColorDlg.SetMode( svtools::ColorPickerMode_MODIFY ); |