loplugin:unusedvariablecheck tweak to find more stuff

but leave the tweak commented out, since it generates false positives

Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c
Reviewed-on: https://gerrit.libreoffice.org/82121
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 2 insertions, 10 deletions

diff --git a/svx/source/sidebar/PanelFactory.cxx b/svx/source/sidebar/PanelFactory.cxx
index 78d0113001a2..a22a889a382a 100644
--- a/svx/source/sidebar/PanelFactory.cxx
+++ b/svx/source/sidebar/PanelFactory.cxx
@@ -103,9 +103,6 @@ Reference<ui::XUIElement> SAL_CALL PanelFactory::createUIElement (
     Reference<ui::XSidebar> xSidebar (aArguments.getOrDefault("Sidebar", Reference<ui::XSidebar>()));
     const sal_uInt64 nBindingsValue (aArguments.getOrDefault("SfxBindings", sal_uInt64(0)));
     SfxBindings* pBindings = reinterpret_cast<SfxBindings*>(nBindingsValue);
-    vcl::EnumContext aContext (
-        aArguments.getOrDefault("ApplicationName", OUString()),
-        aArguments.getOrDefault("ContextName", OUString()));
 
     VclPtr<vcl::Window> pParentWindow = VCLUnoHelper::GetWindow(xParentWindow);
     if ( ! xParentWindow.is() || pParentWindow==nullptr)
diff --git a/svx/source/svdraw/gradtrns.hxx b/svx/source/svdraw/gradtrns.hxx
index 7e6e02f1854e..eee35582a9b0 100644
--- a/svx/source/svdraw/gradtrns.hxx
+++ b/svx/source/svdraw/gradtrns.hxx
@@ -40,10 +40,9 @@ public:
     XGradient                   aGradient;
 };
 
-class GradTransformer
+struct GradTransformer
 {
-public:
-    GradTransformer() {}
+    GradTransformer() = delete;
 
     static void GradToVec(GradTransGradient const & rG, GradTransVector& rV,
         const SdrObject* pObj);
diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 7bbd56293a0d..e6fd42899721 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -1371,7 +1371,6 @@ void SdrHdlGradient::FromIAOToItem(SdrObject* _pObj, bool bSetItemOnObject, bool
     // from IAO positions and colors to gradient
     const SfxItemSet& rSet = _pObj->GetMergedItemSet();
 
-    GradTransformer aGradTransformer;
     GradTransGradient aOldGradTransGradient;
     GradTransGradient aGradTransGradient;
     GradTransVector aGradTransVector;
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 332ef71b1bb9..a3fce9ec2821 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -1318,7 +1318,6 @@ void SdrMarkView::AddDragModeHdl(SdrDragMode eMode)
                 }
 
                 // set values and transform to vector set
-                GradTransformer aGradTransformer;
                 GradTransVector aGradTransVector;
                 GradTransGradient aGradTransGradient;
 
@@ -1359,7 +1358,6 @@ void SdrMarkView::AddDragModeHdl(SdrDragMode eMode)
                 if(eFillStyle == drawing::FillStyle_GRADIENT)
                 {
                     // set values and transform to vector set
-                    GradTransformer aGradTransformer;
                     GradTransVector aGradTransVector;
                     GradTransGradient aGradTransGradient;
                     Size aHdlSize(15, 15);
diff --git a/svx/source/svdraw/svdoedge.cxx b/svx/source/svdraw/svdoedge.cxx
index c2afd2195101..8b84492dd48f 100644
--- a/svx/source/svdraw/svdoedge.cxx
+++ b/svx/source/svdraw/svdoedge.cxx
@@ -2149,7 +2149,6 @@ bool SdrEdgeObj::ImpFindConnector(const Point& rPt, const SdrPageView& rPV, SdrO
     size_t no=pOL->GetObjCount();
     bool bFnd = false;
     SdrObjConnection aTestCon;
-    SdrObjConnection aBestCon;
 
     while (no>0 && !bFnd) {
         // issue: group objects on different layers return LayerID=0!