Remove unused copy assignment ops of SfxPoolItem-derived classes

SfxPoolItem has the curious design of non-deleted copy ctor and deleted copy
assignment op.  Many derived classes then provide a non-deleted assignment op,
apparently more or less on an as-needed basis.  But some of those user-provided
assignment ops are actually unused (and their presence causes
-Werror=deprecated-copy with GCC trunk towards GCC 9 when the---implicitly-
defined---copy ctor of the derived class is used), so remove them.  In some
cases that would still cause -Werror=deprected-copy because of a user-declared
dtor, so in those cases explicitly default all the copy/move functions (some of
which will then be implicitly defined as deleted).

Change-Id: If0d9f1a9f3954263a39ffd27ba895d6202afa307
Reviewed-on: https://gerrit.libreoffice.org/58133
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 0 insertions, 10 deletions

diff --git a/svx/source/inc/fmitems.hxx b/svx/source/inc/fmitems.hxx
index 10dcebfe73fc..7947b9e75028 100644
--- a/svx/source/inc/fmitems.hxx
+++ b/svx/source/inc/fmitems.hxx
@@ -34,22 +34,12 @@ public:
         ,xInterface( rxInterface )
     {}
 
-    inline FmInterfaceItem&  operator=( const FmInterfaceItem &rCpy );
-
     // "purely virtual methods" of the SfxPoolItem
     virtual bool            operator==( const SfxPoolItem& ) const override;
 
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
 };
 
-inline FmInterfaceItem& FmInterfaceItem::operator=( const FmInterfaceItem &rCpy )
-{
-    xInterface = rCpy.xInterface;
-
-    return *this;
-}
-
-
 #endif // INCLUDED_SVX_SOURCE_INC_FMITEMS_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */